From: Roman Gushchin <guro@fb.com>
To: Muchun Song <songmuchun@bytedance.com>
Cc: <hannes@cmpxchg.org>, <mhocko@kernel.org>,
<akpm@linux-foundation.org>, <shakeelb@google.com>,
<vdavydov.dev@gmail.com>, <linux-kernel@vger.kernel.org>,
<linux-mm@kvack.org>, <duanxiongchun@bytedance.com>
Subject: Re: [PATCH v3 4/4] mm: memcontrol: move PageMemcgKmem to the scope of CONFIG_MEMCG_KMEM
Date: Wed, 10 Mar 2021 11:30:50 -0800 [thread overview]
Message-ID: <YEkeamViToqIyVP8@carbon.dhcp.thefacebook.com> (raw)
In-Reply-To: <20210309100717.253-5-songmuchun@bytedance.com>
On Tue, Mar 09, 2021 at 06:07:17PM +0800, Muchun Song wrote:
> The page only can be marked as kmem when CONFIG_MEMCG_KMEM is enabled.
> So move PageMemcgKmem() to the scope of the CONFIG_MEMCG_KMEM.
>
> As a bonus, on !CONFIG_MEMCG_KMEM build some code can be compiled out.
>
> Signed-off-by: Muchun Song <songmuchun@bytedance.com>
Nice!
Acked-by: Roman Gushchin <guro@fb.com>
Thanks!
> ---
> include/linux/memcontrol.h | 7 ++++++-
> 1 file changed, 6 insertions(+), 1 deletion(-)
>
> diff --git a/include/linux/memcontrol.h b/include/linux/memcontrol.h
> index 07c449af9c0f..d3ca8c8e7fc3 100644
> --- a/include/linux/memcontrol.h
> +++ b/include/linux/memcontrol.h
> @@ -469,6 +469,7 @@ static inline struct mem_cgroup *page_memcg_check(struct page *page)
> return (struct mem_cgroup *)(memcg_data & ~MEMCG_DATA_FLAGS_MASK);
> }
>
> +#ifdef CONFIG_MEMCG_KMEM
> /*
> * PageMemcgKmem - check if the page has MemcgKmem flag set
> * @page: a pointer to the page struct
> @@ -483,7 +484,6 @@ static inline bool PageMemcgKmem(struct page *page)
> return page->memcg_data & MEMCG_DATA_KMEM;
> }
>
> -#ifdef CONFIG_MEMCG_KMEM
> /*
> * page_objcgs - get the object cgroups vector associated with a page
> * @page: a pointer to the page struct
> @@ -544,6 +544,11 @@ static inline struct obj_cgroup *page_objcg(struct page *page)
> return (struct obj_cgroup *)(memcg_data & ~MEMCG_DATA_FLAGS_MASK);
> }
> #else
> +static inline bool PageMemcgKmem(struct page *page)
> +{
> + return false;
> +}
> +
> static inline struct obj_cgroup **page_objcgs(struct page *page)
> {
> return NULL;
> --
> 2.11.0
>
next prev parent reply other threads:[~2021-03-10 19:31 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-09 10:07 [PATCH v3 0/4] Use obj_cgroup APIs to charge kmem pages Muchun Song
2021-03-09 10:07 ` [PATCH v3 1/4] mm: memcontrol: introduce obj_cgroup_{un}charge_pages Muchun Song
2021-03-11 12:30 ` Johannes Weiner
2021-03-11 18:56 ` Shakeel Butt
2021-03-09 10:07 ` [PATCH v3 2/4] mm: memcontrol: make page_memcg{_rcu} only applicable for non-kmem page Muchun Song
2021-03-10 19:57 ` Roman Gushchin
2021-03-11 6:45 ` [External] " Muchun Song
2021-03-11 13:12 ` Johannes Weiner
2021-03-12 7:14 ` [External] " Muchun Song
2021-03-12 19:23 ` Johannes Weiner
2021-03-12 22:42 ` Shakeel Butt
2021-03-12 23:07 ` Johannes Weiner
2021-03-12 23:18 ` Shakeel Butt
2021-03-14 13:56 ` Muchun Song
2021-03-12 3:22 ` Shakeel Butt
2021-03-12 5:02 ` [External] " Muchun Song
2021-03-09 10:07 ` [PATCH v3 3/4] mm: memcontrol: use obj_cgroup APIs to charge kmem pages Muchun Song
2021-03-10 19:53 ` Roman Gushchin
2021-03-11 6:50 ` [External] " Muchun Song
2021-03-10 22:05 ` Johannes Weiner
2021-03-12 9:22 ` [External] " Muchun Song
2021-03-12 15:59 ` Johannes Weiner
2021-03-12 16:46 ` Muchun Song
2021-03-11 17:48 ` kernel test robot
2021-03-09 10:07 ` [PATCH v3 4/4] mm: memcontrol: move PageMemcgKmem to the scope of CONFIG_MEMCG_KMEM Muchun Song
2021-03-10 19:30 ` Roman Gushchin [this message]
2021-03-12 3:26 ` Shakeel Butt
2021-03-12 19:24 ` Johannes Weiner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YEkeamViToqIyVP8@carbon.dhcp.thefacebook.com \
--to=guro@fb.com \
--cc=akpm@linux-foundation.org \
--cc=duanxiongchun@bytedance.com \
--cc=hannes@cmpxchg.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@kernel.org \
--cc=shakeelb@google.com \
--cc=songmuchun@bytedance.com \
--cc=vdavydov.dev@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).