From: Michal Hocko <mhocko@suse.com>
To: "Paul E. McKenney" <paulmck@kernel.org>
Cc: Mike Kravetz <mike.kravetz@oracle.com>,
Muchun Song <songmuchun@bytedance.com>,
corbet@lwn.net, tglx@linutronix.de, mingo@redhat.com,
bp@alien8.de, x86@kernel.org, hpa@zytor.com,
dave.hansen@linux.intel.com, luto@kernel.org,
peterz@infradead.org, viro@zeniv.linux.org.uk,
akpm@linux-foundation.org, mchehab+huawei@kernel.org,
pawan.kumar.gupta@linux.intel.com, rdunlap@infradead.org,
oneukum@suse.com, anshuman.khandual@arm.com, jroedel@suse.de,
almasrymina@google.com, rientjes@google.com, willy@infradead.org,
osalvador@suse.de, song.bao.hua@hisilicon.com, david@redhat.com,
naoya.horiguchi@nec.com, joao.m.martins@oracle.com,
duanxiongchun@bytedance.com, linux-doc@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
linux-fsdevel@vger.kernel.org, Chen Huang <chenhuang5@huawei.com>,
Bodeddula Balasubramaniam <bodeddub@amazon.com>
Subject: Re: [PATCH v18 4/9] mm: hugetlb: alloc the vmemmap pages associated with each HugeTLB page
Date: Thu, 11 Mar 2021 09:40:54 +0100 [thread overview]
Message-ID: <YEnXllhPEQhT0CRt@dhcp22.suse.cz> (raw)
In-Reply-To: <20210310232851.GZ2696@paulmck-ThinkPad-P72>
On Wed 10-03-21 15:28:51, Paul E. McKenney wrote:
> On Wed, Mar 10, 2021 at 02:10:12PM -0800, Mike Kravetz wrote:
> > On 3/10/21 1:49 PM, Paul E. McKenney wrote:
> > > On Wed, Mar 10, 2021 at 10:11:22PM +0100, Michal Hocko wrote:
> > >> On Wed 10-03-21 10:56:08, Mike Kravetz wrote:
> > >>> On 3/10/21 7:19 AM, Michal Hocko wrote:
> > >>>> On Mon 08-03-21 18:28:02, Muchun Song wrote:
> > >>>> [...]
> > >>>>> @@ -1447,7 +1486,7 @@ void free_huge_page(struct page *page)
> > >>>>> /*
> > >>>>> * Defer freeing if in non-task context to avoid hugetlb_lock deadlock.
> > >>>>> */
> > >>>>> - if (!in_task()) {
> > >>>>> + if (in_atomic()) {
> > >>>>
> > >>>> As I've said elsewhere in_atomic doesn't work for CONFIG_PREEMPT_COUNT=n.
> > >>>> We need this change for other reasons and so it would be better to pull
> > >>>> it out into a separate patch which also makes HUGETLB depend on
> > >>>> PREEMPT_COUNT.
> > >>>
> > >>> Yes, the issue of calling put_page for hugetlb pages from any context
> > >>> still needs work. IMO, that is outside the scope of this series. We
> > >>> already have code in this path which blocks/sleeps.
> > >>>
> > >>> Making HUGETLB depend on PREEMPT_COUNT is too restrictive. IIUC,
> > >>> PREEMPT_COUNT will only be enabled if we enable:
> > >>> PREEMPT "Preemptible Kernel (Low-Latency Desktop)"
> > >>> PREEMPT_RT "Fully Preemptible Kernel (Real-Time)"
> > >>> or, other 'debug' options. These are not enabled in 'more common'
> > >>> kernels. Of course, we do not want to disable HUGETLB in common
> > >>> configurations.
> > >>
> > >> I haven't tried that but PREEMPT_COUNT should be selectable even without
> > >> any change to the preemption model (e.g. !PREEMPT).
> > >
> > > It works reliably for me, for example as in the diff below. So,
> > > as Michal says, you should be able to add "select PREEMPT_COUNT" to
> > > whatever Kconfig option you need to.
> > >
> >
> > Thanks Paul.
> >
> > I may have been misreading Michal's suggestion of "make HUGETLB depend on
> > PREEMPT_COUNT". We could "select PREEMPT_COUNT" if HUGETLB is enabled.
> > However, since HUGETLB is enabled in most configs, then this would
> > result in PREEMPT_COUNT also being enabled in most configs. I honestly
> > do not know how much this will cost us? I assume that if it was free or
> > really cheap it would already be always on?
>
> There are a -lot- of configs out there, so are you sure that HUGETLB is
> really enabled in most of them? ;-)
It certainly is enabled for all distribution kernels and many are
!PREEMPT so I believe this is what Mike was concerned about.
> More seriously, I was going by earlier emails in this and related threads
> plus Michal's "PREEMPT_COUNT should be selectable". But there are other
> situations that would like PREEMPT_COUNT. And to your point, some who
> would rather PREEMPT_COUNT not be universally enabled. I haven't seen
> any performance or kernel-size numbers from any of them, however.
Yeah per cpu preempt counting shouldn't be noticeable but I have to
confess I haven't benchmarked it.
--
Michal Hocko
SUSE Labs
next prev parent reply other threads:[~2021-03-11 8:41 UTC|newest]
Thread overview: 52+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-08 10:27 [PATCH v18 0/9] Free some vmemmap pages of HugeTLB page Muchun Song
2021-03-08 10:27 ` [PATCH v18 1/9] mm: memory_hotplug: factor out bootmem core functions to bootmem_info.c Muchun Song
2021-03-10 14:14 ` Michal Hocko
2021-03-11 2:58 ` [External] " Muchun Song
2021-03-11 8:45 ` Muchun Song
2021-03-11 8:53 ` Michal Hocko
2021-03-11 9:05 ` Muchun Song
2021-03-08 10:28 ` [PATCH v18 2/9] mm: hugetlb: introduce a new config HUGETLB_PAGE_FREE_VMEMMAP Muchun Song
2021-03-08 10:28 ` [PATCH v18 3/9] mm: hugetlb: free the vmemmap pages associated with each HugeTLB page Muchun Song
2021-03-10 14:32 ` Michal Hocko
2021-03-11 3:35 ` [External] " Muchun Song
2021-03-08 10:28 ` [PATCH v18 4/9] mm: hugetlb: alloc " Muchun Song
2021-03-10 14:21 ` Oscar Salvador
2021-03-11 4:13 ` [External] " Muchun Song
2021-03-10 15:19 ` Michal Hocko
2021-03-10 18:56 ` Mike Kravetz
2021-03-10 21:11 ` Michal Hocko
2021-03-10 21:49 ` Paul E. McKenney
2021-03-10 22:10 ` Mike Kravetz
2021-03-10 23:28 ` Paul E. McKenney
2021-03-11 8:40 ` Michal Hocko [this message]
2021-03-11 12:17 ` Michal Hocko
2021-03-11 17:59 ` Mike Kravetz
2021-03-11 22:53 ` Mike Kravetz
2021-03-12 8:15 ` Michal Hocko
2021-03-12 17:50 ` Mike Kravetz
2021-03-11 4:26 ` [External] " Muchun Song
2021-03-11 8:46 ` Michal Hocko
2021-03-11 8:49 ` Muchun Song
2021-03-08 10:28 ` [PATCH v18 5/9] mm: hugetlb: set the PageHWPoison to the raw error page Muchun Song
2021-03-10 15:27 ` Michal Hocko
2021-03-11 6:34 ` [External] " Muchun Song
2021-03-11 8:50 ` Michal Hocko
2021-03-11 9:13 ` Muchun Song
2021-03-08 10:28 ` [PATCH v18 6/9] mm: hugetlb: add a kernel parameter hugetlb_free_vmemmap Muchun Song
2021-03-10 15:37 ` Michal Hocko
2021-03-10 17:15 ` Randy Dunlap
2021-03-11 6:36 ` [External] " Muchun Song
2021-03-11 6:36 ` Muchun Song
2021-03-08 10:28 ` [PATCH v18 7/9] mm: hugetlb: introduce nr_free_vmemmap_pages in the struct hstate Muchun Song
2021-03-08 10:28 ` [PATCH v18 8/9] mm: hugetlb: gather discrete indexes of tail page Muchun Song
2021-03-10 15:39 ` Michal Hocko
2021-03-08 10:28 ` [PATCH v18 9/9] mm: hugetlb: optimize the code with the help of the compiler Muchun Song
2021-03-10 15:41 ` Michal Hocko
2021-03-11 7:33 ` [External] " Muchun Song
2021-03-11 8:55 ` Michal Hocko
2021-03-11 9:08 ` Muchun Song
2021-03-11 9:39 ` Michal Hocko
2021-03-11 10:00 ` Muchun Song
2021-03-11 12:16 ` Michal Hocko
2021-03-11 13:00 ` Muchun Song
2021-03-11 13:45 ` Oscar Salvador
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YEnXllhPEQhT0CRt@dhcp22.suse.cz \
--to=mhocko@suse.com \
--cc=akpm@linux-foundation.org \
--cc=almasrymina@google.com \
--cc=anshuman.khandual@arm.com \
--cc=bodeddub@amazon.com \
--cc=bp@alien8.de \
--cc=chenhuang5@huawei.com \
--cc=corbet@lwn.net \
--cc=dave.hansen@linux.intel.com \
--cc=david@redhat.com \
--cc=duanxiongchun@bytedance.com \
--cc=hpa@zytor.com \
--cc=joao.m.martins@oracle.com \
--cc=jroedel@suse.de \
--cc=linux-doc@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=luto@kernel.org \
--cc=mchehab+huawei@kernel.org \
--cc=mike.kravetz@oracle.com \
--cc=mingo@redhat.com \
--cc=naoya.horiguchi@nec.com \
--cc=oneukum@suse.com \
--cc=osalvador@suse.de \
--cc=paulmck@kernel.org \
--cc=pawan.kumar.gupta@linux.intel.com \
--cc=peterz@infradead.org \
--cc=rdunlap@infradead.org \
--cc=rientjes@google.com \
--cc=song.bao.hua@hisilicon.com \
--cc=songmuchun@bytedance.com \
--cc=tglx@linutronix.de \
--cc=viro@zeniv.linux.org.uk \
--cc=willy@infradead.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).