From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 05658C433DB for ; Wed, 17 Mar 2021 19:29:20 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 73BDA64E42 for ; Wed, 17 Mar 2021 19:29:19 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 73BDA64E42 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id DFA266B006E; Wed, 17 Mar 2021 15:29:18 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D83186B0070; Wed, 17 Mar 2021 15:29:18 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BD7DF6B0071; Wed, 17 Mar 2021 15:29:18 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0140.hostedemail.com [216.40.44.140]) by kanga.kvack.org (Postfix) with ESMTP id 9C58A6B006E for ; Wed, 17 Mar 2021 15:29:18 -0400 (EDT) Received: from smtpin01.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 58189365D for ; Wed, 17 Mar 2021 19:29:18 +0000 (UTC) X-FDA: 77930354754.01.5B51F23 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf01.hostedemail.com (Postfix) with ESMTP id 1E7C82026174 for ; Wed, 17 Mar 2021 17:16:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=Qo/0CZaBM3vkvFlSWE2vylgaMs07ND+ounCESWbPsMM=; b=WGk9Jgcw3Hce04yEcMePRI9NYv ygnDik4lNoZ362rDXAs3XCruJZIJMC5E45P7lWB7mm3n79CTiokm2MF2xPseygKgvhuDO+jtm0Sf2 qHcUt8pXP1retMuf+tuRpBDPi3MY1kqrWzVn/7iQzWdQ0e8r0StY4PQEU6Bay09obpcMwAM0BHUFZ 2ZljVb1X7T1I8EtltRiL6uvm80lOa5Eh/sTXU3bjImvVc/JFHG/YCq2JV5B5VUsrUQFhwT5Svp6BT FS2XmN1eqTOvJkZpLapn8DX+3Bsc2gqlqGdCYwNiUHC6LEqUi2O3xJCikZN9ROF0HDVeyCjGqPMJg hHC0WYhg==; Received: from [2001:4bb8:18c:bb3:e3eb:4a4b:ba2f:224b] (helo=localhost) by casper.infradead.org with esmtpsa (Exim 4.94 #2 (Red Hat Linux)) id 1lMZmn-001tuO-KJ; Wed, 17 Mar 2021 17:16:47 +0000 Date: Wed, 17 Mar 2021 18:16:44 +0100 From: Christoph Hellwig To: "Matthew Wilcox (Oracle)" Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org Subject: Re: [PATCH v4 03/25] mm/vmstat: Add functions to account folio statistics Message-ID: References: <20210305041901.2396498-1-willy@infradead.org> <20210305041901.2396498-4-willy@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210305041901.2396498-4-willy@infradead.org> X-SRS-Rewrite: SMTP reverse-path rewritten from by casper.infradead.org. See http://www.infradead.org/rpr.html X-Stat-Signature: whrfwqbisd6cpiyfsi4jj9td4yquuxhg X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 1E7C82026174 Received-SPF: none (casper.srs.infradead.org>: No applicable sender policy available) receiver=imf01; identity=mailfrom; envelope-from=""; helo=casper.infradead.org; client-ip=90.155.50.34 X-HE-DKIM-Result: pass/pass X-HE-Tag: 1616001411-698716 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: > +static inline > +void __inc_zone_folio_stat(struct folio *folio, enum zone_stat_item item) This prototype style is weird and doesn't follow either of the preffered styles.. > static inline void __mod_zone_freepage_state(struct zone *zone, int nr_pages, > int migratetype) > { > @@ -536,6 +584,24 @@ static inline void __dec_lruvec_page_state(struct page *page, > __mod_lruvec_page_state(page, idx, -1); > } > > +static inline void __mod_lruvec_folio_stat(struct folio *folio, > + enum node_stat_item idx, int val) .. like the ones that exist and are added by you just below.