From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 38CE2C433DB for ; Wed, 17 Mar 2021 19:05:13 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 7175E64F53 for ; Wed, 17 Mar 2021 19:05:12 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7175E64F53 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 932BB6B006E; Wed, 17 Mar 2021 15:05:11 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8BB6F6B0070; Wed, 17 Mar 2021 15:05:11 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7831D6B0071; Wed, 17 Mar 2021 15:05:11 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0037.hostedemail.com [216.40.44.37]) by kanga.kvack.org (Postfix) with ESMTP id 5DA106B006E for ; Wed, 17 Mar 2021 15:05:11 -0400 (EDT) Received: from smtpin09.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 03CB13651 for ; Wed, 17 Mar 2021 19:05:11 +0000 (UTC) X-FDA: 77930294022.09.67CBF03 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf20.hostedemail.com (Postfix) with ESMTP id A69491CA81 for ; Wed, 17 Mar 2021 17:21:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=aZBesko0L2dLYUae48wU74XHUup8GCRSf+aPZedgtJk=; b=IZYkq1TdY42T5Bvl3xE61WR1SD GR/5U8EhQJTK9y20f3Nwg9B2QuYK7L0tcrs9PxoX4LcxNZz+fRJTIWLa4rcZsuUELYSDn259br6n+ CHJ1FKtSWoyS259HNed9Gb9n9UQ1oOiKl96pKmk7A7q9ra85oQp8KWSfwdaoo8DIHuytLYly70HOo 7FUxC/uxz/UIGb0EGvFEyZlrgDk08rZaQM0/D0b6s5uHIRxEeVuT4kV/tlNkpMC4VN+Owd94Etfqs kbtcWRqpe1kighYOS7UXtbnzh21ZW7EJKaX3ARH8sCJxYRtU0ys7WIIh5BuCa6Pj1tdSxY5/tQ9DD EPXDQkYQ==; Received: from [2001:4bb8:18c:bb3:e3eb:4a4b:ba2f:224b] (helo=localhost) by casper.infradead.org with esmtpsa (Exim 4.94 #2 (Red Hat Linux)) id 1lMZqT-001u9b-2R; Wed, 17 Mar 2021 17:20:46 +0000 Date: Wed, 17 Mar 2021 18:20:32 +0100 From: Christoph Hellwig To: "Matthew Wilcox (Oracle)" Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org Subject: Re: [PATCH v4 08/25] mm: Handle per-folio private data Message-ID: References: <20210305041901.2396498-1-willy@infradead.org> <20210305041901.2396498-9-willy@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210305041901.2396498-9-willy@infradead.org> X-SRS-Rewrite: SMTP reverse-path rewritten from by casper.infradead.org. See http://www.infradead.org/rpr.html X-Stat-Signature: 5r1uzexfufft75fx9xrm1fooer3jyb9t X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: A69491CA81 Received-SPF: none (casper.srs.infradead.org>: No applicable sender policy available) receiver=imf20; identity=mailfrom; envelope-from=""; helo=casper.infradead.org; client-ip=90.155.50.34 X-HE-DKIM-Result: pass/pass X-HE-Tag: 1616001664-610445 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: > +static inline void attach_page_private(struct page *page, void *data) > +{ > + attach_folio_private((struct folio *)page, data); > +} > + > +static inline void *detach_page_private(struct page *page) > +{ > + return detach_folio_private((struct folio *)page); > +} I hate these open code casts. Can't we have a single central page_to_folio helper, which could also grow a debug check (maybe under a new config option) to check that it really is called on a head page?