From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EFB59C433DB for ; Wed, 17 Mar 2021 18:00:34 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 87F2364F20 for ; Wed, 17 Mar 2021 18:00:34 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 87F2364F20 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id EFA066B006E; Wed, 17 Mar 2021 14:00:33 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E82F26B0070; Wed, 17 Mar 2021 14:00:33 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D25276B0071; Wed, 17 Mar 2021 14:00:33 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0183.hostedemail.com [216.40.44.183]) by kanga.kvack.org (Postfix) with ESMTP id B259F6B006E for ; Wed, 17 Mar 2021 14:00:33 -0400 (EDT) Received: from smtpin30.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 3B2F387EB for ; Wed, 17 Mar 2021 18:00:33 +0000 (UTC) X-FDA: 77930131146.30.C28607C Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf22.hostedemail.com (Postfix) with ESMTP id 31FC2C0679DC for ; Wed, 17 Mar 2021 17:26:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=NkSmKyFybGGzBQdftefvTyk7NOmR2MT0T3BIdH4UDpI=; b=eBVh1/xeK05SwdJk3+2gDrxqy8 XSOIv2sdLpv+73MDj4McoTRij3ie+opRU/PmaYdY1xhICqTjEcxFOD+M5BWIh4I9ja1M+HOatORJx uXBuhgp8pSXEJ66Ajq8nBcvZIiA92XLion+5AIdVVO3KA7iO6pm3FltJQzPu1Ew/aj8Dg6RvbMD2y 2YHxOIsCzcg5nJ0Di0t9g/J51pJSL0ZJUtVW50RIdYzSNWKDW20KKXGq7i6D8ZwLCKzyGNKRxqqEB 8qbhUNHIqUN4ynv+DusmpwZPdhU6PupJPSLh23GCp9lp4zOWHXMFIgc+eC3mRiSAlaBSiDfwwe1Ch kK4CMZPQ==; Received: from [2001:4bb8:18c:bb3:e3eb:4a4b:ba2f:224b] (helo=localhost) by casper.infradead.org with esmtpsa (Exim 4.94 #2 (Red Hat Linux)) id 1lMZvr-001uZ9-TX; Wed, 17 Mar 2021 17:26:10 +0000 Date: Wed, 17 Mar 2021 18:26:07 +0100 From: Christoph Hellwig To: "Matthew Wilcox (Oracle)" Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org Subject: Re: [PATCH v4 10/25] mm/util: Add folio_mapping and folio_file_mapping Message-ID: References: <20210305041901.2396498-1-willy@infradead.org> <20210305041901.2396498-11-willy@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210305041901.2396498-11-willy@infradead.org> X-SRS-Rewrite: SMTP reverse-path rewritten from by casper.infradead.org. See http://www.infradead.org/rpr.html X-Stat-Signature: omro3s1gg7ftcx1demi8ftz3a9w88mx6 X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 31FC2C0679DC Received-SPF: none (casper.srs.infradead.org>: No applicable sender policy available) receiver=imf22; identity=mailfrom; envelope-from=""; helo=casper.infradead.org; client-ip=90.155.50.34 X-HE-DKIM-Result: pass/pass X-HE-Tag: 1616001986-596431 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: > +struct address_space *page_mapping(struct page *); > +struct address_space *folio_mapping(struct folio *); > +struct address_space *__folio_file_mapping(struct folio *); > + > +static inline struct address_space *folio_file_mapping(struct folio *folio) > +{ > + if (unlikely(FolioSwapCache(folio))) > + return __folio_file_mapping(folio); I think __folio_file_mapping is badly misnamed as it only deals with swapcache folios. Maybe that should be reflected in the name? Also for all these funtions documentation would be very helpful, even if the existing struct page based helpers don't have that either.