From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0D76DC433E6 for ; Wed, 17 Mar 2021 18:16:07 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id B3C1564E89 for ; Wed, 17 Mar 2021 18:16:06 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B3C1564E89 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 412BE6B0070; Wed, 17 Mar 2021 14:16:06 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3C34F6B0071; Wed, 17 Mar 2021 14:16:06 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2196D6B0073; Wed, 17 Mar 2021 14:16:06 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 040B76B0070 for ; Wed, 17 Mar 2021 14:16:05 -0400 (EDT) Received: from smtpin11.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id C2E571E1E for ; Wed, 17 Mar 2021 18:16:05 +0000 (UTC) X-FDA: 77930170290.11.3070734 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf05.hostedemail.com (Postfix) with ESMTP id B3AA7E0D362C for ; Wed, 17 Mar 2021 17:47:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=rL7SFawsS6liUNgGQ9iTAJB8GXMy0bvzGxWlxqtV9bA=; b=kwWUW/scijZUk2gBe0/qYqS9Bp rhiaJ++M1Et/DCmh8LuhVHjj1Kb8Thfb83lSQ+LOLYlCsraR973yvNx445uTwKH4cU7CWo9Mcj5Qo ZCaQGP87mYLksgp6fNCN85TBefGtsgA99HN1NfB1X8H8S5CIaBeE3s+xgZveNbihitX640i5qQAyU JnOAgWjrmqpdDZiPDC0/HANRwWtSPix/Bavwm09jsXR0P1PTAhBk9yoPa/pzvEnHQGxiZCYUuuQ2+ vAfgp6tu+lhYACW+SaN5d14LfY/CLj/3rdiXLVOxDQsLwY6h4BsHghato2XPqr7/UitnBB9YHgKa1 CEVrLLkw==; Received: from 089144199244.atnat0008.highway.a1.net ([89.144.199.244] helo=localhost) by casper.infradead.org with esmtpsa (Exim 4.94 #2 (Red Hat Linux)) id 1lMaGc-001w1O-12; Wed, 17 Mar 2021 17:47:37 +0000 Date: Wed, 17 Mar 2021 18:45:22 +0100 From: Christoph Hellwig To: "Matthew Wilcox (Oracle)" Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org Subject: Re: [PATCH v4 25/25] cachefiles: Switch to wait_page_key Message-ID: References: <20210305041901.2396498-1-willy@infradead.org> <20210305041901.2396498-26-willy@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210305041901.2396498-26-willy@infradead.org> X-SRS-Rewrite: SMTP reverse-path rewritten from by casper.infradead.org. See http://www.infradead.org/rpr.html X-Stat-Signature: paznyq4wmzx8hwu1az1cseq16jwgf7un X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: B3AA7E0D362C Received-SPF: none (casper.srs.infradead.org>: No applicable sender policy available) receiver=imf05; identity=mailfrom; envelope-from=""; helo=casper.infradead.org; client-ip=90.155.50.34 X-HE-DKIM-Result: pass/pass X-HE-Tag: 1616003265-268410 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Mar 05, 2021 at 04:19:01AM +0000, Matthew Wilcox (Oracle) wrote: > Cachefiles was relying on wait_page_key and wait_bit_key being the > same layout, which is fragile. Now that wait_page_key is exposed in > the pagemap.h header, we can remove that fragility. Also switch it > to use the folio directly instead of the page. Yikes. That fix itself is something that should go into mainline ASAP as it fixes a massive landmine instead of mixing it up with the folio conversion.