From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 04157C433DB for ; Fri, 19 Mar 2021 15:03:30 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 83BED6188B for ; Fri, 19 Mar 2021 15:03:29 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 83BED6188B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 168DD6B0072; Fri, 19 Mar 2021 11:03:29 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 140966B0074; Fri, 19 Mar 2021 11:03:29 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id EFB896B0075; Fri, 19 Mar 2021 11:03:28 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0175.hostedemail.com [216.40.44.175]) by kanga.kvack.org (Postfix) with ESMTP id D53D26B0072 for ; Fri, 19 Mar 2021 11:03:28 -0400 (EDT) Received: from smtpin06.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 955B52C6D for ; Fri, 19 Mar 2021 15:03:28 +0000 (UTC) X-FDA: 77936942496.06.22F209C Received: from mail-pf1-f173.google.com (mail-pf1-f173.google.com [209.85.210.173]) by imf20.hostedemail.com (Postfix) with ESMTP id AA7863747 for ; Fri, 19 Mar 2021 15:03:26 +0000 (UTC) Received: by mail-pf1-f173.google.com with SMTP id y200so6084777pfb.5 for ; Fri, 19 Mar 2021 08:03:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=q7Roh7B5+FwQQexECP34LRGge0KD+9IdWHo1Er07uE0=; b=i3kH2vg4RsZbccsmkM2GFQkVr/zwjO7RemoQUXUoIr7wfFJm9ZZ3MLzkl8lytEX5YA 7OOIa9cJPIQhCIIxcbliLvLHLwAmw3G7BGAfj94cR1lJpYo7pifIdMwttDgfK0M+oZs9 YMWXgd1sg32vMCiGf0MsnxAerHRh/EwFeNJ4Y= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=q7Roh7B5+FwQQexECP34LRGge0KD+9IdWHo1Er07uE0=; b=rL1cnT7UMmsnCvIERUrZwAiVYwjXXhzwDU922v+FYpnzp1cpIBgXwZkImFin279x1L gV7RCI9sVXLgonG1Ahn9Tqkn45x0kY3HspneY5TC4UD2o1rsGPIjcTem14p56262r10M UItl+NVRvhzfkgpyfgIRBjse/FHhMSLUJOhUiSY7XGdPiWnO2CEJDb4IVW2B+AQfhd9w wfAwRJ8DGSyEc/hN41g3TA5gET06LEIDDx+KXXA8OlVYBzqFS8wNuD5SccQGS0xPielN qoHochaQ3QZNK5eLMrmQZtLrpJCyah979gXfu0cQdre4jTjt0oW3Gz0LTVOXnriGN0qP qT4g== X-Gm-Message-State: AOAM531ygRmOKJYFZTlcimu9vKA5ljZkQ1Sndsuzz6P/BWvAxBxEQjUH bC2xgT3plp0XfLE3l3nKo5yL2g== X-Google-Smtp-Source: ABdhPJzDhitGQobwUHAwMl2GkNZZr/BwlBh+dQLC1RA9lQikmH7lAUCxagM8szjGT0olxg3tJFH5OQ== X-Received: by 2002:a65:41c6:: with SMTP id b6mr11563567pgq.7.1616166200586; Fri, 19 Mar 2021 08:03:20 -0700 (PDT) Received: from google.com ([2409:10:2e40:5100:6577:f83d:5865:dfac]) by smtp.gmail.com with ESMTPSA id y15sm6607609pgi.31.2021.03.19.08.03.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 19 Mar 2021 08:03:19 -0700 (PDT) Date: Sat, 20 Mar 2021 00:03:11 +0900 From: Sergey Senozhatsky To: Yafang Shao Cc: pmladek@suse.com, willy@infradead.org, andriy.shevchenko@linux.intel.com, david@redhat.com, linmiaohe@huawei.com, vbabka@suse.cz, cl@linux.com, penberg@kernel.org, rientjes@google.com, iamjoonsoo.kim@lge.com, akpm@linux-foundation.org, rostedt@goodmis.org, sergey.senozhatsky@gmail.com, joe@perches.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, lkp@intel.com Subject: Re: [PATCH v6 resend 0/3] mm, vsprintf: dump full information of page flags in pGp Message-ID: References: <20210319101246.73513-1-laoar.shao@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210319101246.73513-1-laoar.shao@gmail.com> X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: AA7863747 X-Stat-Signature: cy7dqbmpxttt9ste5wfetynkyy3ubmcp Received-SPF: none (chromium.org>: No applicable sender policy available) receiver=imf20; identity=mailfrom; envelope-from=""; helo=mail-pf1-f173.google.com; client-ip=209.85.210.173 X-HE-DKIM-Result: pass/pass X-HE-Tag: 1616166206-670383 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On (21/03/19 18:12), Yafang Shao wrote: > > The existed pGp shows the names of page flags only, rather than the full > information including section, node, zone, last cpuipid and kasan tag. > While it is not easy to parse these information manually because there > are so many flavors. We'd better interpret them in printf. > > To be compitable with the existed format of pGp, the new introduced ones > also use '|' as the separator, then the user tools parsing pGp won't > need to make change, suggested by Matthew. The new added information is > tracked onto the end of the existed one, e.g. > [ 8838.835456] Slab 0x000000002828b78a objects=33 used=3 fp=0x00000000d04efc88 flags=0x17ffffc0010200(slab|head|node=0|zone=2|lastcpupid=0x1fffff) > > The documentation and test cases are also updated. The result of the > test cases as follows, > [68599.816764] test_printf: loaded. > [68599.819068] test_printf: all 388 tests passed > [68599.830367] test_printf: unloaded. > > This patchset also includes some code cleanup in mm/slub.c. The series looks good to me. FWIW, Reviewed-by: Sergey Senozhatsky