From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 304EBC433C1 for ; Fri, 19 Mar 2021 19:44:30 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id A0A3961970 for ; Fri, 19 Mar 2021 19:44:29 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A0A3961970 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 204976B006E; Fri, 19 Mar 2021 15:44:29 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1B4446B0070; Fri, 19 Mar 2021 15:44:29 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 055E46B0071; Fri, 19 Mar 2021 15:44:29 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0094.hostedemail.com [216.40.44.94]) by kanga.kvack.org (Postfix) with ESMTP id DE6B36B006E for ; Fri, 19 Mar 2021 15:44:28 -0400 (EDT) Received: from smtpin39.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 9F67C181DF779 for ; Fri, 19 Mar 2021 19:44:28 +0000 (UTC) X-FDA: 77937650616.39.0AE285A Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124]) by imf24.hostedemail.com (Postfix) with ESMTP id 7ECF3A000285 for ; Fri, 19 Mar 2021 19:44:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1616183045; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=wBnwTw32U7/edAaMKPgosrHQ6qnsQ7c3qzlNBdLRLwE=; b=U6I4+SkoKNiVZRyWxoNL3udzyAT9vd+RiUCOhwljUW1zajkHUdos++7azgFWyzRk9zoUKE MxpKQBf7Xz8Vqwcj7qZFeg3bddmnSdZC95TwrZBbwYgCn0WYgvu1DXj1gvqIKabC1wn03U CZQASiSxHPONVSVcBJoi+GqWsIeDano= Received: from mail-qv1-f70.google.com (mail-qv1-f70.google.com [209.85.219.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-552-zIW_Q1K_PveOXjqBG12UIg-1; Fri, 19 Mar 2021 15:44:02 -0400 X-MC-Unique: zIW_Q1K_PveOXjqBG12UIg-1 Received: by mail-qv1-f70.google.com with SMTP id h12so32762100qvm.9 for ; Fri, 19 Mar 2021 12:44:02 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=wBnwTw32U7/edAaMKPgosrHQ6qnsQ7c3qzlNBdLRLwE=; b=VLZKgnL7Zq5gJiAgOT1CQ2Nl7gpooKbUEw7j0Ub4aCxoSK+ioArVups+kIXWgZ8wx5 fwSARRkVW/RECx/hGgGk4mxbLAiN1OXc9up6pjSALQ/WKi9/x1wRlhsJqmD+M31WFOhS F57XSMmReye2YXAxz5dNR3hgUsdxDjXLkKilEf8DywcW1BW/+jmamnO2ds0lg6OQuzvB pnpCXEbhbstPGeqAZ2NCNWpE5eC+FVSXY5u4M/HeVGquGvb2ZNrVO6CN60ECb2w+gopE 2dkpgPE1Kb6rscRAi1PcKL+NANIPypY95AdQNbVOOhgBhTwc1X6FvqR+9CMQv1TZHjzL yvKA== X-Gm-Message-State: AOAM532+sOCRZF1MXrkCDLtR3P3DqkTYYJKvohf0nA0eJeU/2Gq3VF24 JdQEQ9wicBXYNK+NQtYMCgv4k5liY1nzDyR5IIsdkp6OoJAOl1dhmb8Z37HsI8Ss3QHIm3gM6jn 2d+a1SsNuJER5/H9iL2W5JCu0Iscsy/jc1S9Rz1wxyI/sjconWNKdGbfaB+XU X-Received: by 2002:a37:9c4a:: with SMTP id f71mr270434qke.74.1616183041937; Fri, 19 Mar 2021 12:44:01 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwYhpW4rwSqJREyAf9He7tsOoXjxb24BlxLJOXnfqZ+924cmVi+BZtNMt4qvCP7Y8VJUO688Q== X-Received: by 2002:a37:9c4a:: with SMTP id f71mr270421qke.74.1616183041619; Fri, 19 Mar 2021 12:44:01 -0700 (PDT) Received: from optiplex-lnx (c-98-229-205-110.hsd1.nh.comcast.net. [98.229.205.110]) by smtp.gmail.com with ESMTPSA id f27sm5083183qkh.118.2021.03.19.12.44.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 19 Mar 2021 12:44:01 -0700 (PDT) Date: Fri, 19 Mar 2021 15:43:58 -0400 From: Rafael Aquini To: linux-mm@kvack.org Cc: linux-kernel@vger.kernel.org Subject: Re: [PATCH] mm/slab_common: provide "slab_merge" option for !IS_ENABLED(CONFIG_SLAB_MERGE_DEFAULT) builds Message-ID: References: <20210319192233.199099-1-aquini@redhat.com> MIME-Version: 1.0 In-Reply-To: <20210319192233.199099-1-aquini@redhat.com> Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=aquini@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Stat-Signature: o75hf3axah1gu8gb1ns67bijhwx49xgq X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 7ECF3A000285 Received-SPF: none (redhat.com>: No applicable sender policy available) receiver=imf24; identity=mailfrom; envelope-from=""; helo=us-smtp-delivery-124.mimecast.com; client-ip=63.128.21.124 X-HE-DKIM-Result: pass/pass X-HE-Tag: 1616183051-454474 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Mar 19, 2021 at 03:22:33PM -0400, Rafael Aquini wrote: > This is a minor addition to the allocator setup options to provide > a simple way to on demand enable back cache merging for builds > that by default run with CONFIG_SLAB_MERGE_DEFAULT not set. > > Signed-off-by: Rafael Aquini > --- > Documentation/admin-guide/kernel-parameters.txt | 7 +++++++ > mm/slab_common.c | 8 ++++++++ > 2 files changed, 15 insertions(+) > > diff --git a/Documentation/admin-guide/kernel-parameters.txt b/Documentation/admin-guide/kernel-parameters.txt > index 04545725f187..06519eecbfec 100644 > --- a/Documentation/admin-guide/kernel-parameters.txt > +++ b/Documentation/admin-guide/kernel-parameters.txt > @@ -4877,6 +4877,10 @@ > > slram= [HW,MTD] > > + slab_merge [MM] > + Enable merging of slabs with similar size when the > + kernel is built without CONFIG_SLAB_MERGE_DEFAULT. > + > slab_nomerge [MM] > Disable merging of slabs with similar size. May be > necessary if there is some reason to distinguish > @@ -4924,6 +4928,9 @@ > lower than slub_max_order. > For more information see Documentation/vm/slub.rst. > > + slub_merge [MM, SLUB] > + Same with slab_merge. > + > slub_nomerge [MM, SLUB] > Same with slab_nomerge. This is supported for legacy. > See slab_nomerge for more information. > diff --git a/mm/slab_common.c b/mm/slab_common.c > index 88e833986332..30db72269036 100644 > --- a/mm/slab_common.c > +++ b/mm/slab_common.c > @@ -71,11 +71,19 @@ static int __init setup_slab_nomerge(char *str) > return 1; > } > > +static int __init setup_slab_merge(char *str) > +{ > + slab_nomerge = false; > + return 1; > +} > + > #ifdef CONFIG_SLUB > __setup_param("slub_nomerge", slub_nomerge, setup_slab_nomerge, 0); > +__setup_param("slub_merge", slub_merge, setup_slab_merge, 0); > #endif > > __setup("slab_nomerge", setup_slab_nomerge); > +__setup("slab_merge", setup_slab_nomerge); DOH! I missed the typo here ^^ Sorry.