From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 45B95C433DB for ; Sat, 20 Mar 2021 14:11:24 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id A4ED86196D for ; Sat, 20 Mar 2021 14:11:23 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A4ED86196D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id C45646B0093; Sat, 20 Mar 2021 10:11:22 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id BCE2F6B0095; Sat, 20 Mar 2021 10:11:22 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A6FB26B0096; Sat, 20 Mar 2021 10:11:22 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0069.hostedemail.com [216.40.44.69]) by kanga.kvack.org (Postfix) with ESMTP id 87A8D6B0093 for ; Sat, 20 Mar 2021 10:11:22 -0400 (EDT) Received: from smtpin27.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 4206818211CDF for ; Sat, 20 Mar 2021 14:11:22 +0000 (UTC) X-FDA: 77940440004.27.561D2B8 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124]) by imf16.hostedemail.com (Postfix) with ESMTP id 9851980192E4 for ; Sat, 20 Mar 2021 14:11:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1616249480; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=R7j9C2SBGy1O/TXA3ex+LyIY8wv3F76xhWiBT6oqZo8=; b=XdEIR4OYfaM6rydfJBKNSmEXMNEP6KBV9RL6qenIPaVzVAcZcYvIPNTIEKApNQybNdYWs5 tGy1LXI7ncmiGAGvcca2Ivhes4lYsscvOjsnSxtstAovDS72ZJ0Y9Lc2Z1t70VHPprf54w RZ/fGWYX/dVwiZMzgTndgAKN8pjLQ6A= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-338-fuedKYqCPCaSZVlEKe8ITg-1; Sat, 20 Mar 2021 10:11:16 -0400 X-MC-Unique: fuedKYqCPCaSZVlEKe8ITg-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 35EBF87A83A; Sat, 20 Mar 2021 14:11:15 +0000 (UTC) Received: from x1-fbsd (unknown [10.3.128.5]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 98EE960CCD; Sat, 20 Mar 2021 14:11:13 +0000 (UTC) Date: Sat, 20 Mar 2021 10:11:10 -0400 From: Rafael Aquini To: Miaohe Lin Cc: akpm@linux-foundation.org, jglisse@redhat.com, shy828301@gmail.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH 1/5] mm/migrate.c: remove unnecessary VM_BUG_ON_PAGE on putback_movable_page() Message-ID: References: <20210320093701.12829-1-linmiaohe@huawei.com> <20210320093701.12829-2-linmiaohe@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210320093701.12829-2-linmiaohe@huawei.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-Stat-Signature: y8q1gt74yad8ng3wspdh7drboxopmdb5 X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 9851980192E4 Received-SPF: none (redhat.com>: No applicable sender policy available) receiver=imf16; identity=mailfrom; envelope-from=""; helo=us-smtp-delivery-124.mimecast.com; client-ip=63.128.21.124 X-HE-DKIM-Result: pass/pass X-HE-Tag: 1616249481-980502 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sat, Mar 20, 2021 at 05:36:57AM -0400, Miaohe Lin wrote: > The !PageLocked() check is implicitly done in PageMovable(). Remove this > explicit one. > I'd just keep the explicit assertion in place, regardless. But if you're going to stick with this patch, please fix it because it's removing the wrong assertion. > Signed-off-by: Miaohe Lin > --- > mm/migrate.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/mm/migrate.c b/mm/migrate.c > index 47df0df8f21a..e4ca5ef508ea 100644 > --- a/mm/migrate.c > +++ b/mm/migrate.c > @@ -146,7 +146,6 @@ void putback_movable_page(struct page *page) > struct address_space *mapping; > > VM_BUG_ON_PAGE(!PageLocked(page), page); > - VM_BUG_ON_PAGE(!PageMovable(page), page); > VM_BUG_ON_PAGE(!PageIsolated(page), page); > > mapping = page_mapping(page); > -- > 2.19.1 > >