From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5FDB7C433DB for ; Sat, 20 Mar 2021 17:20:15 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id E95036192D for ; Sat, 20 Mar 2021 17:20:14 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E95036192D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 59FD36B006E; Sat, 20 Mar 2021 13:20:14 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 550726B0078; Sat, 20 Mar 2021 13:20:14 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3F3086B007B; Sat, 20 Mar 2021 13:20:14 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0223.hostedemail.com [216.40.44.223]) by kanga.kvack.org (Postfix) with ESMTP id 223096B006E for ; Sat, 20 Mar 2021 13:20:14 -0400 (EDT) Received: from smtpin21.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id DA8902C12 for ; Sat, 20 Mar 2021 17:20:13 +0000 (UTC) X-FDA: 77940915906.21.FE40238 Received: from mail-pg1-f174.google.com (mail-pg1-f174.google.com [209.85.215.174]) by imf10.hostedemail.com (Postfix) with ESMTP id 76CEF4080F40 for ; Sat, 20 Mar 2021 17:20:13 +0000 (UTC) Received: by mail-pg1-f174.google.com with SMTP id m3so5826353pga.1 for ; Sat, 20 Mar 2021 10:20:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=Pn3EpVCjCb+QJM6LLjzL2zV3hlQHkLh8MmLlzXPa6ew=; b=mjElOV/tUoZZfqlxr5PYrlUHtBGYtmEFe3uTjgOEey8Lh6EDt3FV/hnm/l2v9znfl/ zN331omIg4XDf8rqu0WDCZ4nwuZS1AFGGTLschgJji3EXekslsB+ZE8AYABAJBILSFAc U8zJxgHEI0GmJKzxWI4PjnaMAZCBShAvkasY39yG/FKTWzzwwIsvUFb79RKpe08YnbZc QapQnBQWV73f3RWsYy73bqmEMMFAh0EjUSo334ii9eU4q1qItRykw1Tf5qHidGZdabh2 jFg2dr/dY2bFZXmGNW0lHu8lYZG2NTMOA1XgjMeph+FEejppx8cFn7K+9xHgOocU9PNT TU0A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition:in-reply-to; bh=Pn3EpVCjCb+QJM6LLjzL2zV3hlQHkLh8MmLlzXPa6ew=; b=p3b8fKcPuL7iQo9fOUkLeR8rEBpRUWcnSS7Zm9fmP3T9P5RO3t0x7QE4kOOvtVl78L aSr5DXGsBcVrcpSWU+bsy2057xU/9/sn7HjG2asBmPT3JrQ4gB1a5CM363zrsh6Jx0sp tJTLaV8f8OA7C3rdeIZHWETL0ljDk+NvQv2f8So4CPcK453yJgfZzGFwo8rpSb6nVb+M LaoUO/9Si9a/BUA3hh+Q8luKGaYcE2oam9pNHCdaLd8vDEUFPP9y44Qbs9eRtv/WDYRc Bemvo7abH+rI6IN1JgF8KhzfaFrjAOZEZ04nzWsJnAV2YCJKOWAHVByv9stVh8B6a+N4 3/lQ== X-Gm-Message-State: AOAM533gmI/EUC6mfYEQRAGnEz7AHG8n9ugBR12S/b6+RLqILRjSfYvH 2FhklyT7t59VNigi2nL5ojs= X-Google-Smtp-Source: ABdhPJyUUWqoUJc47c0gBiHuNFkAur1+tX3M47krLs4Zje9ipb18DmxknFlh0flPhAISUtcMF3Q3EQ== X-Received: by 2002:aa7:9521:0:b029:1f1:b27f:1a43 with SMTP id c1-20020aa795210000b02901f1b27f1a43mr14596473pfp.4.1616260812393; Sat, 20 Mar 2021 10:20:12 -0700 (PDT) Received: from google.com ([2620:15c:211:201:2033:9813:e1ed:7060]) by smtp.gmail.com with ESMTPSA id cv3sm9238575pjb.9.2021.03.20.10.20.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 20 Mar 2021 10:20:11 -0700 (PDT) Date: Sat, 20 Mar 2021 10:20:09 -0700 From: Minchan Kim To: Andrew Morton Cc: linux-mm , LKML , joaodias@google.com, surenb@google.com, cgoldswo@codeaurora.org, willy@infradead.org, mhocko@suse.com, david@redhat.com, vbabka@suse.cz, linux-fsdevel@vger.kernel.org, oliver.sang@intel.com Subject: Re: [PATCH v4 3/3] mm: fs: Invalidate BH LRU during page migration Message-ID: References: <20210319175127.886124-1-minchan@kernel.org> <20210319175127.886124-3-minchan@kernel.org> <20210320093249.2df740cd139449312211c452@linux-foundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210320093249.2df740cd139449312211c452@linux-foundation.org> X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: 76CEF4080F40 X-Stat-Signature: 7owjswnfzo9dzxu335pkt45spy453xfw Received-SPF: none (gmail.com>: No applicable sender policy available) receiver=imf10; identity=mailfrom; envelope-from=""; helo=mail-pg1-f174.google.com; client-ip=209.85.215.174 X-HE-DKIM-Result: pass/pass X-HE-Tag: 1616260813-610434 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sat, Mar 20, 2021 at 09:32:49AM -0700, Andrew Morton wrote: > On Fri, 19 Mar 2021 10:51:27 -0700 Minchan Kim wrote: > > > Pages containing buffer_heads that are in one of the per-CPU > > buffer_head LRU caches will be pinned and thus cannot be migrated. > > This can prevent CMA allocations from succeeding, which are often used > > on platforms with co-processors (such as a DSP) that can only use > > physically contiguous memory. It can also prevent memory > > hot-unplugging from succeeding, which involves migrating at least > > MIN_MEMORY_BLOCK_SIZE bytes of memory, which ranges from 8 MiB to 1 > > GiB based on the architecture in use. > > > > Correspondingly, invalidate the BH LRU caches before a migration > > starts and stop any buffer_head from being cached in the LRU caches, > > until migration has finished. > > > > Tested-by: Oliver Sang > > Reported-by: kernel test robot > > Signed-off-by: Chris Goldsworthy > > Signed-off-by: Minchan Kim > > The signoff chain ordering might mean that Chris was the primary author, but > there is no From:him. Please clarify? He tried first version but was diffrent implementation since I changed a lot. That's why I added his SoB even though current implementaion is much different. So, maybe I am primary author?