From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9367DC433C1 for ; Mon, 22 Mar 2021 14:34:40 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id D73266187E for ; Mon, 22 Mar 2021 14:34:39 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D73266187E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=cmpxchg.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id ABDB96B00D6; Mon, 22 Mar 2021 10:15:48 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A94F86B00D8; Mon, 22 Mar 2021 10:15:48 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 938496B00D9; Mon, 22 Mar 2021 10:15:48 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0064.hostedemail.com [216.40.44.64]) by kanga.kvack.org (Postfix) with ESMTP id 77E466B00D6 for ; Mon, 22 Mar 2021 10:15:48 -0400 (EDT) Received: from smtpin27.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id DC2C212DF for ; Mon, 22 Mar 2021 14:34:38 +0000 (UTC) X-FDA: 77947756236.27.591F32E Received: from mail-qt1-f181.google.com (mail-qt1-f181.google.com [209.85.160.181]) by imf28.hostedemail.com (Postfix) with ESMTP id 6A7BD2000393 for ; Mon, 22 Mar 2021 14:34:29 +0000 (UTC) Received: by mail-qt1-f181.google.com with SMTP id l13so12417981qtu.9 for ; Mon, 22 Mar 2021 07:34:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cmpxchg-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=dgiA9EKcb76B1bqLH03HrKnpAcqLt9hekpmCfkhncBM=; b=EBPrZQ6PQF33CulUgZLclPe1IXGwkWh3ADuOa9EgjQgFIahJ9GlGNh7SlhkI+elRmq dzfK9alFsD7t1YCwWcYOlrPF8Mj/R09IiyZarhTK1NzPUNChZFiSklUMPysQ661DMZuH 5ksYkQqXg46X80Loj9iWMmubDjA2yp612HvTkBShMzpIKcOTuVdS1joaTBBl/T+z+GHs v8O59o4DeBrBGOp8Lvrf0LVXhSIXsLGp4tL3mM1QzzniiTAG6uxkqW/MWUBEnl7rQCfQ VtkMoXcnt0euUHkDR4XRCa8Ttdryk+f2bFr+BimSIcoP/mxPX7AQsEmmAkGUVEv4sH22 nFHg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=dgiA9EKcb76B1bqLH03HrKnpAcqLt9hekpmCfkhncBM=; b=b7mHk6KNkRpCueV0BakbX3yqBZuxlTElhHTvKQ1QyJQhAKX+SZINRkzK2WnFsKDnQt JY6JA0/XfamkoUGX2sLj3Sjlp4aXZ2ZNLUYnRgP5YBYf0stxIZ8Pd0DGRFDo1K7jjY4S C+T5g1v1kp7pCQW3mLfA9by/+SBbWvsr7c4qYKko/3GBvrrl5+cxB208sGQVc8rjXEa1 5iNK6sDjlZDmAHEeYwcJ1bq0hefX//kOedNw0oAVdogbPv4ynJKX/tKDbvFOk4p6ByX2 enD3e4aiMo3D1ydIm6gM6deiTDTstnUH/VcdClcFdZFuWSPn1HL0be3CS29w6pQwg9DI wGTQ== X-Gm-Message-State: AOAM5315a7FA1DRtixgMbP7IXc2W4T2aRskE0Ox9c6b2UGRbZroHCGag 9ogMF8YC1GlS8zp8PciAmUAuAg== X-Google-Smtp-Source: ABdhPJx+Ya3oBgg5/bfd+IQ2NmX25h21HO5+95dpSWRQU5r2IvHK7POVRsnH3kNoOejTbhWlH4uc/g== X-Received: by 2002:ac8:5ad5:: with SMTP id d21mr187641qtd.198.1616423662401; Mon, 22 Mar 2021 07:34:22 -0700 (PDT) Received: from localhost ([2620:10d:c091:480::1:b54e]) by smtp.gmail.com with ESMTPSA id d2sm10921327qkk.42.2021.03.22.07.34.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 22 Mar 2021 07:34:21 -0700 (PDT) Date: Mon, 22 Mar 2021 10:34:18 -0400 From: Johannes Weiner To: Muchun Song Cc: guro@fb.com, mhocko@kernel.org, akpm@linux-foundation.org, shakeelb@google.com, vdavydov.dev@gmail.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, duanxiongchun@bytedance.com Subject: Re: [PATCH v5 6/7] mm: memcontrol: inline __memcg_kmem_{un}charge() into obj_cgroup_{un}charge_pages() Message-ID: References: <20210319163821.20704-1-songmuchun@bytedance.com> <20210319163821.20704-7-songmuchun@bytedance.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210319163821.20704-7-songmuchun@bytedance.com> X-Stat-Signature: b8qm36ud4n7qtfo6wnthinug4rer91k6 X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 6A7BD2000393 Received-SPF: none (cmpxchg.org>: No applicable sender policy available) receiver=imf28; identity=mailfrom; envelope-from=""; helo=mail-qt1-f181.google.com; client-ip=209.85.160.181 X-HE-DKIM-Result: pass/pass X-HE-Tag: 1616423669-8999 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sat, Mar 20, 2021 at 12:38:19AM +0800, Muchun Song wrote: > There is only one user of __memcg_kmem_charge(), so manually inline > __memcg_kmem_charge() to obj_cgroup_charge_pages(). Similarly manually > inline __memcg_kmem_uncharge() into obj_cgroup_uncharge_pages() and > call obj_cgroup_uncharge_pages() in obj_cgroup_release(). > > This is just code cleanup without any functionality changes. > > Signed-off-by: Muchun Song Acked-by: Johannes Weiner