From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9DE1EC433C1 for ; Wed, 24 Mar 2021 12:10:50 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 201D061A02 for ; Wed, 24 Mar 2021 12:10:50 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 201D061A02 Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=suse.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 8EA836B02B9; Wed, 24 Mar 2021 08:10:49 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8872E6B02BB; Wed, 24 Mar 2021 08:10:49 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 729476B02BC; Wed, 24 Mar 2021 08:10:49 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0008.hostedemail.com [216.40.44.8]) by kanga.kvack.org (Postfix) with ESMTP id 5719E6B02B9 for ; Wed, 24 Mar 2021 08:10:49 -0400 (EDT) Received: from smtpin18.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 085B198B3 for ; Wed, 24 Mar 2021 12:10:49 +0000 (UTC) X-FDA: 77954651418.18.64D8BF3 Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) by imf23.hostedemail.com (Postfix) with ESMTP id EA2C8A000390 for ; Wed, 24 Mar 2021 12:10:47 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1616587847; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=96jnjjSpy2xKmrQMmEaN6LFhnUlQSEZSPONAt/EFWgw=; b=ns9q73a97BurP81xsKfxjdKABrCj8znlqRYT9wIZqjMLMG/DekrS27vAxHb349LImoer0o VgwEfzRDgn0FlrVBvZUTIVQ4TbHS+nWP2OD7MbvCkAPnfZLr2nha2aIgtpKEzVNFzie3Ps 8jAenGL+5D5BBR9qW9Xjkadd35HCkIE= Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 4DECEAD38; Wed, 24 Mar 2021 12:10:47 +0000 (UTC) Date: Wed, 24 Mar 2021 13:10:46 +0100 From: Michal Hocko To: Oscar Salvador Cc: Andrew Morton , David Hildenbrand , Anshuman Khandual , Vlastimil Babka , Pavel Tatashin , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v5 1/5] mm,memory_hotplug: Allocate memmap from the added memory range Message-ID: References: <20210319092635.6214-1-osalvador@suse.de> <20210319092635.6214-2-osalvador@suse.de> <20210324101259.GB16560@linux> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Stat-Signature: shodkhuztj5nee74mmd6xn5asep84tsn X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: EA2C8A000390 Received-SPF: none (suse.com>: No applicable sender policy available) receiver=imf23; identity=mailfrom; envelope-from=""; helo=mx2.suse.de; client-ip=195.135.220.15 X-HE-DKIM-Result: pass/pass X-HE-Tag: 1616587847-934482 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed 24-03-21 13:03:29, Michal Hocko wrote: > On Wed 24-03-21 11:12:59, Oscar Salvador wrote: [...] an additional remark > > - online_pages()->move_pfn_range_to_zone(): Accounts for node/zone's spanned pages > > - online_pages()->zone->present_pages += nr_pages; I am pretty sure you shouldn't account vmmemmap pages to the target zone in some cases - e.g. vmemmap cannot be part of the movable zone, can it? So this would be yet another special casing. This patch has got it wrong unless I have missed some special casing. -- Michal Hocko SUSE Labs