From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2258AC433C1 for ; Wed, 24 Mar 2021 15:12:57 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id B8E6C619B8 for ; Wed, 24 Mar 2021 15:12:56 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B8E6C619B8 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 487EA6B02D3; Wed, 24 Mar 2021 11:12:56 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 438256B02D5; Wed, 24 Mar 2021 11:12:56 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2B25C6B02D7; Wed, 24 Mar 2021 11:12:56 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0154.hostedemail.com [216.40.44.154]) by kanga.kvack.org (Postfix) with ESMTP id 0FC2A6B02D3 for ; Wed, 24 Mar 2021 11:12:56 -0400 (EDT) Received: from smtpin24.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id CD3313644 for ; Wed, 24 Mar 2021 15:12:55 +0000 (UTC) X-FDA: 77955110310.24.E2F0280 Received: from mail-pj1-f45.google.com (unknown [209.85.216.45]) by imf01.hostedemail.com (Postfix) with ESMTP id 547625001532 for ; Wed, 24 Mar 2021 15:12:42 +0000 (UTC) Received: by mail-pj1-f45.google.com with SMTP id ha17so11921084pjb.2 for ; Wed, 24 Mar 2021 08:12:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=L8CGCu683ap3F7hcKSeSmXZu53NqyU2bsVETlec1vPY=; b=Bgi5a04hjuwBhd4sezqjdOw3l2MpVDQReCtu5al6yx/kbKVgtebwvuacrAtD4t8S5O Vg0DTfLNHUaHbursO58xzcS5gU2KXddaOVEBBO81pXIqShe7JseJX13Tkv2PQLnPtsQN h13OHoYpINkNIt8LnZNh7GIrWvt+L5u6zLW2wawponkCOATN78ABAQxoiXGj8WCt6HPf YHovZbRswV7FOlM2he0HfycUXMHfntbT1DBWlIStq9oYVJZDNbQLcPmTRaT+LUfTzUL3 fgyOIwfgfq+383iAD/kt5rM2tCGab4b7oAtX9Hjt9SWHKCIH/zeAPn8lO2UQxq0M8kvt dzEg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition :content-transfer-encoding:in-reply-to; bh=L8CGCu683ap3F7hcKSeSmXZu53NqyU2bsVETlec1vPY=; b=ohuQZGRMfzTZyLRrXYGulifyMV/BKG2nRbdjDucchcTEz1UfT8ID7nc+cLlyBYyTVy HUOgJEzEUq0D3FP/QOhAsmrPrvovoGKmgmurbSsPyQlq8A3F2mJgS1N++o+EHK/PQ9dz +dXhuQBChOADxmw1H3hSotAuKCWlSP6v2ddhKhAbXY5vWvdvVG/7QIN5xXLVFxYWu9Dv CuJKN2NKbsLAk0bg5qefo/dd6T9hfqjfUpQV6CUpwRcMz17QH087gTOgaQgBPULJreBQ HUXoVULSa93Sg/qaCNRhOZVvfhwVyvWMqrJLJDMe/ln12FgM5GgyLZ3gPO/d6lKb01SC YpjQ== X-Gm-Message-State: AOAM532X1eZTZTfa3+o0XJt11nwS6YVfnF5S6CaR12WPpYVGNKJSZ9IP FZXP6F2J69AtFGyOr7/pub8= X-Google-Smtp-Source: ABdhPJx312Y2XyaQfPeo2zH0Y0TfpcUXUXSQiWQo93nuhBKMIpgS0MlEIA0GtuVDqQ/hZcQpKUdVrg== X-Received: by 2002:a17:903:4112:b029:e5:f79d:3eb1 with SMTP id r18-20020a1709034112b02900e5f79d3eb1mr4170507pld.48.1616598752488; Wed, 24 Mar 2021 08:12:32 -0700 (PDT) Received: from google.com ([2620:15c:211:201:7dfa:1e53:536:7976]) by smtp.gmail.com with ESMTPSA id y20sm2985105pfo.210.2021.03.24.08.12.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 24 Mar 2021 08:12:31 -0700 (PDT) Date: Wed, 24 Mar 2021 08:12:29 -0700 From: Minchan Kim To: Dmitry Osipenko Cc: Andrew Morton , linux-mm , LKML , gregkh@linuxfoundation.org, surenb@google.com, joaodias@google.com, jhubbard@nvidia.com, willy@infradead.org Subject: Re: [PATCH v6] mm: cma: support sysfs Message-ID: References: <20210324010547.4134370-1-minchan@kernel.org> <3d90177b-e143-03b9-0f78-77740690266f@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <3d90177b-e143-03b9-0f78-77740690266f@gmail.com> X-Stat-Signature: jb664pq1xah3g8wn7znup471djam1up8 X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 547625001532 Received-SPF: none (gmail.com>: No applicable sender policy available) receiver=imf01; identity=mailfrom; envelope-from=""; helo=mail-pj1-f45.google.com; client-ip=209.85.216.45 X-HE-DKIM-Result: pass/pass X-HE-Tag: 1616598762-626018 Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Mar 24, 2021 at 03:33:07PM +0300, Dmitry Osipenko wrote: > 24.03.2021 04:05, Minchan Kim =D0=BF=D0=B8=D1=88=D0=B5=D1=82: > > +static struct kobject *cma_kobj_root; >=20 > This should be a local variable. Sure. >=20 > > +static struct kobj_type cma_ktype =3D { > > + .release =3D cma_kobj_release, > > + .sysfs_ops =3D &kobj_sysfs_ops, > > + .default_groups =3D cma_groups >=20 > I'd add a comma to the end, for consistency. Yub.