From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 22422C433DB for ; Thu, 25 Mar 2021 10:24:35 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 8FB79619FE for ; Thu, 25 Mar 2021 10:24:34 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8FB79619FE Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=suse.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 0D96F6B0074; Thu, 25 Mar 2021 06:24:34 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 088B06B0075; Thu, 25 Mar 2021 06:24:34 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E48466B0078; Thu, 25 Mar 2021 06:24:33 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0093.hostedemail.com [216.40.44.93]) by kanga.kvack.org (Postfix) with ESMTP id C9F4E6B0074 for ; Thu, 25 Mar 2021 06:24:33 -0400 (EDT) Received: from smtpin33.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 84BF91841FC94 for ; Thu, 25 Mar 2021 10:24:33 +0000 (UTC) X-FDA: 77958012426.33.9BF1677 Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) by imf26.hostedemail.com (Postfix) with ESMTP id 93BBB4080F65 for ; Thu, 25 Mar 2021 10:24:31 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1616667871; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=MY7sSmU90y5JQm0YzMx7OMqCkCu0pemuSB7/AZ6UPuk=; b=etQd2/pC+ndUlJPJsiLN9+jhei3Tq6e+9OLuoPH5S/zeB/Krh0/FCLmJ8xpx7l875ZD8/G KdQuppFRhlzu3GSrcqtII78AHv4OgGZsVDjqsV5CL+S96lcLHMvWCqLtJadaDZzslL1tk4 nXjeSV5yrEh3uTANJAv0YPRVmJn8wfY= Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id DF7E6AA55; Thu, 25 Mar 2021 10:24:30 +0000 (UTC) Date: Thu, 25 Mar 2021 11:24:29 +0100 From: Michal Hocko To: Oscar Salvador Cc: Mike Kravetz , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Roman Gushchin , Shakeel Butt , David Hildenbrand , Muchun Song , David Rientjes , Miaohe Lin , Peter Zijlstra , Matthew Wilcox , HORIGUCHI NAOYA , "Aneesh Kumar K . V" , Waiman Long , Peter Xu , Mina Almasry , Hillf Danton , Andrew Morton Subject: Re: [PATCH 1/8] mm: cma: introduce cma_release_nowait() Message-ID: References: <20210325002835.216118-1-mike.kravetz@oracle.com> <20210325002835.216118-2-mike.kravetz@oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Stat-Signature: 5sqd59shu3xaosd9mebpip3rq4gacq6b X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: 93BBB4080F65 Received-SPF: none (suse.com>: No applicable sender policy available) receiver=imf26; identity=mailfrom; envelope-from=""; helo=mx2.suse.de; client-ip=195.135.220.15 X-HE-DKIM-Result: pass/pass X-HE-Tag: 1616667871-861104 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu 25-03-21 11:17:32, Oscar Salvador wrote: > On Thu, Mar 25, 2021 at 11:11:49AM +0100, Michal Hocko wrote: > > I have overlooked that > > +static void cma_clear_bitmap_fn(struct work_struct *work) > > +{ > > + struct cma_clear_bitmap_work *w; > > + > > + w = container_of(work, struct cma_clear_bitmap_work, work); > > + > > + cma_clear_bitmap(w->cma, w->pfn, w->count); > > + > > + __free_page(pfn_to_page(w->pfn)); > > +} > > > > should be doing free_contig_range with w->count target. > > That is currently done in cma_release_nowait(). > You meant we should move that work there in the wq? I have missed that part. My bad. But it seems this whole thing is moot because we can make the lock a spinlock as pointed out by David. -- Michal Hocko SUSE Labs