From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 131B2C433B4 for ; Thu, 1 Apr 2021 07:08:39 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 895E361057 for ; Thu, 1 Apr 2021 07:08:38 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 895E361057 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linuxfoundation.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id EF22D6B0080; Thu, 1 Apr 2021 03:08:37 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id EA29D6B0081; Thu, 1 Apr 2021 03:08:37 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D6AD06B0082; Thu, 1 Apr 2021 03:08:37 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id BA6A06B0080 for ; Thu, 1 Apr 2021 03:08:37 -0400 (EDT) Received: from smtpin19.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 8019E180AC155 for ; Thu, 1 Apr 2021 07:08:37 +0000 (UTC) X-FDA: 77982920274.19.1525CF0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by imf14.hostedemail.com (Postfix) with ESMTP id 44845C0007CD for ; Thu, 1 Apr 2021 07:08:35 +0000 (UTC) Received: by mail.kernel.org (Postfix) with ESMTPSA id 485F36101A; Thu, 1 Apr 2021 07:08:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1617260916; bh=TEXlxpnKepHFnwRT0WkjjZQv7faHc3xARsUcW7W7cIU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=f23I5cadoqAjtcU1i9RgAYWho/dVDNRcZ4WQrz+fMM2Dr3xMRQ3mvGul+Pd+lHogE xsjC4dHO5AO8a06eJ8IRffiQDuoY7fBrATkA5sDPVDp8eCbGfQifc0mIjdtDOHuPuT gxmT4/Cx4xvhgjgVe8VCkChgqCluTI4rjPS8wYtc= Date: Thu, 1 Apr 2021 09:08:33 +0200 From: Greg Kroah-Hartman To: Kees Cook Cc: Nathan Chancellor , kernel test robot , kbuild-all@lists.01.org, clang-built-linux@googlegroups.com, Andrew Morton , Linux Memory Management List , "Rafael J. Wysocki" , Michal Hocko , Alexey Dobriyan , Lee Duncan , Chris Leech , Adam Nichols Subject: Re: [PATCH v3] sysfs: Unconditionally use vmalloc for buffer Message-ID: References: <20210401022145.2019422-1-keescook@chromium.org> <202104011400.HiuLgSvb-lkp@intel.com> <20210401064753.6ub6dhcuu6zuhdjq@archlinux-ax161> <202103312354.A15E2A808@keescook> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <202103312354.A15E2A808@keescook> X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: 44845C0007CD X-Stat-Signature: 6c8wbid515fntuh5arzyqo65sbw7o3w8 Received-SPF: none (linuxfoundation.org>: No applicable sender policy available) receiver=imf14; identity=mailfrom; envelope-from=""; helo=mail.kernel.org; client-ip=198.145.29.99 X-HE-DKIM-Result: pass/pass X-HE-Tag: 1617260915-777644 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Mar 31, 2021 at 11:59:03PM -0700, Kees Cook wrote: > On Wed, Mar 31, 2021 at 11:47:53PM -0700, Nathan Chancellor wrote: > > On Thu, Apr 01, 2021 at 02:41:37PM +0800, kernel test robot wrote: > > > Hi Kees, > > > > > > I love your patch! Perhaps something to improve: > > > > > > [auto build test WARNING on driver-core/driver-core-testing] > > > [also build test WARNING on kees/for-next/pstore v5.12-rc5 next-20210331] > > > [cannot apply to hnaz-linux-mm/master] > > > [If your patch is applied to the wrong git tree, kindly drop us a note. > > > And when submitting patch, we suggest to use '--base' as documented in > > > https://git-scm.com/docs/git-format-patch] > > > > > > url: https://github.com/0day-ci/linux/commits/Kees-Cook/sysfs-Unconditionally-use-vmalloc-for-buffer/20210401-102455 > > > base: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/driver-core.git d225ef6fda7ce9ff7d28764bd1cceea2d0215e8b > > > config: powerpc-randconfig-r001-20210401 (attached as .config) > > > compiler: clang version 13.0.0 (https://github.com/llvm/llvm-project 1c268a8ff4e90a85d0e634350b1104080614cf2b) > > > reproduce (this is a W=1 build): > > > wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross > > > chmod +x ~/bin/make.cross > > > # install powerpc cross compiling tool for clang build > > > # apt-get install binutils-powerpc-linux-gnu > > > # https://github.com/0day-ci/linux/commit/c80ca56c15314908ebc1881678da3b36e007a2f4 > > > git remote add linux-review https://github.com/0day-ci/linux > > > git fetch --no-tags linux-review Kees-Cook/sysfs-Unconditionally-use-vmalloc-for-buffer/20210401-102455 > > > git checkout c80ca56c15314908ebc1881678da3b36e007a2f4 > > > # save the attached .config to linux build tree > > > COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=powerpc > > > > > > If you fix the issue, kindly add following tag as appropriate > > > Reported-by: kernel test robot > > > > > > All warnings (new ones prefixed by >>): > > > > > > >> fs/sysfs/file.c:52:14: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic] > > > return NULL + !*ppos; > > > ~~~~ ^ > > > 1 warning generated. > > > > > > > Arnd addressed other warnings of this nature in this patch: > > > > https://lore.kernel.org/r/20201028151202.3074398-1-arnd@kernel.org/ > > Ah! Yeah, I copied exactly that clever idiom that Arnd fixed. :) > > > which it seems never got picked up :( > > Greg, are you able to pick this up too? (Yeow, sent in October!) > (Or I could respin and send them as a series?) As a series would be great, thanks. greg k-h