From: Michal Hocko <mhocko@suse.com>
To: Oscar Salvador <osalvador@suse.de>
Cc: Andrew Morton <akpm@linux-foundation.org>,
David Hildenbrand <david@redhat.com>,
Anshuman Khandual <anshuman.khandual@arm.com>,
Pavel Tatashin <pasha.tatashin@soleen.com>,
Vlastimil Babka <vbabka@suse.cz>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v9 1/8] drivers/base/memory: Introduce memory_block_{online,offline}
Date: Tue, 20 Apr 2021 11:23:08 +0200 [thread overview]
Message-ID: <YH6dfDbT56koiow6@dhcp22.suse.cz> (raw)
In-Reply-To: <20210416112411.9826-2-osalvador@suse.de>
On Fri 16-04-21 13:24:04, Oscar Salvador wrote:
> This is a preparatory patch that introduces two new functions:
> memory_block_online() and memory_block_offline().
>
> For now, these functions will only call online_pages() and offline_pages()
> respectively, but they will be later in charge of preparing the vmemmap
> pages, carrying out the initialization and proper accounting of such
> pages.
>
> Since memory_block struct contains all the information, pass this struct
> down the chain till the end functions.
>
> Signed-off-by: Oscar Salvador <osalvador@suse.de>
> Reviewed-by: David Hildenbrand <david@redhat.com>
Acked-by: Michal Hocko <mhocko@suse.com>
> ---
> drivers/base/memory.c | 33 +++++++++++++++++++++------------
> 1 file changed, 21 insertions(+), 12 deletions(-)
>
> diff --git a/drivers/base/memory.c b/drivers/base/memory.c
> index f35298425575..f209925a5d4e 100644
> --- a/drivers/base/memory.c
> +++ b/drivers/base/memory.c
> @@ -169,30 +169,41 @@ int memory_notify(unsigned long val, void *v)
> return blocking_notifier_call_chain(&memory_chain, val, v);
> }
>
> +static int memory_block_online(struct memory_block *mem)
> +{
> + unsigned long start_pfn = section_nr_to_pfn(mem->start_section_nr);
> + unsigned long nr_pages = PAGES_PER_SECTION * sections_per_block;
> +
> + return online_pages(start_pfn, nr_pages, mem->online_type, mem->nid);
> +}
> +
> +static int memory_block_offline(struct memory_block *mem)
> +{
> + unsigned long start_pfn = section_nr_to_pfn(mem->start_section_nr);
> + unsigned long nr_pages = PAGES_PER_SECTION * sections_per_block;
> +
> + return offline_pages(start_pfn, nr_pages);
> +}
> +
> /*
> * MEMORY_HOTPLUG depends on SPARSEMEM in mm/Kconfig, so it is
> * OK to have direct references to sparsemem variables in here.
> */
> static int
> -memory_block_action(unsigned long start_section_nr, unsigned long action,
> - int online_type, int nid)
> +memory_block_action(struct memory_block *mem, unsigned long action)
> {
> - unsigned long start_pfn;
> - unsigned long nr_pages = PAGES_PER_SECTION * sections_per_block;
> int ret;
>
> - start_pfn = section_nr_to_pfn(start_section_nr);
> -
> switch (action) {
> case MEM_ONLINE:
> - ret = online_pages(start_pfn, nr_pages, online_type, nid);
> + ret = memory_block_online(mem);
> break;
> case MEM_OFFLINE:
> - ret = offline_pages(start_pfn, nr_pages);
> + ret = memory_block_offline(mem);
> break;
> default:
> WARN(1, KERN_WARNING "%s(%ld, %ld) unknown action: "
> - "%ld\n", __func__, start_section_nr, action, action);
> + "%ld\n", __func__, mem->start_section_nr, action, action);
> ret = -EINVAL;
> }
>
> @@ -210,9 +221,7 @@ static int memory_block_change_state(struct memory_block *mem,
> if (to_state == MEM_OFFLINE)
> mem->state = MEM_GOING_OFFLINE;
>
> - ret = memory_block_action(mem->start_section_nr, to_state,
> - mem->online_type, mem->nid);
> -
> + ret = memory_block_action(mem, to_state);
> mem->state = ret ? from_state_req : to_state;
>
> return ret;
> --
> 2.16.3
--
Michal Hocko
SUSE Labs
next prev parent reply other threads:[~2021-04-20 9:23 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20210416112411.9826-1-osalvador@suse.de>
2021-04-16 11:24 ` [PATCH v9 1/8] drivers/base/memory: Introduce memory_block_{online,offline} Oscar Salvador
2021-04-20 9:23 ` Michal Hocko [this message]
2021-04-16 11:24 ` [PATCH v9 2/8] mm,memory_hotplug: Relax fully spanned sections check Oscar Salvador
2021-04-20 9:40 ` Michal Hocko
2021-04-21 7:37 ` Oscar Salvador
2021-04-16 11:24 ` [PATCH v9 3/8] mm,memory_hotplug: Factor out adjusting present pages into adjust_present_page_count() Oscar Salvador
2021-04-20 9:45 ` Michal Hocko
2021-04-21 8:00 ` Oscar Salvador
2021-04-21 8:06 ` David Hildenbrand
2021-04-21 8:31 ` Michal Hocko
2021-04-21 8:35 ` Oscar Salvador
2021-04-16 11:24 ` [PATCH v9 4/8] mm,memory_hotplug: Allocate memmap from the added memory range Oscar Salvador
2021-04-20 10:56 ` Michal Hocko
2021-04-21 8:15 ` Oscar Salvador
2021-04-21 8:39 ` Michal Hocko
2021-04-21 8:44 ` David Hildenbrand
2021-04-21 8:49 ` Michal Hocko
2021-04-21 8:52 ` David Hildenbrand
2021-04-21 8:46 ` Oscar Salvador
2021-04-16 11:24 ` [PATCH v9 5/8] acpi,memhotplug: Enable MHP_MEMMAP_ON_MEMORY when supported Oscar Salvador
2021-04-16 11:24 ` [PATCH v9 6/8] mm,memory_hotplug: Add kernel boot option to enable memmap_on_memory Oscar Salvador
2021-04-16 11:24 ` [PATCH v9 7/8] x86/Kconfig: Introduce ARCH_MHP_MEMMAP_ON_MEMORY_ENABLE Oscar Salvador
2021-04-20 10:56 ` Michal Hocko
2021-04-16 11:24 ` [PATCH v9 8/8] arm64/Kconfig: " Oscar Salvador
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YH6dfDbT56koiow6@dhcp22.suse.cz \
--to=mhocko@suse.com \
--cc=akpm@linux-foundation.org \
--cc=anshuman.khandual@arm.com \
--cc=david@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=osalvador@suse.de \
--cc=pasha.tatashin@soleen.com \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).