From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 987B9C43460 for ; Sat, 10 Apr 2021 08:55:10 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 33D5461105 for ; Sat, 10 Apr 2021 08:55:10 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 33D5461105 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=kroah.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 8CBBD6B006C; Sat, 10 Apr 2021 04:55:09 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8A5756B006E; Sat, 10 Apr 2021 04:55:09 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 71E5A6B0070; Sat, 10 Apr 2021 04:55:09 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0039.hostedemail.com [216.40.44.39]) by kanga.kvack.org (Postfix) with ESMTP id 48ACE6B006C for ; Sat, 10 Apr 2021 04:55:09 -0400 (EDT) Received: from smtpin40.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id DDD2F180B262F for ; Sat, 10 Apr 2021 08:55:08 +0000 (UTC) X-FDA: 78015847896.40.6CF10CF Received: from new2-smtp.messagingengine.com (new2-smtp.messagingengine.com [66.111.4.224]) by imf10.hostedemail.com (Postfix) with ESMTP id 8262640002C2 for ; Sat, 10 Apr 2021 08:55:04 +0000 (UTC) Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailnew.nyi.internal (Postfix) with ESMTP id CA907580837; Sat, 10 Apr 2021 04:55:07 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute4.internal (MEProxy); Sat, 10 Apr 2021 04:55:07 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kroah.com; h= date:from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=fm3; bh=5uGzC6LNv+sAq4wwCUhA+ZWu3IK 7ZSq0aFCqAf14d0Q=; b=HvEYZVKwKybrc+hwpLOCV+3kvgyZcCQBYLg58PghLeW IMOEZPNGoMnr25CBiUYz1hn9InOHocNBB2g6xAKJJ5axfLc63pifdZdbvF0Oz7tw Ao65ZccGjGnWmdRrqEitT9yDuzOjyS/y1UZ455gTrzu9V95E9J7gF4i7Cf1UNfcH ehLHpZvN2GlIWntBcdiUlnigpdCjRJymqkV2LUDwi9GtxOl6g78/3tlKZhfEa3HE QhguJhj2sl+8S3QcLrXMq8bEF3ny0foTx3/46eplso4PdCAjj+A11TENwvZdmkzC 5cRepQVGyuGRQdWgdTzOyP9WskGFu1L07b6mCIGte/A== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=5uGzC6 LNv+sAq4wwCUhA+ZWu3IK7ZSq0aFCqAf14d0Q=; b=mx0MeMsxHvtgYZV3LIeuBu eHQUZaRqosNpEDt0qOm1Bse4BLOXyrEpNuPUrrqJy6ajjh+54SBIbrmpA8MvKVmf L/g4hNy+ku9uzklKEkPojfoUQ1kSIAHN6n2r0g1EVUk/aILzHX3v2zTTT2zrFLK3 38ykYJ2jHuav+i8ERK4JhMj1fmEFq09BjvMdruQFEHPmsOkXEOjHXfn1XPc5D9uU CLdavAbKvR/JD3+oQ1ouH9mp11bwQSflo7mwUESF+tV0W1wQdpekHXe0xFdvcj6U T5/Ge8A15F80aEKQFRyvT19rSDf4b/vc8OEp++Egj96A7I8K6M1rVC9dOWOg6WYA == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrudekfedguddtucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvffukfhfgggtuggjsehttdertddttddvnecuhfhrohhmpefirhgvghcu mffjuceoghhrvghgsehkrhhorghhrdgtohhmqeenucggtffrrghtthgvrhhnpeevueehje fgfffgiedvudekvdektdelleelgefhleejieeugeegveeuuddukedvteenucfkphepkeef rdekiedrjeegrdeigeenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrih hlfhhrohhmpehgrhgvgheskhhrohgrhhdrtghomh X-ME-Proxy: Received: from localhost (83-86-74-64.cable.dynamic.v4.ziggo.nl [83.86.74.64]) by mail.messagingengine.com (Postfix) with ESMTPA id CCA9B24005D; Sat, 10 Apr 2021 04:55:03 -0400 (EDT) Date: Sat, 10 Apr 2021 10:55:01 +0200 From: Greg KH To: SeongJae Park Cc: akpm@linux-foundation.org, SeongJae Park , Jonathan.Cameron@huawei.com, acme@kernel.org, alexander.shishkin@linux.intel.com, amit@kernel.org, benh@kernel.crashing.org, brendanhiggins@google.com, corbet@lwn.net, david@redhat.com, dwmw@amazon.com, elver@google.com, fan.du@intel.com, foersleo@amazon.de, gthelen@google.com, guoju.fgj@alibaba-inc.com, mgorman@suse.de, minchan@kernel.org, mingo@redhat.com, namhyung@kernel.org, peterz@infradead.org, riel@surriel.com, rientjes@google.com, rostedt@goodmis.org, rppt@kernel.org, shakeelb@google.com, shuah@kernel.org, snu@amazon.de, vbabka@suse.cz, vdavydov.dev@gmail.com, zgf574564920@gmail.com, linux-damon@amazon.com, linux-mm@kvack.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v27 07/13] mm/damon: Implement a debugfs-based user space interface Message-ID: References: <20210408134854.31625-1-sj38.park@gmail.com> <20210408134854.31625-8-sj38.park@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210408134854.31625-8-sj38.park@gmail.com> X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 8262640002C2 X-Stat-Signature: yyp5fyk4coay3owqezw5bzj8zgtkzc7y Received-SPF: none (kroah.com>: No applicable sender policy available) receiver=imf10; identity=mailfrom; envelope-from=""; helo=new2-smtp.messagingengine.com; client-ip=66.111.4.224 X-HE-DKIM-Result: pass/pass X-HE-Tag: 1618044904-729708 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Apr 08, 2021 at 01:48:48PM +0000, SeongJae Park wrote: > +static int dbgfs_fill_ctx_dir(struct dentry *dir, struct damon_ctx *ctx) > +{ > + const char * const file_names[] = {"attrs", "target_ids"}; > + const struct file_operations *fops[] = {&attrs_fops, &target_ids_fops}; > + int i; > + > + for (i = 0; i < ARRAY_SIZE(file_names); i++) > + debugfs_create_file(file_names[i], 0600, dir, ctx, fops[i]); > + > + return 0; > +} Why do you have a function that can only return 0, actually return something? It should be void, right? thanks, greg k-h