From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-24.8 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1,USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4BD21C433ED for ; Mon, 12 Apr 2021 09:56:47 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id E1552611AD for ; Mon, 12 Apr 2021 09:56:46 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E1552611AD Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 616C96B0036; Mon, 12 Apr 2021 05:56:46 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 59F266B006C; Mon, 12 Apr 2021 05:56:46 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3F15F6B006E; Mon, 12 Apr 2021 05:56:46 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0172.hostedemail.com [216.40.44.172]) by kanga.kvack.org (Postfix) with ESMTP id 1D6976B0036 for ; Mon, 12 Apr 2021 05:56:46 -0400 (EDT) Received: from smtpin17.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id C6828180ACF86 for ; Mon, 12 Apr 2021 09:56:45 +0000 (UTC) X-FDA: 78023260770.17.CAC1E39 Received: from mail-wm1-f41.google.com (mail-wm1-f41.google.com [209.85.128.41]) by imf07.hostedemail.com (Postfix) with ESMTP id 2D4D8A000394 for ; Mon, 12 Apr 2021 09:56:45 +0000 (UTC) Received: by mail-wm1-f41.google.com with SMTP id g66-20020a1c39450000b0290125d187ba22so6018728wma.2 for ; Mon, 12 Apr 2021 02:56:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=x64UxveCRW4RajFKsVGNGXf3lywyRk8W2oXT55aEfiI=; b=ZZehmiUQH7HTgWJusG3P63jtuZJ1fOZY0GJgJg9kG2fCHZw7zN5yM4QDuiIlh92iIG IdT6FSofFV3YhV7xfTvXE4biJV1u/j+4VPKgZyTa4dG9SycBgjYDN+yUNnuQII2cyHtr E9JuRod91aEodPIIFVZKBRM93dHU1O6S6xlcuauyvpADAk8TvIuH6/YrIpVQX1Grz5OD wtJNN4VUOTZGzFZJyQkfrujMOHUVD14AFVkXnZhJwzKjUUsk8uKg5lwNISqlW7U0TS19 9fZ/nxnR/Pc8lnYflzqvoa+iwmOQeyCRKo1xwpCQoNkEuvm3G8o0G85w2kit5WxtzoVw F92g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=x64UxveCRW4RajFKsVGNGXf3lywyRk8W2oXT55aEfiI=; b=gI1Kd+pB+lSguvhOdtaY3YX2FpdAe33piWYhmFTs2EpuH8jxfarKDhIBpHH1NNQCCi 0FHbMKOMVIZrLxMjePbNFqRN72oWa8Q0/PO//xSTBXAXVNmlgVOrtpoLvhbNyYyFa+F6 d16jgBKNUovj6BPp2BJKan788wrv0LjAhpimvBskbGZIeMrRoyPowwSMFMzUS+Uaim3I R2h8EuYoXQPNb3zTV1SlNYSznaGrVi9H6NfnVEKrppKBChJcmG0x7ksNjEnUQxfac0wF iET7B4rf46QipuLAdxRWdnWjP0s1+oEXe/c7B+eg0p24AReHy9MO1cF0Iv+Arb3h9pm7 wFgw== X-Gm-Message-State: AOAM533AtubXF89USGpxqunYUCPaj5v1zK2SKuskpf7RJ588Ka34eMCj BKeIMquOqwo4yNboIcu5giTWCA== X-Google-Smtp-Source: ABdhPJwjgzdRR5eaK7rjE9blp5agPSFon+CFf8CCOZ9jJDid4aph+YE18Sx9zdSCN22W3I0lqG1/UA== X-Received: by 2002:a05:600c:4f03:: with SMTP id l3mr26080729wmq.149.1618221404054; Mon, 12 Apr 2021 02:56:44 -0700 (PDT) Received: from elver.google.com ([2a00:79e0:15:13:197c:ad7a:49b7:8f5c]) by smtp.gmail.com with ESMTPSA id l4sm14539432wmh.8.2021.04.12.02.56.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 12 Apr 2021 02:56:43 -0700 (PDT) Date: Mon, 12 Apr 2021 11:56:37 +0200 From: Marco Elver To: Andrew Morton Cc: Andrey Konovalov , Arnd Bergmann , Dmitry Vyukov , Alexander Potapenko , Linux Memory Management List , Masahiro Yamada , Michal Marek , mm-commits@vger.kernel.org, Nathan Chancellor , Nick Desaulniers , Andrey Ryabinin , Linus Torvalds Subject: Re: [patch 05/16] kasan: fix hwasan build for gcc Message-ID: References: <20210409132633.6855fc8fea1b3905ea1bb4be@linux-foundation.org> <20210409202713.NIELx3Tx9%akpm@linux-foundation.org> <20210409135836.5fd622e4bec07650774f58c2@linux-foundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210409135836.5fd622e4bec07650774f58c2@linux-foundation.org> User-Agent: Mutt/2.0.5 (2021-01-21) X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: 2D4D8A000394 X-Stat-Signature: opnupe89aj6rdtj9mcoq861xzocqkjxy Received-SPF: none (google.com>: No applicable sender policy available) receiver=imf07; identity=mailfrom; envelope-from=""; helo=mail-wm1-f41.google.com; client-ip=209.85.128.41 X-HE-DKIM-Result: pass/pass X-HE-Tag: 1618221405-720731 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Apr 09, 2021 at 01:58PM -0700, Andrew Morton wrote: > On Fri, 9 Apr 2021 22:39:46 +0200 Andrey Konovalov wrote: > > > > > > > endif # CONFIG_KASAN_SW_TAGS > > > _ > > > > Hi, > > > > As I commented on the patch, this breaks SW_TAGS build with Clang for me with: > > > > arch/arm64/include/asm/current.h:19: undefined reference to `__hwasan_tls' > > > > The reason for this is that cc-param is only defined for > > KASAN_GENERIC, the definition needs to be moved. > > > > Oh. I thought that had been fixed. > > Please send a patch? I think we need something like the below. Unless a fixed version has already been sent, feel free to squash (applies immediately after "kasan: fix hwasan build for gcc", and before the conflicting "kasan: remove redundant config option"). Thanks, -- Marco ------ >8 ------ From: Marco Elver Date: Sun, 11 Apr 2021 21:32:01 +0200 Subject: [PATCH] fixup for "kasan: fix hwasan build for gcc" Signed-off-by: Marco Elver --- scripts/Makefile.kasan | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/scripts/Makefile.kasan b/scripts/Makefile.kasan index 0a2789783d1b..127012f45166 100644 --- a/scripts/Makefile.kasan +++ b/scripts/Makefile.kasan @@ -2,6 +2,8 @@ CFLAGS_KASAN_NOSANITIZE := -fno-builtin KASAN_SHADOW_OFFSET ?= $(CONFIG_KASAN_SHADOW_OFFSET) +cc-param = $(call cc-option, -mllvm -$(1), $(call cc-option, --param $(1))) + ifdef CONFIG_KASAN_GENERIC ifdef CONFIG_KASAN_INLINE @@ -12,8 +14,6 @@ endif CFLAGS_KASAN_MINIMAL := -fsanitize=kernel-address -cc-param = $(call cc-option, -mllvm -$(1), $(call cc-option, --param $(1))) - # -fasan-shadow-offset fails without -fsanitize CFLAGS_KASAN_SHADOW := $(call cc-option, -fsanitize=kernel-address \ -fasan-shadow-offset=$(KASAN_SHADOW_OFFSET), \ -- 2.31.1.295.g9ea45b61b8-goog