From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.0 required=3.0 tests=BAYES_00,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 612A7C433ED for ; Fri, 16 Apr 2021 21:06:27 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id B460D613CE for ; Fri, 16 Apr 2021 21:06:26 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B460D613CE Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 0B5D16B006C; Fri, 16 Apr 2021 17:06:26 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 0653A6B006E; Fri, 16 Apr 2021 17:06:26 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E703C6B0070; Fri, 16 Apr 2021 17:06:25 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id CA25B6B006C for ; Fri, 16 Apr 2021 17:06:25 -0400 (EDT) Received: from smtpin18.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 8D8FC18036FEF for ; Fri, 16 Apr 2021 21:06:25 +0000 (UTC) X-FDA: 78039463530.18.944B83E Received: from mail-io1-f45.google.com (mail-io1-f45.google.com [209.85.166.45]) by imf21.hostedemail.com (Postfix) with ESMTP id 12C9BE000102 for ; Fri, 16 Apr 2021 21:06:22 +0000 (UTC) Received: by mail-io1-f45.google.com with SMTP id v123so22150030ioe.10 for ; Fri, 16 Apr 2021 14:06:24 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=2ZMwtUn8ISxVk4yLYfxm/bAfidINBvOsGVHhs0Qq4G4=; b=fV5/XMwfL5vEn2XbGt2jD/M0vFXKXsT0E8xxRprXJPWWHUVOr8jNLVUrklELGts937 FiwmkVAkTTi5SQIK5YVf52a7DZeM/ysbx3EkjJ69zPHPjoSw5lYjOBTIXzE0V+gtCaRF sqJuZ95x2hPwY9N5PQOECD7qlNj7gdODOhpoPH9ERTA/HtLo3rOX/bWgAfzsRVYG8cVH GNgauO7E567kAihu37FMFfS6YkwaZe6XS2PoXSmqdTWdlDQj+D4KZd23DrcRPoQaPSoW w0t1ScMD0OHtbMQd4W03sm3hd58wUDw/BASS2xd2DSSRsJrBUwndLtKHS4rvVJ0DLQIW vGiA== X-Gm-Message-State: AOAM531++SC7B6Y0gn4GZs+4tD2X0xE2n7snRilPrkCA/igS89JjXJPW VxX0qIoAlCV/1/ppAz6Yxa0= X-Google-Smtp-Source: ABdhPJxYex6qOxFyO/qzC5ltnygdMTBP3vj/7tbKjNNhIBxEOsbAfT5tqbnp16oAPV+26pilMQoU6w== X-Received: by 2002:a5e:8e41:: with SMTP id r1mr5109605ioo.5.1618607184534; Fri, 16 Apr 2021 14:06:24 -0700 (PDT) Received: from google.com (243.199.238.35.bc.googleusercontent.com. [35.238.199.243]) by smtp.gmail.com with ESMTPSA id e13sm3082335ioe.0.2021.04.16.14.06.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 16 Apr 2021 14:06:24 -0700 (PDT) Date: Fri, 16 Apr 2021 21:06:22 +0000 From: Dennis Zhou To: Roman Gushchin Cc: Tejun Heo , Christoph Lameter , Andrew Morton , Vlastimil Babka , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 1/6] percpu: fix a comment about the chunks ordering Message-ID: References: <20210408035736.883861-1-guro@fb.com> <20210408035736.883861-2-guro@fb.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210408035736.883861-2-guro@fb.com> X-Stat-Signature: ihrhpgrt8me74a4nzyrm53mbmxeq6mzy X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 12C9BE000102 Received-SPF: none (gmail.com>: No applicable sender policy available) receiver=imf21; identity=mailfrom; envelope-from=""; helo=mail-io1-f45.google.com; client-ip=209.85.166.45 X-HE-DKIM-Result: none/none X-HE-Tag: 1618607182-77840 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000002, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hello, On Wed, Apr 07, 2021 at 08:57:31PM -0700, Roman Gushchin wrote: > Since the commit 3e54097beb22 ("percpu: manage chunks based on > contig_bits instead of free_bytes") chunks are sorted based on the > size of the biggest continuous free area instead of the total number > of free bytes. Update the corresponding comment to reflect this. > > Signed-off-by: Roman Gushchin > --- > mm/percpu.c | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/mm/percpu.c b/mm/percpu.c > index 6596a0a4286e..2f27123bb489 100644 > --- a/mm/percpu.c > +++ b/mm/percpu.c > @@ -99,7 +99,10 @@ > > #include "percpu-internal.h" > > -/* the slots are sorted by free bytes left, 1-31 bytes share the same slot */ > +/* > + * The slots are sorted by the size of the biggest continuous free area. > + * 1-31 bytes share the same slot. > + */ > #define PCPU_SLOT_BASE_SHIFT 5 > /* chunks in slots below this are subject to being sidelined on failed alloc */ > #define PCPU_SLOT_FAIL_THRESHOLD 3 > -- > 2.30.2 > I've applied this to for-5.14. Thanks, Dennis