From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C12D2C433B4 for ; Mon, 3 May 2021 08:44:29 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 391E66127A for ; Mon, 3 May 2021 08:44:29 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 391E66127A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 665AB6B0036; Mon, 3 May 2021 04:44:27 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 616486B006E; Mon, 3 May 2021 04:44:27 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4DD336B0070; Mon, 3 May 2021 04:44:27 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0246.hostedemail.com [216.40.44.246]) by kanga.kvack.org (Postfix) with ESMTP id 337436B0036 for ; Mon, 3 May 2021 04:44:27 -0400 (EDT) Received: from smtpin30.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id D130E7582 for ; Mon, 3 May 2021 08:44:26 +0000 (UTC) X-FDA: 78099283332.30.3E35896 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by imf08.hostedemail.com (Postfix) with ESMTP id 64B8380192D4 for ; Mon, 3 May 2021 08:44:02 +0000 (UTC) Received: by mail.kernel.org (Postfix) with ESMTPSA id DD14B610EA; Mon, 3 May 2021 08:44:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1620031465; bh=ayNupM3q5p2pA01eseLR8Dv+rDUcAmtcqGwl5AQ6O2k=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=f0mYXgd4+L6ElyJNZknXe3/27PpgI89ZAmo86Oo4Jh3B2bGUBoxOcR0uTAMwEH42P NRNWtYOMGR2ig6xRKT6656l72sNDNMGgG9hqtDUEy8BBcdk//kuvaH+acF5uh8tTsC QgsVPqfImbiGiTIo2EqQs4UGludApb8J0jFv0y3dmZ7/W/gVgXowjEJ3RKmLCIYsbZ sWxNbolPcs6NXVZczlnCV7WNJzUGXU45ZN7NoZvYUzdp+JM+uEumnuJiLL3zfAREMa +SbRCvNmMD+sE2VHxro6dsvN/Q2vzTHIGwhN/5RQfz3IC1cvDC15rPef4cWPSu6W20 xCKxVUWPMoB/A== Date: Mon, 3 May 2021 11:44:10 +0300 From: Mike Rapoport To: David Hildenbrand Cc: Kefeng Wang , linux-arm-kernel@lists.infradead.org, Andrew Morton , Anshuman Khandual , Ard Biesheuvel , Catalin Marinas , Marc Zyngier , Mark Rutland , Mike Rapoport , Will Deacon , kvmarm@lists.cs.columbia.edu, linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: arm32: panic in move_freepages (Was [PATCH v2 0/4] arm64: drop pfn_valid_within() and simplify pfn_valid()) Message-ID: References: <259d14df-a713-72e7-4ccb-c06a8ee31e13@huawei.com> <6ad2956c-70ae-c423-ed7d-88e94c88060f@huawei.com> <0cb013e4-1157-f2fa-96ec-e69e60833f72@huawei.com> <24b37c01-fc75-d459-6e61-d67e8f0cf043@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline In-Reply-To: <24b37c01-fc75-d459-6e61-d67e8f0cf043@redhat.com> Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=f0mYXgd4; spf=pass (imf08.hostedemail.com: domain of rppt@kernel.org designates 198.145.29.99 as permitted sender) smtp.mailfrom=rppt@kernel.org; dmarc=pass (policy=none) header.from=kernel.org X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: 64B8380192D4 X-Stat-Signature: n8y8fqjyg1fubkbmxfbu6h8gbprws11b Received-SPF: none (kernel.org>: No applicable sender policy available) receiver=imf08; identity=mailfrom; envelope-from=""; helo=mail.kernel.org; client-ip=198.145.29.99 X-HE-DKIM-Result: pass/pass X-HE-Tag: 1620031442-969804 Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, May 03, 2021 at 10:07:01AM +0200, David Hildenbrand wrote: > On 03.05.21 08:26, Mike Rapoport wrote: > > On Fri, Apr 30, 2021 at 07:24:37PM +0800, Kefeng Wang wrote: > > >=20 > > >=20 > > > On 2021/4/30 17:51, Mike Rapoport wrote: > > > > On Thu, Apr 29, 2021 at 06:22:55PM +0800, Kefeng Wang wrote: > > > > >=20 > > > > > On 2021/4/29 14:57, Mike Rapoport wrote: > > > > >=20 > > > > > > > > Do you use SPARSMEM? If yes, what is your section size? > > > > > > > > What is the value if CONFIG_FORCE_MAX_ZONEORDER in your c= onfiguration? > > > > > > > Yes, > > > > > > >=20 > > > > > > > CONFIG_SPARSEMEM=3Dy > > > > > > >=20 > > > > > > > CONFIG_SPARSEMEM_STATIC=3Dy > > > > > > >=20 > > > > > > > CONFIG_FORCE_MAX_ZONEORDER =3D 11 > > > > > > >=20 > > > > > > > CONFIG_PAGE_OFFSET=3D0xC0000000 > > > > > > > CONFIG_HAVE_ARCH_PFN_VALID=3Dy > > > > > > > CONFIG_HIGHMEM=3Dy > > > > > > > #define SECTION_SIZE_BITS 26 > > > > > > > #define MAX_PHYSADDR_BITS 32 > > > > > > > #define MAX_PHYSMEM_BITS 32 > > > > >=20 > > > > >=20 > > > > > With the patch,=A0 the addr is aligned, but the panic still occ= urred, > > > >=20 > > > > Is this the same panic at move_freepages() for range [de600, de7f= f]? > > > >=20 > > > > Do you enable CONFIG_ARM_LPAE? > > >=20 > > > no, the CONFIG_ARM_LPAE is not set, and yes with same panic at > > > move_freepages at > > >=20 > > > start_pfn/end_pfn [de600, de7ff], [de600000, de7ff000] : pfn =3Dde= 600, page > > > =3Def3cc000, page-flags =3D ffffffff, pfn2phy =3D de600000 > > >=20 > > > > > __free_memory_core, range: 0xb0200000 - 0xc0000000, pfn: b0200 = - b0200 > > > > > __free_memory_core, range: 0xcc000000 - 0xdca00000, pfn: cc000 = - b0200 > > > > > __free_memory_core, range: 0xde700000 - 0xdea00000, pfn: de700 = - b0200 > >=20 > > Hmm, [de600, de7ff] is not added to the free lists which is correct. = But > > then it's unclear how the page for de600 gets to move_freepages()... > >=20 > > Can't say I have any bright ideas to try here... >=20 > Are we missing some checks (e.g., PageReserved()) that pfn_valid_within= () > would have "caught" before? Unless I'm missing something the crash happens in __rmqueue_fallback(): do_steal: page =3D get_page_from_free_area(area, fallback_mt); steal_suitable_fallback(zone, page, alloc_flags, start_migratetype, can_steal); -> move_freepages()=20 -> BUG() So a page from free area should be sane as the freed range was never adde= d it to the free lists. And honestly, with the memory layout reported elsewhere in the stack I'd say that the bootloader/fdt beg for fixes... --=20 Sincerely yours, Mike.