From: Dennis Zhou <dennis@kernel.org>
To: Tejun Heo <tj@kernel.org>, Christoph Lameter <cl@linux.com>,
Roman Gushchin <guro@fb.com>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 0/4] percpu: partial chunk depopulation
Date: Wed, 21 Apr 2021 18:24:58 +0000 [thread overview]
Message-ID: <YIBt+qaZ4teb+WfW@google.com> (raw)
In-Reply-To: <20210419225047.3415425-1-dennis@kernel.org>
On Mon, Apr 19, 2021 at 10:50:43PM +0000, Dennis Zhou wrote:
> Hello,
>
> This series is a continuation of Roman's series in [1]. It aims to solve
> chunks holding onto free pages by adding a reclaim process to the percpu
> balance work item.
>
> The main difference is that the nr_empty_pop_pages is now managed at
> time of isolation instead of intermixed. This helps with deciding which
> chunks to free instead of having to interleave returning chunks to
> active duty.
>
> The allocation priority is as follows:
> 1) appropriate chunk slot increasing until fit
> 2) sidelined chunks
> 3) full free chunks
>
> The last slot for to_depopulate is never used for allocations.
>
> A big thanks to Roman for initiating the work and being available for
> iterating on these ideas.
>
> This patchset contains the following 4 patches:
> 0001-percpu-factor-out-pcpu_check_block_hint.patch
> 0002-percpu-use-pcpu_free_slot-instead-of-pcpu_nr_slots-1.patch
> 0003-percpu-implement-partial-chunk-depopulation.patch
> 0004-percpu-use-reclaim-threshold-instead-of-running-for-.patch
>
> 0001 and 0002 are clean ups. 0003 implement partial chunk depopulation
> initially from Roman. 0004 adds a reclaim threshold so we do not need to
> schedule for every page freed.
>
> This series is on top of percpu$for-5.14 67c2669d69fb.
>
> diffstats below:
>
> Dennis Zhou (2):
> percpu: use pcpu_free_slot instead of pcpu_nr_slots - 1
> percpu: use reclaim threshold instead of running for every page
>
> Roman Gushchin (2):
> percpu: factor out pcpu_check_block_hint()
> percpu: implement partial chunk depopulation
>
> mm/percpu-internal.h | 5 +
> mm/percpu-km.c | 5 +
> mm/percpu-stats.c | 20 ++--
> mm/percpu-vm.c | 30 ++++++
> mm/percpu.c | 252 ++++++++++++++++++++++++++++++++++++++-----
> 5 files changed, 278 insertions(+), 34 deletions(-)
>
> Thanks,
> Dennis
I've applied this to for-5.14 with 1 modification to the batching
threshold, 4 pages is quite little, so make it 16.
Thanks,
Dennis
prev parent reply other threads:[~2021-04-21 18:25 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-19 22:50 [PATCH v4 0/4] percpu: partial chunk depopulation Dennis Zhou
2021-04-19 22:50 ` [PATCH 1/4] percpu: factor out pcpu_check_block_hint() Dennis Zhou
2021-04-19 22:50 ` [PATCH 2/4] percpu: use pcpu_free_slot instead of pcpu_nr_slots - 1 Dennis Zhou
2021-04-20 21:22 ` Roman Gushchin
2021-04-19 22:50 ` [PATCH 3/4] percpu: implement partial chunk depopulation Dennis Zhou
2021-07-02 19:11 ` Guenter Roeck
2021-07-02 19:45 ` Dennis Zhou
2021-07-02 20:28 ` Guenter Roeck
2021-07-02 21:00 ` Dennis Zhou
2021-04-19 22:50 ` [PATCH 4/4] percpu: use reclaim threshold instead of running for every page Dennis Zhou
2021-04-20 21:23 ` Roman Gushchin
2021-04-19 22:54 ` [PATCH v4 0/4] percpu: partial chunk depopulation Dennis Zhou
2021-04-19 22:57 ` Dennis Zhou
2021-04-20 11:07 ` Pratik Sampat
2021-04-20 14:39 ` Dennis Zhou
2021-04-20 15:25 ` Pratik Sampat
2021-04-21 18:24 ` Dennis Zhou [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YIBt+qaZ4teb+WfW@google.com \
--to=dennis@kernel.org \
--cc=cl@linux.com \
--cc=guro@fb.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).