From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 29530C433B4 for ; Thu, 13 May 2021 21:28:46 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id C10DC613C3 for ; Thu, 13 May 2021 21:28:45 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C10DC613C3 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 55DD86B0036; Thu, 13 May 2021 17:28:45 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 50E336B006E; Thu, 13 May 2021 17:28:45 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 388206B0070; Thu, 13 May 2021 17:28:45 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0231.hostedemail.com [216.40.44.231]) by kanga.kvack.org (Postfix) with ESMTP id 055356B0036 for ; Thu, 13 May 2021 17:28:44 -0400 (EDT) Received: from smtpin17.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 93D4F180868F0 for ; Thu, 13 May 2021 21:28:44 +0000 (UTC) X-FDA: 78137497368.17.7B1627D Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf04.hostedemail.com (Postfix) with ESMTP id CF2F03C6 for ; Thu, 13 May 2021 21:28:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Transfer-Encoding: Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date: Sender:Reply-To:Content-ID:Content-Description; bh=V1rOYMT9k8A/s4ml+UdcdvoHKOVvK0OalWOKj1zAbw4=; b=RUDS28TunEHfrf3zmImQUjPJVw rHn1CGTDnwJJAyI5ULHPZ8RueWmcrTL3lSPv7qEAdxvbgDttyIb/zSZmusU6ZOwxthy+JdlH73H/P 9fk85iN61NvwZ0WeKPlC1EbRjgjmXwyZMloKdSc1APDCXvmNL/HSGNxJylB4f/43jrXhKb/0r1QkV oNTT9zisgQBrj36tmKbXQEDbpL2BLTVqv+cmFjoxf6oL/4Rm1EoWZJAcC5psGxcd8Oz2TH1Yv3zC9 yVGffF2KFDFXKun2CsvmRKCjrEAv6DNjKOoTsSiBHvpFR1TT/MSpmxzV4XLHB1hFB4ZhlFEonNphK 4+stMZ4Q==; Received: from willy by casper.infradead.org with local (Exim 4.94 #2 (Red Hat Linux)) id 1lhIrd-009n39-8x; Thu, 13 May 2021 21:27:38 +0000 Date: Thu, 13 May 2021 22:27:25 +0100 From: Matthew Wilcox To: Randy Dunlap Cc: Stephen Rothwell , Linux Next Mailing List , Linux Kernel Mailing List , Alexander Duyck , Andrew Morton , Linux MM , Anshuman Khandual Subject: Re: linux-next: Tree for May 13 (mm/page_alloc.c, : sizeof(struct page)) Message-ID: References: <20210513154418.2946f422@canb.auug.org.au> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=RUDS28Tu; spf=none (imf04.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: CF2F03C6 X-Stat-Signature: nrafqr8x4ks4ksogphm43ao4bqsaxh1h X-HE-Tag: 1620941323-160175 Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, May 13, 2021 at 10:29:49AM -0700, Randy Dunlap wrote: > On 5/12/21 10:44 PM, Stephen Rothwell wrote: > > Hi all, > >=20 > > Changes since 20210512: > >=20 >=20 > on x86_64: >=20 > In function =E2=80=98__mm_zero_struct_page.isra.75=E2=80=99, > inlined from =E2=80=98__init_single_page.isra.76=E2=80=99 at ../mm/= page_alloc.c:1494:2: > ./../include/linux/compiler_types.h:328:38: error: call to =E2=80=98__c= ompiletime_assert_162=E2=80=99 declared with attribute error: BUILD_BUG_O= N failed: sizeof(struct page) > 80 Hmm. struct { long unsigned int _pt_pad_1; /* 8 8 *= / pgtable_t pmd_huge_pte; /* 16 8 *= / long unsigned int _pt_pad_2; /* 24 8 *= / union { struct mm_struct * pt_mm; /* 32 8 = */ atomic_t pt_frag_refcount; /* 32 4= */ }; /* 32 8 *= / spinlock_t ptl; /* 40 72 *= / }; /* 8 104 *= / #if ALLOC_SPLIT_PTLOCKS spinlock_t *ptl; #else spinlock_t ptl; #endif something has disabled ALLOC_SPLIT_PTLOCKS when it ought to be enabled. #if USE_SPLIT_PTE_PTLOCKS #define ALLOC_SPLIT_PTLOCKS (SPINLOCK_SIZE > BITS_PER_LONG/8) #else #define ALLOC_SPLIT_PTLOCKS 0 #endif Oh. This is Anshuman's fault. commit 9b8a39056e2472592a5e5897987387f43038b8ba Author: Anshuman Khandual Date: Tue May 11 15:06:01 2021 +1000 mm/thp: make ALLOC_SPLIT_PTLOCKS dependent on USE_SPLIT_PTE_PTLOCKS