From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3D9AFC433ED for ; Fri, 14 May 2021 11:55:06 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id D76C26145B for ; Fri, 14 May 2021 11:55:05 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D76C26145B Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 4CFD76B0036; Fri, 14 May 2021 07:55:05 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 480076B006E; Fri, 14 May 2021 07:55:05 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 320336B0070; Fri, 14 May 2021 07:55:05 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0246.hostedemail.com [216.40.44.246]) by kanga.kvack.org (Postfix) with ESMTP id 0457B6B0036 for ; Fri, 14 May 2021 07:55:04 -0400 (EDT) Received: from smtpin25.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 98D1B6105 for ; Fri, 14 May 2021 11:55:04 +0000 (UTC) X-FDA: 78139680528.25.C1D53EB Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) by imf30.hostedemail.com (Postfix) with ESMTP id D26E9E0001B2 for ; Fri, 14 May 2021 11:55:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=n2JbRGWNEA370w8zAVffROcBjetH7P2OexCk1hMxyV8=; b=bl6Uz0GraV8CDcLOMtkK29QPC1 QGTey8qSWuEdMXbsMn0grslnDO6nHdHC2GFjGP1+V7VaSTAUvHnNRpJSJrKFILi25wN1+kEguFg97 nQPnJXhF0OLl4f/e5VTFVA5x7hWetxIUvJKhZ1xiyBBuge0IdJ94cSX71imVK9HbZOuS9aHN5Kbtu wd2r/2MVt2A/vIiPS+ob4y7NlqXRV81gzswaNIwEzYDLMuEsOKeYu37yUStl/BhdP0ue8SBOQfDDx 7CFZMq7d+Q0GW76DVu1C7QKJB60+G6LQVdrnCllm8xBYjMDZCLXRjrqB2VD1J8U37ebkFQZHq3tHt Qbbvqo2A==; Received: from j217100.upc-j.chello.nl ([24.132.217.100] helo=noisy.programming.kicks-ass.net) by desiato.infradead.org with esmtpsa (Exim 4.94 #2 (Red Hat Linux)) id 1lhWP8-007yfY-0e; Fri, 14 May 2021 11:54:54 +0000 Received: from hirez.programming.kicks-ass.net (hirez.programming.kicks-ass.net [192.168.1.225]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (Client did not present a certificate) by noisy.programming.kicks-ass.net (Postfix) with ESMTPS id 2015730022A; Fri, 14 May 2021 13:54:53 +0200 (CEST) Received: by hirez.programming.kicks-ass.net (Postfix, from userid 1000) id 0553620829F97; Fri, 14 May 2021 13:54:52 +0200 (CEST) Date: Fri, 14 May 2021 13:54:52 +0200 From: Peter Zijlstra To: Liam Howlett Cc: "linux-mm@kvack.org" , "linux-kernel@vger.kernel.org" , Andrew Morton , Song Liu , Davidlohr Bueso , "Paul E . McKenney" , Matthew Wilcox , Laurent Dufour , David Rientjes , Axel Rasmussen , Suren Baghdasaryan , Vlastimil Babka , Rik van Riel , Michel Lespinasse Subject: Re: [PATCH 26/94] Maple Tree: Add new data structure Message-ID: References: <20210428153542.2814175-1-Liam.Howlett@Oracle.com> <20210428153542.2814175-27-Liam.Howlett@Oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210428153542.2814175-27-Liam.Howlett@Oracle.com> X-Rspamd-Queue-Id: D26E9E0001B2 Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=infradead.org header.s=desiato.20200630 header.b=bl6Uz0Gr; dmarc=none; spf=none (imf30.hostedemail.com: domain of peterz@infradead.org has no SPF policy when checking 90.155.92.199) smtp.mailfrom=peterz@infradead.org X-Rspamd-Server: rspam03 X-Stat-Signature: xheyuerm8ba9c4qt4jqtrtrokm3puq4m X-HE-Tag: 1620993302-442328 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Apr 28, 2021 at 03:36:02PM +0000, Liam Howlett wrote: > +static inline void mas_set_range(struct ma_state *mas, unsigned long start, > + unsigned long last) > +{ > + mas->index = start; > + mas->last = last; > + mas->node = MAS_START; > +} Your indenting went wobbly :-) Also, I personally prefer this style: static inline void mas_set_range(struct ma_state *mas, unsigned long start, unsigned long last) { mas->index = start; mas->last = last; mas->node = MAS_START; } And I'm a big proponent of at the very least keeping line-breaks aligned to '(', like: static inline void mas_set_range(struct ma_state *mas, unsigned long start, unsigned long last) { mas->index = start; mas->last = last; mas->node = MAS_START; } Which you can get vim to do by using: set cino=(0:0