From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F0E06C433ED for ; Fri, 14 May 2021 12:18:35 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 880E96144C for ; Fri, 14 May 2021 12:18:35 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 880E96144C Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 1E4436B0036; Fri, 14 May 2021 08:18:35 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 182386B006E; Fri, 14 May 2021 08:18:35 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 021636B0070; Fri, 14 May 2021 08:18:34 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0068.hostedemail.com [216.40.44.68]) by kanga.kvack.org (Postfix) with ESMTP id C5E486B0036 for ; Fri, 14 May 2021 08:18:34 -0400 (EDT) Received: from smtpin13.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 5C7DF99B3 for ; Fri, 14 May 2021 12:18:34 +0000 (UTC) X-FDA: 78139739748.13.F2480D6 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf27.hostedemail.com (Postfix) with ESMTP id 88A1880192F0 for ; Fri, 14 May 2021 12:18:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=4j6NAUINOO2iRcafPhFqTSB4UiIS5qPdm2W1b5MCFfo=; b=v/Btch9J/kbExn3R8m5BlhEMgM nEleQOuvkkgT8ka60BvyzSgCv6r4VrATcDO1UYG3G0S/DPt/GeMiF8m/jJLLnw5b5XNFjYfaDl8Ii GbMcgQeFIzeKIH+gn+Zmye9+ozbfTNtehdl7O6fRX6PUXlpLr/hU3FfObkJZjSCYIkvteTMTw1tfs KSWOwW+F/FVxdEasLWPSqRRatNsRgzoWQXI9TKvyOH4J6RIg5L8stpRzhcxk+8e5YUGtLclA0juhB USvUpAkMPSWX5tcBOmHbskfCMv5YzrQuUEvSG9PP7y2wmECHI66QP8frqj+RHkS6ETc6qTkkYrjEd gtslY/5g==; Received: from j217100.upc-j.chello.nl ([24.132.217.100] helo=noisy.programming.kicks-ass.net) by casper.infradead.org with esmtpsa (Exim 4.94 #2 (Red Hat Linux)) id 1lhWlL-00ALqZ-0H; Fri, 14 May 2021 12:18:00 +0000 Received: from hirez.programming.kicks-ass.net (hirez.programming.kicks-ass.net [192.168.1.225]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (Client did not present a certificate) by noisy.programming.kicks-ass.net (Postfix) with ESMTPS id C803E30022A; Fri, 14 May 2021 14:17:49 +0200 (CEST) Received: by hirez.programming.kicks-ass.net (Postfix, from userid 1000) id AEE0820D74F30; Fri, 14 May 2021 14:17:49 +0200 (CEST) Date: Fri, 14 May 2021 14:17:49 +0200 From: Peter Zijlstra To: Liam Howlett Cc: "maple-tree@lists.infradead.org" , "linux-mm@kvack.org" , "linux-kernel@vger.kernel.org" , Andrew Morton , Song Liu , Davidlohr Bueso , "Paul E . McKenney" , Matthew Wilcox , Laurent Dufour , David Rientjes , Axel Rasmussen , Suren Baghdasaryan , Vlastimil Babka , Rik van Riel , Michel Lespinasse Subject: Re: [PATCH 26/94] Maple Tree: Add new data structure Message-ID: References: <20210428153542.2814175-1-Liam.Howlett@Oracle.com> <20210428153542.2814175-27-Liam.Howlett@Oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210428153542.2814175-27-Liam.Howlett@Oracle.com> X-Rspamd-Queue-Id: 88A1880192F0 Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b="v/Btch9J"; spf=none (imf27.hostedemail.com: domain of peterz@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=peterz@infradead.org; dmarc=none X-Rspamd-Server: rspam04 X-Stat-Signature: 6uwcfowqjg8pjadkws6ty3n53goqj76t X-HE-Tag: 1620994712-129522 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Apr 28, 2021 at 03:36:02PM +0000, Liam Howlett wrote: > +static void mas_set_height(struct ma_state *mas) > +{ > + unsigned int new_flags = mas->tree->ma_flags; > + > + new_flags &= ~MAPLE_HEIGHT_MASK; > + new_flags |= mas->depth << MAPLE_HEIGHT_OFFSET; > + mas->tree->ma_flags = new_flags; > +} This goes sideways when mas->depth is too large; I didn't quickly see an assertion / range checks for mas->depth anywhere.