From: Dennis Zhou <dennis@kernel.org>
To: Wei Yongjun <weiyongjun1@huawei.com>
Cc: Tejun Heo <tj@kernel.org>, Christoph Lameter <cl@linux.com>,
Andrew Morton <akpm@linux-foundation.org>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
kernel-janitors@vger.kernel.org, Hulk Robot <hulkci@huawei.com>
Subject: Re: [PATCH -next] percpu: make symbol 'pcpu_free_slot' static
Date: Fri, 14 May 2021 21:00:35 +0000 [thread overview]
Message-ID: <YJ7k8zWAOoDA5i3t@google.com> (raw)
In-Reply-To: <20210514063952.3240527-1-weiyongjun1@huawei.com>
Hello,
On Fri, May 14, 2021 at 06:39:52AM +0000, Wei Yongjun wrote:
> The sparse tool complains as follows:
>
> mm/percpu.c:138:5: warning:
> symbol 'pcpu_free_slot' was not declared. Should it be static?
>
> This symbol is not used outside of percpu.c, so marks it static.
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
> ---
> mm/percpu.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/mm/percpu.c b/mm/percpu.c
> index a257c3efdf18..73c249f3b6a3 100644
> --- a/mm/percpu.c
> +++ b/mm/percpu.c
> @@ -135,7 +135,7 @@ static int pcpu_unit_size __ro_after_init;
> static int pcpu_nr_units __ro_after_init;
> static int pcpu_atom_size __ro_after_init;
> int pcpu_nr_slots __ro_after_init;
> -int pcpu_free_slot __ro_after_init;
> +static int pcpu_free_slot __ro_after_init;
> int pcpu_sidelined_slot __ro_after_init;
> int pcpu_to_depopulate_slot __ro_after_init;
> static size_t pcpu_chunk_struct_size __ro_after_init;
>
Ah that's my bad. I've applied this for-5.14.
Thanks,
Dennis
prev parent reply other threads:[~2021-05-14 21:00 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-14 6:39 [PATCH -next] percpu: make symbol 'pcpu_free_slot' static Wei Yongjun
2021-05-14 21:00 ` Dennis Zhou [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YJ7k8zWAOoDA5i3t@google.com \
--to=dennis@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=cl@linux.com \
--cc=hulkci@huawei.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=tj@kernel.org \
--cc=weiyongjun1@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).