From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 97EF7C433B4 for ; Mon, 10 May 2021 15:45:35 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 0883B611CE for ; Mon, 10 May 2021 15:45:34 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0883B611CE Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 60AFD6B0073; Mon, 10 May 2021 11:45:34 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 591F86B0074; Mon, 10 May 2021 11:45:34 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3E3B36B0078; Mon, 10 May 2021 11:45:34 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0178.hostedemail.com [216.40.44.178]) by kanga.kvack.org (Postfix) with ESMTP id 21ABF6B0073 for ; Mon, 10 May 2021 11:45:34 -0400 (EDT) Received: from smtpin37.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id D33CB5821 for ; Mon, 10 May 2021 15:45:33 +0000 (UTC) X-FDA: 78125746146.37.FE3600D Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf07.hostedemail.com (Postfix) with ESMTP id 16618A0009EE for ; Mon, 10 May 2021 15:45:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=Flo9l/jYDkRKwx0f14g3k6U8nqbHT13bVIHshVunBVM=; b=gujTuZIsMzIdK8d25Kl1FvLEEb nlA8vBvFfU8SvSQhTMVA2CmdHJffyObUCHMeV+VywGbf0oHAjVxz9s4/F9Eg03L50I8ud0n8GLdFn xkss71KzHy1YbzOB8Pz69/AqtkgkDugtVNPhcKce4+WXDxqIv1IL9BG/8NdBbwmV+Pz5IfdwVHXXS u4xcakk04MW9kx0dZ3CHLm9e37hqI08KFVG0BM32h7oajOtKIb25WDP5dYUYrsSk0iKO/SvGsIqq2 Xr5biMYWvey86Dp/R5reHBkDbLw/ZAHvsm20rwi1b+IgVIaK064zKvdvuIyNeVs3OCXefoNkOuik5 +8q+vX0Q==; Received: from willy by casper.infradead.org with local (Exim 4.94 #2 (Red Hat Linux)) id 1lg84n-006KCh-T2; Mon, 10 May 2021 15:44:25 +0000 Date: Mon, 10 May 2021 16:44:09 +0100 From: Matthew Wilcox To: Hyeonggon Yoo <42.hyeyoo@gmail.com> Cc: Vlastimil Babka , cl@linux.com, penberg@kernel.org, rientjes@google.com, iamjoonsoo.kim@lge.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] mm: kmalloc_index: make compiler break when size is not supported Message-ID: References: <20210508221328.7338-1-42.hyeyoo@gmail.com> <20210510135857.GA3594@hyeyoo> <9d0ffe49-a2e2-6c81-377b-4c8d2147dff8@suse.cz> <20210510150230.GA74915@hyeyoo> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210510150230.GA74915@hyeyoo> X-Rspamd-Server: rspam01 Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=gujTuZIs; spf=none (imf07.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none X-Stat-Signature: f88zrzugitribkyurpncapyrqon71qte X-Rspamd-Queue-Id: 16618A0009EE Received-SPF: none (infradead.org>: No applicable sender policy available) receiver=imf07; identity=mailfrom; envelope-from=""; helo=casper.infradead.org; client-ip=90.155.50.34 X-HE-DKIM-Result: pass/pass X-HE-Tag: 1620661529-368629 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, May 11, 2021 at 12:02:30AM +0900, Hyeonggon Yoo wrote: > @@ -382,8 +385,8 @@ static __always_inline unsigned int kmalloc_index(size_t size) > if (size <= 8 * 1024 * 1024) return 23; > if (size <= 16 * 1024 * 1024) return 24; > if (size <= 32 * 1024 * 1024) return 25; > - if (size <= 64 * 1024 * 1024) return 26; > - BUG(); > + > + BUILD_BUG_ON_MSG(1, "unexpected size in kmalloc_index()"); we're being encouraged to use static_assert() these days. https://en.cppreference.com/w/c/language/_Static_assert