From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F32C4C433ED for ; Wed, 12 May 2021 03:51:50 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 7BE3E6147F for ; Wed, 12 May 2021 03:51:50 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7BE3E6147F Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id E37536B0036; Tue, 11 May 2021 23:51:49 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id DC0156B006E; Tue, 11 May 2021 23:51:49 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C39416B0070; Tue, 11 May 2021 23:51:49 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0120.hostedemail.com [216.40.44.120]) by kanga.kvack.org (Postfix) with ESMTP id A3E6D6B0036 for ; Tue, 11 May 2021 23:51:49 -0400 (EDT) Received: from smtpin32.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 5B1C4181AF5D8 for ; Wed, 12 May 2021 03:51:49 +0000 (UTC) X-FDA: 78131205138.32.65BEEF9 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf18.hostedemail.com (Postfix) with ESMTP id 90DA320001D6 for ; Wed, 12 May 2021 03:51:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=aTvKpxfUjpa51UfREN7+HPOb94z389kuVFnSFnj9YgU=; b=tWukLvpVP3mWDqMnudvsVMOPTc CmanCzPaqq7vaM/1/jq6bWGBSxQ3KbDbSrx7HXFJbsmPDtkYy4Otxvki0LA5rW70CbgL2eZOF7QvP 9B7yVLaQD0Hjxcrq7IujWR/L1KaTqkAXO6A4mqboJgFywAHTN0/T0UsT26KwQwny3Ls3Q28LnABN0 B8BV0mR9rlxHn61P/4eRUggbQ3nQsnWrLywPbuJMq0PKzhrw3nVzQJlTVxJ6t9vNlpVcIDQLtjauW 6rkqQgGSKWKfH4CGfwBd2PqMSMmKJErqrtglN00r3qEjnwg4Mjl5Xp9NUTYSt3H2fxePeFZjFa00p s7nH+zzQ==; Received: from willy by casper.infradead.org with local (Exim 4.94 #2 (Red Hat Linux)) id 1lgftX-007ukN-UV; Wed, 12 May 2021 03:50:54 +0000 Date: Wed, 12 May 2021 04:50:47 +0100 From: Matthew Wilcox To: Kefeng Wang Cc: Mike Rapoport , linux-arm-kernel@lists.infradead.org, Andrew Morton , Anshuman Khandual , Ard Biesheuvel , Catalin Marinas , David Hildenbrand , Marc Zyngier , Mark Rutland , Mike Rapoport , Will Deacon , kvmarm@lists.cs.columbia.edu, linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: arm32: panic in move_freepages (Was [PATCH v2 0/4] arm64: drop pfn_valid_within() and simplify pfn_valid()) Message-ID: References: <20210421065108.1987-1-rppt@kernel.org> <9aa68d26-d736-3b75-4828-f148964eb7f0@huawei.com> <33fa74c2-f32d-f224-eb30-acdb717179ff@huawei.com> <2a1592ad-bc9d-4664-fd19-f7448a37edc0@huawei.com> <52f7d03b-7219-46bc-c62d-b976bc31ebd5@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <52f7d03b-7219-46bc-c62d-b976bc31ebd5@huawei.com> X-Rspamd-Queue-Id: 90DA320001D6 Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=tWukLvpV; dmarc=none; spf=none (imf18.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org X-Rspamd-Server: rspam03 X-Stat-Signature: bjyys5w6chdz8ns85gbpo6iebnpnqmaz Received-SPF: none (infradead.org>: No applicable sender policy available) receiver=imf18; identity=mailfrom; envelope-from=""; helo=casper.infradead.org; client-ip=90.155.50.34 X-HE-DKIM-Result: pass/pass X-HE-Tag: 1620791510-923643 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sun, Apr 25, 2021 at 03:51:56PM +0800, Kefeng Wang wrote: > we see the PC is at PageLRU, same reason like arm64 panic log, > > "PageBuddy in move_freepages returns false Then we call PageLRU, the macro > calls PF_HEAD which is compound_page() compound_page reads > page->compound_head, it is 0xffffffffffffffff, so it resturns > 0xfffffffffffffffe - and accessing this address causes crash" Oh. I posted patches to fix this back in 2018. https://lore.kernel.org/linux-mm/20180414043145.3953-6-willy@infradead.org/ and 2019. https://lore.kernel.org/linux-mm/20190501202433.GC28500@bombadil.infradead.org/ and 2020. https://lore.kernel.org/linux-mm/20200408150148.25290-6-willy@infradead.org/ Looks like it's about that time of year for me to try to fix this again.