From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 47E52C4707F for ; Thu, 27 May 2021 08:11:07 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id D53E8613C9 for ; Thu, 27 May 2021 08:11:06 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D53E8613C9 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 724706B0036; Thu, 27 May 2021 04:11:06 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 6F89C6B006E; Thu, 27 May 2021 04:11:06 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 50B9E6B0070; Thu, 27 May 2021 04:11:06 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0155.hostedemail.com [216.40.44.155]) by kanga.kvack.org (Postfix) with ESMTP id 103436B0036 for ; Thu, 27 May 2021 04:11:06 -0400 (EDT) Received: from smtpin18.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 9AF3082499A8 for ; Thu, 27 May 2021 08:11:05 +0000 (UTC) X-FDA: 78186290490.18.2070382 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf29.hostedemail.com (Postfix) with ESMTP id 49B472CA for ; Thu, 27 May 2021 08:10:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=vT74XKRQuhUfgLTtwSOq9b0Z9WdSrSMbTGF3sw2pf4s=; b=fm1v8qYSLk//NA61Wa8uZtqNSz J0lO9IAJT+GN0aRGc52FJmjtq0GlQVFkBK3NA7L44OgjOgusQSJcn3PIkC9Hu2+O7uUBe6r2H1XOz jqHxQ+ewhbQr2dJvcd47dA0aGWjkSqz6XeK2CjAFTRadU32IDtOejSZ1JNo+emJGJrn11WdFGEOL/ o+IJ1Wk+T/j1rm0NSFu6vTlYKTBbOc62eb2af4hqNzp/XbVD0iTENsCOj8xDX8QIlYAUkpEW+xnHp nOvxJilMB3cAEn/a3Pfcg6AcFLfKwRRC4L8qQ0NhtZ0+d/yEwuSzQ2S2hLTOP1ywL/49VxG1w14Py f3SLCeyQ==; Received: from hch by casper.infradead.org with local (Exim 4.94 #2 (Red Hat Linux)) id 1lmB67-005Jn6-PC; Thu, 27 May 2021 08:10:36 +0000 Date: Thu, 27 May 2021 09:10:31 +0100 From: Christoph Hellwig To: Matthew Wilcox Cc: Vlastimil Babka , akpm@linux-foundation.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Zi Yan , Christoph Hellwig , Jeff Layton Subject: Re: [PATCH v10 07/33] mm: Add folio_get Message-ID: References: <20210511214735.1836149-1-willy@infradead.org> <20210511214735.1836149-8-willy@infradead.org> <88a265ab-9ecd-18b7-c150-517a5c2e5041@suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-SRS-Rewrite: SMTP reverse-path rewritten from by casper.infradead.org. See http://www.infradead.org/rpr.html Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=fm1v8qYS; dmarc=none; spf=none (imf29.hostedemail.com: domain of BATV@casper.srs.infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=BATV@casper.srs.infradead.org X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 49B472CA X-Stat-Signature: wnh9cwg1z98qiy4g7onby583darmicpk X-HE-Tag: 1622103055-592585 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, May 14, 2021 at 03:24:26PM +0100, Matthew Wilcox wrote: > On Fri, May 14, 2021 at 01:56:46PM +0200, Vlastimil Babka wrote: > > Nitpick: function names in subject should IMHO also end with (). But not a > > reason for resend all patches that don't... > > Hm, I thought it was preferred to not do that. I can fix it > easily enough when I go through and add the R-b. I hate the pointless (). Some maintainers insist on it. No matter what you do you'll make some folks happy and others not.