From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id ADD83C4707F for ; Thu, 27 May 2021 08:20:41 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 71743613AA for ; Thu, 27 May 2021 08:20:41 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 71743613AA Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 776DB6B006E; Thu, 27 May 2021 04:20:40 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 6F7CF6B0070; Thu, 27 May 2021 04:20:40 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 28E036B0071; Thu, 27 May 2021 04:20:40 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0236.hostedemail.com [216.40.44.236]) by kanga.kvack.org (Postfix) with ESMTP id DD38D6B006E for ; Thu, 27 May 2021 04:20:39 -0400 (EDT) Received: from smtpin14.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 7E5046139 for ; Thu, 27 May 2021 08:20:39 +0000 (UTC) X-FDA: 78186314598.14.B633920 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf24.hostedemail.com (Postfix) with ESMTP id B976AA0000FF for ; Thu, 27 May 2021 08:20:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=g49sK0BaWO1ncZGcxG01VvzKJZgdLBdmNCuIE34Ov5g=; b=DtdTeZ+pckjlf8fAisbFEbNNno h7l5vQCH38rZ13QRrYXGddBmR+fHXScVzLgE4C2PhfZU9pQ7stDQN5O0luHUba9UIYekGYjoe4B8U XcBITWAa23uqAC+QQGgWFbrkgSeEcwEQ6dR9htF8RTangpxR+z1XwTYvAub7LaWKkGKi8ZB0DO6Zs wVY6xuaTBzNjjjxoqZf2j2pQpZcGQnu9sBnWuLQTeaRz57a57y97IDMHWwErtBvQEhcS45F0W/MvV y5if6Qr1sRji/4ib1oRK4MJ2LI8FH/EYnLtG3+2BsyJLNor19X0eE80ZZnPaQGwBKV6VFTG5deXFT HJ72TUWg==; Received: from hch by casper.infradead.org with local (Exim 4.94 #2 (Red Hat Linux)) id 1lmBFH-005KEM-TH; Thu, 27 May 2021 08:20:00 +0000 Date: Thu, 27 May 2021 09:19:59 +0100 From: Christoph Hellwig To: "Matthew Wilcox (Oracle)" Cc: akpm@linux-foundation.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v10 24/33] mm/swap: Add folio_rotate_reclaimable Message-ID: References: <20210511214735.1836149-1-willy@infradead.org> <20210511214735.1836149-25-willy@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210511214735.1836149-25-willy@infradead.org> X-SRS-Rewrite: SMTP reverse-path rewritten from by casper.infradead.org. See http://www.infradead.org/rpr.html Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=DtdTeZ+p; spf=none (imf24.hostedemail.com: domain of BATV@casper.srs.infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=BATV@casper.srs.infradead.org; dmarc=none X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: B976AA0000FF X-Stat-Signature: iy56jmua1n1h9o4mkot9aragwppzu7y1 X-HE-Tag: 1622103631-545182 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, May 11, 2021 at 10:47:26PM +0100, Matthew Wilcox (Oracle) wrote: > Move the declaration into mm/internal.h and rename > rotate_reclaimable_page() to folio_rotate_reclaimable(). This eliminates > all five of the calls to compound_head() in this function, saving 75 bytes > at the cost of adding 14 bytes to its one caller, end_page_writeback(). > Net 61 bytes savings. > > Signed-off-by: Matthew Wilcox (Oracle) Looks good, Reviewed-by: Christoph Hellwig