From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B6C91C47089 for ; Thu, 27 May 2021 08:24:23 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 5DA0A61248 for ; Thu, 27 May 2021 08:24:23 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5DA0A61248 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id E174C6B0072; Thu, 27 May 2021 04:24:22 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id DC77F6B0073; Thu, 27 May 2021 04:24:22 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C68606B0074; Thu, 27 May 2021 04:24:22 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0063.hostedemail.com [216.40.44.63]) by kanga.kvack.org (Postfix) with ESMTP id 943AB6B0072 for ; Thu, 27 May 2021 04:24:22 -0400 (EDT) Received: from smtpin03.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 327FF8249980 for ; Thu, 27 May 2021 08:24:22 +0000 (UTC) X-FDA: 78186323964.03.2BE2BEC Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf11.hostedemail.com (Postfix) with ESMTP id 6665220007D8 for ; Thu, 27 May 2021 08:24:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=E1xzz5XBeK0+jmx6JpZ8HhcM7SbFDuyJ66vXDC0KF7M=; b=Uj4Kq1zZ5pDNLxl6PM+aQoy95h 8gqeAfIHKEStURdKJcD5atHDTQu9KEgbzzv48pJhgcH91E29vOHHXaRWtWkyRNzPMvKa144vjf/QG 7lL6Yi++t2fP2WPuKwSHHUup6VKFU8UaJZV4XEsbisML5LeGfvyLRpdntKyQaqhMB0aW77GDFqLGe 7qgAeIomyX3su2CX0cwRAsLXpxGvnHDdRwV2XkFVph8t0JIh8QtSCoADRxQwGj8KOmCFCdLkO+Edd w+18jW7n2WMzmXSV9rMeAkHKHp6J1utY6QjpcUhLEfhwmK2852O3IBRZMEqs5pUArksh8YKyp4ioC aq0fl8Qw==; Received: from hch by casper.infradead.org with local (Exim 4.94 #2 (Red Hat Linux)) id 1lmBJ5-005KY4-37; Thu, 27 May 2021 08:23:57 +0000 Date: Thu, 27 May 2021 09:23:55 +0100 From: Christoph Hellwig To: "Matthew Wilcox (Oracle)" Cc: akpm@linux-foundation.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v10 32/33] fs/netfs: Add folio fscache functions Message-ID: References: <20210511214735.1836149-1-willy@infradead.org> <20210511214735.1836149-33-willy@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210511214735.1836149-33-willy@infradead.org> X-SRS-Rewrite: SMTP reverse-path rewritten from by casper.infradead.org. See http://www.infradead.org/rpr.html Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=Uj4Kq1zZ; dmarc=none; spf=none (imf11.hostedemail.com: domain of BATV@casper.srs.infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=BATV@casper.srs.infradead.org X-Stat-Signature: sbro8bfeuop3rrxmimbdfw7qs7ec5jgb X-Rspamd-Queue-Id: 6665220007D8 X-Rspamd-Server: rspam02 X-HE-Tag: 1622103852-619459 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, May 11, 2021 at 10:47:34PM +0100, Matthew Wilcox (Oracle) wrote: > Match the page writeback functions by adding > folio_start_fscache(), folio_end_fscache(), folio_wait_fscache() and > folio_wait_fscache_killable(). Also rewrite the kernel-doc to describe > when to use the function rather than what the function does, and include > the kernel-doc in the appropriate rst file. > > Signed-off-by: Matthew Wilcox (Oracle) Looks fine, but doesn't actually seem to be needed for this series. I'd move it closer to actual users of the new helpers. Otherwise: Reviewed-by: Christoph Hellwig