From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id ECF0AC43460 for ; Tue, 18 May 2021 13:36:23 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 909DE610E9 for ; Tue, 18 May 2021 13:36:23 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 909DE610E9 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 0B4158E002A; Tue, 18 May 2021 09:36:23 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 064D68E0023; Tue, 18 May 2021 09:36:23 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E47C88E002A; Tue, 18 May 2021 09:36:22 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0101.hostedemail.com [216.40.44.101]) by kanga.kvack.org (Postfix) with ESMTP id B4BC78E0023 for ; Tue, 18 May 2021 09:36:22 -0400 (EDT) Received: from smtpin23.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 40969824999B for ; Tue, 18 May 2021 13:36:22 +0000 (UTC) X-FDA: 78154451004.23.33AEABA Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf01.hostedemail.com (Postfix) with ESMTP id 31105500152F for ; Tue, 18 May 2021 13:36:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=H//by0SeCqYqsx1Zt0OwZMGgLE8Rb7GwOiwBk+sMcPU=; b=rcQd2jIGLy0lT7aYMqYer0JaB4 lQ3D1sem6bs+9gVom1VdpOIkD38TqglN3KZPOf+c8h/J+drqthK8VNRZxCQvoMqSO+LDN83QN+nfa 58cV38hz6xmzFUtnVnh2sZl/A9X0wt1KP+ZAhgLm7z8A3R+V7fTw8EgvT2zpKQuZCdakPpRHxFtHa PSNle7Zash+tZyQAqOG3Z0HAAsp2QyVGJ0bjqXEpKTAB3Fo7qRQSnbZi0Kk5YF6KevefqOR3DULIR K6yaaPV7x/MFqNj03ZuLyTpSXM4a/xvSIrjJfqp5NGU42q0e/T2w8sZoimZpsnjGQ/8v+yfAIL5t5 G9JErTlA==; Received: from willy by casper.infradead.org with local (Exim 4.94 #2 (Red Hat Linux)) id 1lizsw-00E1Hd-IJ; Tue, 18 May 2021 13:35:54 +0000 Date: Tue, 18 May 2021 14:35:46 +0100 From: Matthew Wilcox To: Vlastimil Babka Cc: akpm@linux-foundation.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Christoph Hellwig , Jeff Layton Subject: Re: [PATCH v10 22/33] mm/filemap: Add __folio_lock_or_retry Message-ID: References: <20210511214735.1836149-1-willy@infradead.org> <20210511214735.1836149-23-willy@infradead.org> <76184de4-4ab9-0f04-ab37-8637f4b22566@suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <76184de4-4ab9-0f04-ab37-8637f4b22566@suse.cz> Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=rcQd2jIG; dmarc=none; spf=none (imf01.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 31105500152F X-Stat-Signature: 7qzsya3p6g9uaen53apyobtsp44rdjzp X-HE-Tag: 1621344979-438375 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, May 18, 2021 at 12:38:46PM +0200, Vlastimil Babka wrote: > > -int __lock_page_or_retry(struct page *page, struct mm_struct *mm, > > +int __folio_lock_or_retry(struct folio *folio, struct mm_struct *mm, > > unsigned int flags) > > { > > - struct folio *folio = page_folio(page); > > - > > if (fault_flag_allow_retry_first(flags)) { > > /* > > * CAUTION! In this case, mmap_lock is not released > > A bit later in this branch, 'page' is accessed, but it no longer exists. And > thus as expected, it doesn't compile. Assuming it's fixed later, but > bisectability etc... Oops. Thanks for catching that; I've reordered this patch and the folio_wait_locked() patch, which makes the entire problem go away.