From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4B321C433ED for ; Tue, 18 May 2021 13:56:50 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id EB8526117A for ; Tue, 18 May 2021 13:56:49 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org EB8526117A Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 77ACC8E0031; Tue, 18 May 2021 09:56:49 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 72A388E002F; Tue, 18 May 2021 09:56:49 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5B6848E0031; Tue, 18 May 2021 09:56:49 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0241.hostedemail.com [216.40.44.241]) by kanga.kvack.org (Postfix) with ESMTP id 269258E002F for ; Tue, 18 May 2021 09:56:49 -0400 (EDT) Received: from smtpin17.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id B6D24AF8F for ; Tue, 18 May 2021 13:56:48 +0000 (UTC) X-FDA: 78154502496.17.2A83123 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf02.hostedemail.com (Postfix) with ESMTP id 1670C40002F1 for ; Tue, 18 May 2021 13:56:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=s36KeDCQTjjdbNaJPGBotFdZABcZ6K5ODWo6m4Tm+Tk=; b=GqjuVupZZdr7ohq92vjExxWC+g KjLHczLGtrzn+kflb9uaLoM58CsWOaU3r7Cx0z2WF6g6sEbXwdRMoYmqwifZW78vP/4lDjS+ECaLR Dzu25YK8li9B3wL9Se6+DF+yIeajG9fEz9oJyjDPVs4mj7tRQZx4+8iaEJlgHhvFM6LBlh9TQCwMm dYMEgmU5O/ZFrjzBw2orErotQStBgt6pdPxwu0TnxEZi5fnBiI//9W6rKbrUe3U+DsakXXYUP0E+1 l64I2NE9EinIchynh3B85IqlbRungbuGsGaYTe+xMsmTyoWPlHFOBkQ/6itoeELUSGFrNjncNtKJ5 eEeTIijA==; Received: from willy by casper.infradead.org with local (Exim 4.94 #2 (Red Hat Linux)) id 1lj0Bu-00E28c-OY; Tue, 18 May 2021 13:56:05 +0000 Date: Tue, 18 May 2021 14:55:22 +0100 From: Matthew Wilcox To: Vlastimil Babka Cc: akpm@linux-foundation.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Christoph Hellwig , Jeff Layton Subject: Re: [PATCH v10 27/33] mm/writeback: Add folio_wait_stable Message-ID: References: <20210511214735.1836149-1-willy@infradead.org> <20210511214735.1836149-28-willy@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=GqjuVupZ; dmarc=none; spf=none (imf02.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org X-Stat-Signature: 5pzg66ks8nf1zfxiaitt6jzqt5h5whh9 X-Rspamd-Queue-Id: 1670C40002F1 X-Rspamd-Server: rspam02 X-HE-Tag: 1621346205-782071 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, May 18, 2021 at 01:42:04PM +0200, Vlastimil Babka wrote: > On 5/11/21 11:47 PM, Matthew Wilcox (Oracle) wrote: > > Move wait_for_stable_page() into the folio compatibility file. > > folio_wait_stable() avoids a call to compound_head() and is 14 bytes > > smaller than wait_for_stable_page() was. The net text size grows by 24 > > bytes as a result of this patch. > > > > Signed-off-by: Matthew Wilcox (Oracle) > > Reviewed-by: Christoph Hellwig > > Acked-by: Jeff Layton > > Acked-by: Vlastimil Babka > > This seems to remove last user of thp_head(). Remove it as obsolete? Good catch! I'll squash that in. We're down to just one user of thp_order in my tree ...