From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0E44DC433ED for ; Thu, 20 May 2021 16:30:23 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 7DCFF60FD9 for ; Thu, 20 May 2021 16:30:22 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7DCFF60FD9 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 966EE6B00D1; Thu, 20 May 2021 12:30:21 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8F0176B00D2; Thu, 20 May 2021 12:30:21 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 742436B00D3; Thu, 20 May 2021 12:30:21 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0239.hostedemail.com [216.40.44.239]) by kanga.kvack.org (Postfix) with ESMTP id 35F816B00D1 for ; Thu, 20 May 2021 12:30:21 -0400 (EDT) Received: from smtpin15.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id BDEAA10F42 for ; Thu, 20 May 2021 16:30:20 +0000 (UTC) X-FDA: 78162147000.15.2B31D90 Received: from mail-qk1-f173.google.com (mail-qk1-f173.google.com [209.85.222.173]) by imf27.hostedemail.com (Postfix) with ESMTP id 7827B8019133 for ; Thu, 20 May 2021 16:30:18 +0000 (UTC) Received: by mail-qk1-f173.google.com with SMTP id o27so16756645qkj.9 for ; Thu, 20 May 2021 09:30:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=3W+WKCOZfAqXxcanQdJX+E4VIil1GeWKxxWHUOqsnD4=; b=HAbBW113TuLa9uF4nGtlHtdoyguK0a0XR8RiCgHJn6OOfAVrEndlerGb9lojxQQU46 L+JMqEeBn3zvbZm1g3i1qMk6dF88k2K3E6YwAhiwWSxWq013UYHS81e566F87A6jm0rx WswXOtpOOkAqOcBcEbFJrkHq5CNCzz3oc9WcSnT6xfB+69zbr/as/cRSTLBjCRqARdwH b8MuzNtkv872KFOL3l/iZSxYhK7ZbCeb1gs2OE07mDuVVOtkBRsm6yENj/gm1zYhav2y YDsyfqXvkaPzhNMJ8Q2cKHPL6NsH2AklMxth7IQ0ZwikcS1FAOEJIjZXpUT+4BYm9Nbi 1Q2A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition :content-transfer-encoding:in-reply-to; bh=3W+WKCOZfAqXxcanQdJX+E4VIil1GeWKxxWHUOqsnD4=; b=b7XN6Y4RslgHUW4rUnaTZCy+W2VNhvb2brbW0IeNZa0pVVi/jqzj0QEy0vDq9Bvyid RYVmSNiCUaM3gPzzS4Xriqug4wgAKJVevGHT6+VvP0n2J58HX2ayBJhmxhS5M50nuHaC tzEB86nU4YXph2VdF3r8yz68rdnHMLE0WgVbEEwthSK+D0Lacl+5tP2qGssAfrNgY2I1 SnYE5/0tkxJa8SDMSGxl68D2QlmiLte/XfHkpeROI0xE8Y40ePer4SJoiQgckVZvt6KP 28vCEANiWs4VU3kOna48npRc+5KjYlurT42kDu5HZUN54TGEsF3gcLN2Lf4zjpdTIaz1 +hoA== X-Gm-Message-State: AOAM530E1LjdYSW9lm1MQeoMczxMYrLUXFhn/bl9sYHVlDs2O2GXnuko cQGYfRBP6lDl9Ajf+YlJpPU= X-Google-Smtp-Source: ABdhPJx9lJDvWGuOPcMvZ/rfOceGpfyiWsJDD9YtW7iPj7j3dfO07FvRecvEo4/GqqOgyg3OBb0xcg== X-Received: by 2002:a37:a254:: with SMTP id l81mr5855956qke.175.1621528219596; Thu, 20 May 2021 09:30:19 -0700 (PDT) Received: from localhost (dhcp-6c-ae-f6-dc-d8-61.cpe.echoes.net. [199.96.183.179]) by smtp.gmail.com with ESMTPSA id f16sm2151636qth.79.2021.05.20.09.30.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 20 May 2021 09:30:19 -0700 (PDT) Date: Thu, 20 May 2021 12:30:18 -0400 From: Tejun Heo To: Shakeel Butt Cc: Zefan Li , Johannes Weiner , shy828301@gmail.com, junichi.nomura@nec.com, Andrew Morton , cgroups@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] cgroup: disable controllers at parse time Message-ID: References: <20210512201946.2949351-1-shakeelb@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20210512201946.2949351-1-shakeelb@google.com> Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=gmail.com header.s=20161025 header.b=HAbBW113; spf=pass (imf27.hostedemail.com: domain of htejun@gmail.com designates 209.85.222.173 as permitted sender) smtp.mailfrom=htejun@gmail.com; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=kernel.org (policy=none) X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: 7827B8019133 X-Stat-Signature: c8wzabo9wxxyo5718j4mhqmegbwtouh8 X-HE-Tag: 1621528218-601653 Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, May 12, 2021 at 01:19:46PM -0700, Shakeel Butt wrote: > This patch effectively reverts the commit a3e72739b7a7 ("cgroup: fix > too early usage of static_branch_disable()"). The commit 6041186a3258 > ("init: initialize jump labels before command line option parsing") has > moved the jump_label_init() before parse_args() which has made the > commit a3e72739b7a7 unnecessary. On the other hand there are > consequences of disabling the controllers later as there are subsystems > doing the controller checks for different decisions. One such incident > is reported [1] regarding the memory controller and its impact on memor= y > reclaim code. >=20 > [1] https://lore.kernel.org/linux-mm/921e53f3-4b13-aab8-4a9e-e83ff15371= e4@nec.com >=20 > Signed-off-by: Shakeel Butt > Reported-by: NOMURA JUNICHI(=E9=87=8E=E6=9D=91=E3=80=80=E6=B7=B3=E4=B8=80= ) Applied to cgroup/for-5.13-fixes. Thanks. --=20 tejun