From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7095FC47092 for ; Tue, 1 Jun 2021 14:10:39 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id D8D2C613B9 for ; Tue, 1 Jun 2021 14:10:38 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D8D2C613B9 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ffwll.ch Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 5FEA06B006E; Tue, 1 Jun 2021 10:10:38 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5AE8D6B0071; Tue, 1 Jun 2021 10:10:38 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 401416B0072; Tue, 1 Jun 2021 10:10:38 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 0EA216B006E for ; Tue, 1 Jun 2021 10:10:38 -0400 (EDT) Received: from smtpin36.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 84E06181AC9B6 for ; Tue, 1 Jun 2021 14:10:37 +0000 (UTC) X-FDA: 78205340514.36.2E7BBBD Received: from mail-wm1-f48.google.com (mail-wm1-f48.google.com [209.85.128.48]) by imf18.hostedemail.com (Postfix) with ESMTP id 5A98720010A5 for ; Tue, 1 Jun 2021 14:10:25 +0000 (UTC) Received: by mail-wm1-f48.google.com with SMTP id h5-20020a05600c3505b029019f0654f6f1so1157810wmq.0 for ; Tue, 01 Jun 2021 07:10:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ffwll.ch; s=google; h=date:from:to:cc:subject:message-id:mail-followup-to:references :mime-version:content-disposition:in-reply-to; bh=7iGbvcFYMb3tLwZvkHa1Xrgwf6I7yyg/yxMiEiySaC0=; b=ejnEUTO1DiWDFagv+Dl6hADRqW7H1logS/cF6NBmsns/CZtF8MMuELJR17uBvI2xCD ngbYDadN3KqmTc1Ga64JG9ipPURDyswvZSzXT8SgS+f7+2fznZZ5iWjaYZC/aQASeaFy V8hUWaNgJgUeTGGYdT4EErDL9mDPIsVnl+zdU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id :mail-followup-to:references:mime-version:content-disposition :in-reply-to; bh=7iGbvcFYMb3tLwZvkHa1Xrgwf6I7yyg/yxMiEiySaC0=; b=qQiIqj9WpsIdSg3eCo4NXAxTjsFQkfS/I6DWI2kL0Qs/Z2sDFEGWlHtzxFEUyZVMMq X5fx2nntlqMdzY0MHW6ujRSLKc6MPd/YbdkMaFD6GZWNijxNjTWCJ06uOPneoyfoLREh FZ247ZInux5jVS4PlIYy7P8Mb0yEW77fMNUIcFB6b4H7TopdBpJ+2lkDpHBJMMP3EN9M pGtI4UlG/IQRGr6fFr64Taty3MCRGf8uelMgBb40mhGP76U5QyTs9TqdYLVolV9hCTLj GcosWxGS2GWKFBl/7RO1fdTz2POU+Rz+f9sjH1jn5JFrFgH/DHVs3iAuLXBg6YCaENYS L+2w== X-Gm-Message-State: AOAM5314uoxy3XqcUkOnmkjJvNNm1qSQGMAaqsM4plfBrIv8EzV0ofQV A33l+XXISMGKTPIfLIXhCX3xEw== X-Google-Smtp-Source: ABdhPJxmv2iRwq3JXX8sQlPH3fi0l96M70KDiLaBl1d14VByekZy30x12OgkHti6Mr59TGXbgwmE1g== X-Received: by 2002:a05:600c:2109:: with SMTP id u9mr104645wml.7.1622556635096; Tue, 01 Jun 2021 07:10:35 -0700 (PDT) Received: from phenom.ffwll.local ([2a02:168:57f4:0:efd0:b9e5:5ae6:c2fa]) by smtp.gmail.com with ESMTPSA id f1sm4206218wrr.63.2021.06.01.07.10.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 01 Jun 2021 07:10:34 -0700 (PDT) Date: Tue, 1 Jun 2021 16:10:32 +0200 From: Daniel Vetter To: Matthew Wilcox Cc: Nathan Chancellor , linux-fbdev@vger.kernel.org, linux-mm@kvack.org, Jani Nikula , Daniel Vetter , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, William Kucharski , Ian Campbell , linux-fsdevel@vger.kernel.org, Jaya Kumar , Christoph Hellwig Subject: Re: [PATCH v2] fb_defio: Remove custom address_space_operations Message-ID: Mail-Followup-To: Matthew Wilcox , Nathan Chancellor , linux-fbdev@vger.kernel.org, linux-mm@kvack.org, Jani Nikula , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, William Kucharski , Ian Campbell , linux-fsdevel@vger.kernel.org, Jaya Kumar , Christoph Hellwig References: <20210310185530.1053320-1-willy@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Operating-System: Linux phenom 5.10.32scarlett+ Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=ffwll.ch header.s=google header.b=ejnEUTO1; dmarc=none; spf=none (imf18.hostedemail.com: domain of daniel@ffwll.ch has no SPF policy when checking 209.85.128.48) smtp.mailfrom=daniel@ffwll.ch X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 5A98720010A5 X-Stat-Signature: z3jhyoayxqerxagg7ow19a8qi5epas5o X-HE-Tag: 1622556625-324076 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sun, May 30, 2021 at 10:14:22PM +0100, Matthew Wilcox wrote: > On Sun, May 30, 2021 at 12:13:05PM -0700, Nathan Chancellor wrote: > > Hi Matthew, > > > > On Wed, Mar 10, 2021 at 06:55:30PM +0000, Matthew Wilcox (Oracle) wrote: > > > There's no need to give the page an address_space. Leaving the > > > page->mapping as NULL will cause the VM to handle set_page_dirty() > > > the same way that it's handled now, and that was the only reason to > > > set the address_space in the first place. > > > > > > Signed-off-by: Matthew Wilcox (Oracle) > > > Reviewed-by: Christoph Hellwig > > > Reviewed-by: William Kucharski > > > > This patch in mainline as commit ccf953d8f3d6 ("fb_defio: Remove custom > > address_space_operations") causes my Hyper-V based VM to no longer make > > it to a graphical environment. > > Hi Nathan, > > Thanks for the report. I sent Daniel a revert patch with a full > explanation last week, which I assume he'll queue up for a pull soon. > You can just git revert ccf953d8f3d6 for yourself until that shows up. > Sorry for the inconvenience. Uh that patch didn't get cc'ed to any list so I've ignored it. I've found it now, but lack of lore link is awkward. Can you pls resubmit with dri-devel on cc? fbdev list is dead, I don't look there. Thanks, Daniel -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch