From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 12A31C47080 for ; Tue, 1 Jun 2021 14:45:31 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 9E008613B1 for ; Tue, 1 Jun 2021 14:45:30 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9E008613B1 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chrisdown.name Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id E62D06B006C; Tue, 1 Jun 2021 10:45:29 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E13476B006E; Tue, 1 Jun 2021 10:45:29 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CB3CE6B0070; Tue, 1 Jun 2021 10:45:29 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0161.hostedemail.com [216.40.44.161]) by kanga.kvack.org (Postfix) with ESMTP id 9D7206B006C for ; Tue, 1 Jun 2021 10:45:29 -0400 (EDT) Received: from smtpin06.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 39495BF06 for ; Tue, 1 Jun 2021 14:45:29 +0000 (UTC) X-FDA: 78205428378.06.6702401 Received: from mail-wm1-f49.google.com (mail-wm1-f49.google.com [209.85.128.49]) by imf20.hostedemail.com (Postfix) with ESMTP id A13F0375 for ; Tue, 1 Jun 2021 14:45:12 +0000 (UTC) Received: by mail-wm1-f49.google.com with SMTP id f20-20020a05600c4e94b0290181f6edda88so1765803wmq.2 for ; Tue, 01 Jun 2021 07:45:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chrisdown.name; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=38OJXjf9apU3psNdgfiCp5ABcftQyKat/l3MsHmkX8Y=; b=UQ3kqRg6KLoUWQ3nlWkbFWXvc+pq1x7GyJUmyfTz8pzxAqM6/C+fUQCP4mpRpej3nc DVWQl8jdJXGSWCePj4rWYdSiLZTlgTiQedHeNTUEUAmWEoGZ/jSqfEWVeksFUMlvj99e 1Mpl/9WfbjTWMfyifeHRUjGknkITJjxkXmKY4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=38OJXjf9apU3psNdgfiCp5ABcftQyKat/l3MsHmkX8Y=; b=HrWW+A3RJWBc1kvESfkrbNXA/oQ3x8l9WvG8+R7MieOggqjCZ+K5OPvXsumEqNbUiH Fg9RXerX3AAJU/dofPI3PYCeUMdrLPCUQsO6pmSppbJnXoBYFwE2/EoxZA1+zW0sgFDe /O7Q5x7//W9tFXtm1gyDlnH6qBa8DkAP9h2fp1aTx/hBRIKAlL5/Jk9QX7vsM7TJR/LJ Y+onpNv9LZHSPP6Hv9lHz8vT4iaRPx7Jpc9bYXoPCJ4MvpfIsb6NxSu2syLCQjv2MFN/ leKaXNYhCi9KptGFXz9Y838Vj+vtG6bw9MiJC2o0nWW6NNymiEZnWBhiVKydMu/artEg 1u9Q== X-Gm-Message-State: AOAM532fg/+HeCe/f/1CUH25vwa2nx822RggSor8OgQlgoYo0zz54OEv ZB1g27CUUKkIV1TATEiFqAgD9g== X-Google-Smtp-Source: ABdhPJwrubYzbvKu9FqeNKSWy7Y87aXjCj1xwgbkZA4cGLEMSpMP0MFon25js4snpWaQjuFLxSlpVg== X-Received: by 2002:a1c:4482:: with SMTP id r124mr304068wma.42.1622558727436; Tue, 01 Jun 2021 07:45:27 -0700 (PDT) Received: from localhost ([2620:10d:c093:400::5:a819]) by smtp.gmail.com with ESMTPSA id u3sm3909643wre.76.2021.06.01.07.45.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 01 Jun 2021 07:45:26 -0700 (PDT) Date: Tue, 1 Jun 2021 15:45:26 +0100 From: Chris Down To: yulei zhang Cc: Shakeel Butt , Tejun Heo , Zefan Li , Johannes Weiner , Christian Brauner , Cgroups , benbjiang@tencent.com, Wanpeng Li , Yulei Zhang , Linux MM , Michal Hocko , Roman Gushchin Subject: Re: [RFC 0/7] Introduce memory allocation speed throttle in memcg Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: User-Agent: Mutt/2.0.7 (481f3800) (2021-05-04) X-Rspamd-Queue-Id: A13F0375 Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=chrisdown.name header.s=google header.b=UQ3kqRg6; spf=pass (imf20.hostedemail.com: domain of chris@chrisdown.name designates 209.85.128.49 as permitted sender) smtp.mailfrom=chris@chrisdown.name; dmarc=pass (policy=none) header.from=chrisdown.name X-Rspamd-Server: rspam04 X-Stat-Signature: q3xp7iah64nnoz17hswhup1rfcwhbek6 X-HE-Tag: 1622558712-580859 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: yulei zhang writes: >Yep, dynamically adjust the memory.high limits can ease the memory pressure >and postpone the global reclaim, but it can easily trigger the oom in >the cgroups, To go further on Shakeel's point, which I agree with, memory.high should _never_ result in memcg OOM. Even if the limit is breached dramatically, we don't OOM the cgroup. If you have a demonstration of memory.high resulting in cgroup-level OOM kills in recent kernels, then that needs to be provided. :-)