From: Matthew Wilcox <willy@infradead.org>
To: Liam Howlett <liam.howlett@oracle.com>
Cc: "linux-mm@kvack.org" <linux-mm@kvack.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH] mm/nommu: unexport do_munmap()
Date: Sat, 5 Jun 2021 15:36:04 +0100 [thread overview]
Message-ID: <YLuL1FLms7tnJtlx@casper.infradead.org> (raw)
In-Reply-To: <20210604194002.648037-1-Liam.Howlett@Oracle.com>
On Fri, Jun 04, 2021 at 07:40:16PM +0000, Liam Howlett wrote:
> do_munmap() does not take the mmap_write_lock(). vm_munmap() should be
> used instead.
also, do_munmap was unexported for MMU builds back in 2012 by commit
17d1587f553d.
Reviewed-by: Matthew Wilcox (Oracle) <willy@infradead.org>
> Signed-off-by: Liam R. Howlett <Liam.Howlett@Oracle.com>
> ---
> mm/nommu.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/mm/nommu.c b/mm/nommu.c
> index 0997ca38c2bd..3a93d4054810 100644
> --- a/mm/nommu.c
> +++ b/mm/nommu.c
> @@ -1501,7 +1501,6 @@ int do_munmap(struct mm_struct *mm, unsigned long start, size_t len, struct list
> delete_vma(mm, vma);
> return 0;
> }
> -EXPORT_SYMBOL(do_munmap);
>
> int vm_munmap(unsigned long addr, size_t len)
> {
> --
> 2.30.2
>
next prev parent reply other threads:[~2021-06-05 14:36 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-04 19:40 [PATCH] mm/nommu: unexport do_munmap() Liam Howlett
2021-06-05 14:36 ` Matthew Wilcox [this message]
2021-06-09 11:18 ` David Hildenbrand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YLuL1FLms7tnJtlx@casper.infradead.org \
--to=willy@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=liam.howlett@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).