From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8DE55C4743C for ; Wed, 23 Jun 2021 09:21:20 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 4029160C3F for ; Wed, 23 Jun 2021 09:21:20 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4029160C3F Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 21A756B0011; Wed, 23 Jun 2021 05:21:19 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1C9816B0036; Wed, 23 Jun 2021 05:21:19 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 06AE26B006C; Wed, 23 Jun 2021 05:21:19 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0248.hostedemail.com [216.40.44.248]) by kanga.kvack.org (Postfix) with ESMTP id C89006B0011 for ; Wed, 23 Jun 2021 05:21:18 -0400 (EDT) Received: from smtpin12.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id F36FB181C9D2E for ; Wed, 23 Jun 2021 09:21:18 +0000 (UTC) X-FDA: 78284445078.12.5DA1BC5 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf28.hostedemail.com (Postfix) with ESMTP id 6918220015DE for ; Wed, 23 Jun 2021 09:21:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=MP6Lr2ugSjgt2W5qflvD/XdOl7j43g4NIrRBMnDIbmE=; b=NOG5S5QrLtOTIwuMNFl211SEoi xHAsheCHPTX5XSj+hYWOPDYjjenbo2uh+u40l3147rX22hvAV4wLSJ04bo4+JpKNyVghn36Ul2C33 6wEUvVYOhLs2cy1kBhbcg88zIwIbMxoznBOco7SSxis5nnSQXoZN+PAUHDdzIrN9K16hJT86cSa4U D73LDUp0jkP5H8/F+IP004mhyMFLsTvAZZIQoMvKzfQEfHg9OkOlwLNExIDUYGs+CjXs0cEEj/n2u DS8A3hTL7rMP0DPPogxg7Qb95QKF5II5Wy5iRs9DrcS/5V92IEzCUqVaTkcnPKw5hGZLOCLfPVaEl X/kFqHOg==; Received: from 089144193030.atnat0002.highway.a1.net ([89.144.193.30] helo=localhost) by casper.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux)) id 1lvz3Q-00FFsr-20; Wed, 23 Jun 2021 09:20:22 +0000 Date: Wed, 23 Jun 2021 11:18:04 +0200 From: Christoph Hellwig To: "Matthew Wilcox (Oracle)" Cc: akpm@linux-foundation.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 25/46] mm/writeback: Add folio_start_writeback() Message-ID: References: <20210622121551.3398730-1-willy@infradead.org> <20210622121551.3398730-26-willy@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210622121551.3398730-26-willy@infradead.org> X-SRS-Rewrite: SMTP reverse-path rewritten from by casper.infradead.org. See http://www.infradead.org/rpr.html Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=NOG5S5Qr; dmarc=none; spf=none (imf28.hostedemail.com: domain of BATV@casper.srs.infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=BATV@casper.srs.infradead.org X-Stat-Signature: so5wmhrdkw9eubhx8ndpe51ji3k7tegr X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 6918220015DE X-HE-Tag: 1624440078-39366 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: > +static inline void set_page_writeback_keepwrite(struct page *page) > { > + folio_start_writeback_keepwrite(page_folio(page)); > } > > +static inline bool test_set_page_writeback(struct page *page) > { > + return set_page_writeback(page); > } Shouldn't these be in folio-compat.c as well? Otherwise looks good: Reviewed-by: Christoph Hellwig