From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AA200C4743C for ; Wed, 23 Jun 2021 08:05:05 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 768EE6044F for ; Wed, 23 Jun 2021 08:05:05 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 768EE6044F Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 5E1FA6B0011; Wed, 23 Jun 2021 04:05:04 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5916A6B0036; Wed, 23 Jun 2021 04:05:04 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4598F6B006C; Wed, 23 Jun 2021 04:05:04 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0238.hostedemail.com [216.40.44.238]) by kanga.kvack.org (Postfix) with ESMTP id 0C2D36B0011 for ; Wed, 23 Jun 2021 04:05:03 -0400 (EDT) Received: from smtpin08.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 4084982F4883 for ; Wed, 23 Jun 2021 08:05:04 +0000 (UTC) X-FDA: 78284252928.08.442B6F9 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf19.hostedemail.com (Postfix) with ESMTP id B983D90020EC for ; Wed, 23 Jun 2021 08:05:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=ntTcJy13D/QGMMMLSGx0pXq4BTVvCy1aoIuDiVD+hKE=; b=cR5j9Rv0gIqJF9xMrbiZ81+aub 40xBIlFdwnK4MYXt/FReoo71vYYW9FZdTJYOXEZ9vVc5VVKUWPIGTnJYclfSp5x1ScU28ODwP3otu Fpz3Rt61jEqM2S9uU5qQVieUvDW7NjFJwEVGtaBiNLPpQbwi4fdOaCh0rIUb7a1MU4XwW7khydA0Y W+l5Me7Ze4W+OQI+NHrMUCTYUCzF9GhKGCPL/6+obroM06pXdMNuvyqlkHcSUr235tlhgu3WM/CJ9 sBhxjQmvt1mfauArsHnIujKWFvW71IIWmbqNUR4BIVlo5GK05uBmWgcb2Lcv3KWNjbK5nOMr0mAfU D+Jgq4LA==; Received: from [2001:4bb8:188:3e21:6594:49:139:2b3f] (helo=localhost) by casper.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux)) id 1lvxre-00FBkl-Ly; Wed, 23 Jun 2021 08:04:09 +0000 Date: Wed, 23 Jun 2021 10:04:01 +0200 From: Christoph Hellwig To: "Matthew Wilcox (Oracle)" Cc: akpm@linux-foundation.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 08/46] mm/swap: Add folio_activate() Message-ID: References: <20210622121551.3398730-1-willy@infradead.org> <20210622121551.3398730-9-willy@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210622121551.3398730-9-willy@infradead.org> X-SRS-Rewrite: SMTP reverse-path rewritten from by casper.infradead.org. See http://www.infradead.org/rpr.html Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=cR5j9Rv0; spf=none (imf19.hostedemail.com: domain of BATV@casper.srs.infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=BATV@casper.srs.infradead.org; dmarc=none X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: B983D90020EC X-Stat-Signature: hex54gqcixhunhucyyi78k1ncswat9rm X-HE-Tag: 1624435503-83223 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Jun 22, 2021 at 01:15:13PM +0100, Matthew Wilcox (Oracle) wrote: > This replaces activate_page() and eliminates lots of calls to > compound_head(). Saves net 118 bytes of kernel text. There are still > some redundant calls to page_folio() here which will be removed when > pagevec_lru_move_fn() is converted to use folios. > > Signed-off-by: Matthew Wilcox (Oracle) Looks good, Reviewed-by: Christoph Hellwig