From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 64117C4743C for ; Wed, 23 Jun 2021 08:09:56 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 21EAB6100B for ; Wed, 23 Jun 2021 08:09:56 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 21EAB6100B Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 0AAD76B0011; Wed, 23 Jun 2021 04:09:55 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 05B3A6B0036; Wed, 23 Jun 2021 04:09:55 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E643F6B006C; Wed, 23 Jun 2021 04:09:54 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0194.hostedemail.com [216.40.44.194]) by kanga.kvack.org (Postfix) with ESMTP id B78F06B0011 for ; Wed, 23 Jun 2021 04:09:54 -0400 (EDT) Received: from smtpin23.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id D95EC23E68 for ; Wed, 23 Jun 2021 08:09:54 +0000 (UTC) X-FDA: 78284265108.23.CF7FD78 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf14.hostedemail.com (Postfix) with ESMTP id 83DA3C0007C8 for ; Wed, 23 Jun 2021 08:09:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=G2/C+g7cEjGpxRxJL0ocYil2e3AYw7EKbSAba2DuXLU=; b=E1JC7m0IvmEH4Fz1HT1DKWxjeT zxoCiQiIjhKIB6c0yorUjccChfq6Go4cOfJoi0x7yf9TroVoErhgHg38Tp1V+gh35hjuisbcAp/Nz Dj6wcbBT/nnnv8edAHt5GAXryjqRMSg6vjk5VVXLGC9xRbqN3rOHNad3Op8OFyF+RfFPgOUXcZvIQ 7q6bABrGTFM44I6k4Ib+2gwWLf1WkwirHDsi1Ezt4VySCgovI1akHTGXBsw3JFlhupcFBjEV6y5hb BsImcs/rP9rcpygb4RolH4EmeUgCuBuAATwdWQ/87vQs19VHo9424XBcZU3Nbn5Fcsyi3e4a/S/hB Pq5jwZaQ==; Received: from [2001:4bb8:188:3e21:6594:49:139:2b3f] (helo=localhost) by casper.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux)) id 1lvxvq-00FBzP-Mu; Wed, 23 Jun 2021 08:08:31 +0000 Date: Wed, 23 Jun 2021 10:08:21 +0200 From: Christoph Hellwig To: "Matthew Wilcox (Oracle)" Cc: akpm@linux-foundation.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 10/46] mm/rmap: Add folio_mkclean() Message-ID: References: <20210622121551.3398730-1-willy@infradead.org> <20210622121551.3398730-11-willy@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210622121551.3398730-11-willy@infradead.org> X-SRS-Rewrite: SMTP reverse-path rewritten from by casper.infradead.org. See http://www.infradead.org/rpr.html Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=E1JC7m0I; dmarc=none; spf=none (imf14.hostedemail.com: domain of BATV@casper.srs.infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=BATV@casper.srs.infradead.org X-Rspamd-Server: rspam02 X-Stat-Signature: uenkhea5jknx5u3oi3jihj4bedz5r8zp X-Rspamd-Queue-Id: 83DA3C0007C8 X-HE-Tag: 1624435794-962208 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Jun 22, 2021 at 01:15:15PM +0100, Matthew Wilcox (Oracle) wrote: > Transform page_mkclean() into folio_mkclean() and add a page_mkclean() > wrapper around folio_mkclean(). > > folio_mkclean is 15 bytes smaller than page_mkclean, but the kernel > is enlarged by 33 bytes due to inlining page_folio() into each caller. > This will go away once the callers are converted to use folio_mkclean(). > > Signed-off-by: Matthew Wilcox (Oracle) Looks good, Reviewed-by: Christoph Hellwig