From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A49C5C4743C for ; Wed, 23 Jun 2021 08:13:35 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 498846100B for ; Wed, 23 Jun 2021 08:13:35 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 498846100B Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 427C06B0036; Wed, 23 Jun 2021 04:13:34 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3FFF06B006C; Wed, 23 Jun 2021 04:13:34 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2EE616B0070; Wed, 23 Jun 2021 04:13:34 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0037.hostedemail.com [216.40.44.37]) by kanga.kvack.org (Postfix) with ESMTP id E4B156B0036 for ; Wed, 23 Jun 2021 04:13:33 -0400 (EDT) Received: from smtpin12.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 271BC18027A7F for ; Wed, 23 Jun 2021 08:13:34 +0000 (UTC) X-FDA: 78284274348.12.9F37DAA Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf08.hostedemail.com (Postfix) with ESMTP id 8B0A4801912B for ; Wed, 23 Jun 2021 08:13:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=MiB3zDfNv10kGNhwlVcglsJXNkF5Cte0DqzDu9o1lWg=; b=k89hJxRVtVmQCl2cF86fRzSzLf hP0kR4H6lEpYEd9+f+WHyE8k/Zqc6veYgSpnX57mWfgrRrrMBumOAqTDRMXZf4kjpm8qzGt/WfdZt ljII0gqzuFmwvf+q0FxhxqFthmh3reaFN7wmibROejgPbqrwKySMa7YNCSCcPNLMGG0myE3q/HIBo POXCsJ11IH3PdGr/P+a0S0VFUIGtFmTGSiayxaxzz15JVQ/XrAxPqF50cySxs/+Z9IdoB4Yr6RhGZ LRzMAk6fWBJN2hQ+OLbNEe2K5mIYDyJUAI74wZRDLmD591pzpeMTUOSzEABK1LbQXjn3T+iH9ucLJ Ft6kE5fA==; Received: from [2001:4bb8:188:3e21:6594:49:139:2b3f] (helo=localhost) by casper.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux)) id 1lvy01-00FCEY-Nu; Wed, 23 Jun 2021 08:12:52 +0000 Date: Wed, 23 Jun 2021 10:12:40 +0200 From: Christoph Hellwig To: "Matthew Wilcox (Oracle)" Cc: akpm@linux-foundation.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 12/46] mm/memcg: Use the node id in mem_cgroup_update_tree() Message-ID: References: <20210622121551.3398730-1-willy@infradead.org> <20210622121551.3398730-13-willy@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210622121551.3398730-13-willy@infradead.org> X-SRS-Rewrite: SMTP reverse-path rewritten from by casper.infradead.org. See http://www.infradead.org/rpr.html Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=k89hJxRV; dmarc=none; spf=none (imf08.hostedemail.com: domain of BATV@casper.srs.infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=BATV@casper.srs.infradead.org X-Stat-Signature: 7fktcpkx7q4uyzzjuj7w5c6tqy3gyd79 X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 8B0A4801912B X-HE-Tag: 1624436013-185028 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Jun 22, 2021 at 01:15:17PM +0100, Matthew Wilcox (Oracle) wrote: > static struct mem_cgroup_per_node * > -mem_cgroup_page_nodeinfo(struct mem_cgroup *memcg, struct page *page) > +mem_cgroup_nodeinfo(struct mem_cgroup *memcg, int nid) > { > - int nid = page_to_nid(page); > - > return memcg->nodeinfo[nid]; > } I'd just kill this function entirely and open code it into the only caller > - mctz = soft_limit_tree_from_page(page); > + mctz = soft_limit_tree_node(nid); And while were at it, soft_limit_tree_node seems like a completely pointless helper that does nothing but obsfucating the code. While you touch this area it might be worth to spin another patch to just remove it as well.