From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F0DC4C48BC2 for ; Wed, 23 Jun 2021 08:16:46 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id A73216108E for ; Wed, 23 Jun 2021 08:16:46 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A73216108E Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 953546B0036; Wed, 23 Jun 2021 04:16:45 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9031E6B0070; Wed, 23 Jun 2021 04:16:45 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7CBBE6B0071; Wed, 23 Jun 2021 04:16:45 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0241.hostedemail.com [216.40.44.241]) by kanga.kvack.org (Postfix) with ESMTP id 3F4046B0036 for ; Wed, 23 Jun 2021 04:16:45 -0400 (EDT) Received: from smtpin19.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 7175F1EA2D for ; Wed, 23 Jun 2021 08:16:45 +0000 (UTC) X-FDA: 78284282370.19.CF81CC7 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf30.hostedemail.com (Postfix) with ESMTP id 20AFBE0004F9 for ; Wed, 23 Jun 2021 08:16:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=gwJnjrGmOmRKMLmPbTtw+ZCguV53V/yBf3LdRKLnkl0=; b=QZXGSh/c42ufkxCsKAh9tQjtbg NrfUt1DFfE+2Vb9ZD/Yqa/dRTRNfnA1fna/nzULooC2Ns4kdwdRseOWO0Z5wqR0GQHo/jajtiBgvK aPbcM2fJrTQFiqIuP+wj2wqIhsFCCNGC90dLJPA99Z2UhPYF5+G2WldxyScyoJUZzyOH3drFjr1ey L6WutGVIkdLjXKZUdg6SuO1RMQpu9kXUVzyISaqIEyE5CttLwxhTQQxiMlPKV23ZVEKkpVnrebcXj wIURqRJmp+pSHnufmeOp9aEbJZaP4ObUMqz4NmnGKX1DZYhEt06m6KJCMAhBIy92rKtNOyishRdiF 9n+2yQ6w==; Received: from [2001:4bb8:188:3e21:6594:49:139:2b3f] (helo=localhost) by casper.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux)) id 1lvy2b-00FCMr-HS; Wed, 23 Jun 2021 08:15:40 +0000 Date: Wed, 23 Jun 2021 10:15:20 +0200 From: Christoph Hellwig To: "Matthew Wilcox (Oracle)" Cc: akpm@linux-foundation.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 14/46] mm/memcg: Add folio_charge_cgroup() Message-ID: References: <20210622121551.3398730-1-willy@infradead.org> <20210622121551.3398730-15-willy@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210622121551.3398730-15-willy@infradead.org> X-SRS-Rewrite: SMTP reverse-path rewritten from by casper.infradead.org. See http://www.infradead.org/rpr.html Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b="QZXGSh/c"; spf=none (imf30.hostedemail.com: domain of BATV@casper.srs.infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=BATV@casper.srs.infradead.org; dmarc=none X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: 20AFBE0004F9 X-Stat-Signature: 5c4gmgyzinqgxj7admp7upiee6jk9coj X-HE-Tag: 1624436205-631569 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Jun 22, 2021 at 01:15:19PM +0100, Matthew Wilcox (Oracle) wrote: > mem_cgroup_charge() already assumed it was being passed a non-tail > page (and looking at the callers, that's true; it's called for freshly > allocated pages). The only real change here is that folio_nr_pages() > doesn't compile away like thp_nr_pages() does as folio support > is not conditional on transparent hugepage support. Reimplement > mem_cgroup_charge() as a wrapper around folio_charge_cgroup(). Maybe rename __mem_cgroup_charge to __folio_charge_cgroup as well?