From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E4BDDC4743C for ; Wed, 23 Jun 2021 08:45:06 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id A191B61263 for ; Wed, 23 Jun 2021 08:45:06 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A191B61263 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 9EE486B0036; Wed, 23 Jun 2021 04:45:05 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9C5946B006C; Wed, 23 Jun 2021 04:45:05 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8B5C36B0070; Wed, 23 Jun 2021 04:45:05 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0069.hostedemail.com [216.40.44.69]) by kanga.kvack.org (Postfix) with ESMTP id 5A7D66B0036 for ; Wed, 23 Jun 2021 04:45:05 -0400 (EDT) Received: from smtpin08.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 974C923E79 for ; Wed, 23 Jun 2021 08:45:05 +0000 (UTC) X-FDA: 78284353770.08.725256E Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf24.hostedemail.com (Postfix) with ESMTP id 6A1CFA000273 for ; Wed, 23 Jun 2021 08:45:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=pGyg3TxGxSwTUf4kKztMzOWHjbCqMVwpOLy612N/GIw=; b=S7/g0HThhEN3YZ4H9tYEmH4O6S Q22Ei0sZ5qvVXhEETSVgKXkXjnLwyY6Aq/7rx0XpeYjBfDiCbAxrSS56GjP16MI71JZvbj6y3hFTA aT8mQ6WfnBKEdjNgEhi2oXWWSuywoCapUFhUePmUmBlaj5Y91bV8esY0jOH+mFw85tgohMLHIK2Ye nTkijeR/AGO8cBHdkSJD1/iUWQNpC3LUgULxWD+pQOXvEpis+KCWvO+TqxyfmMWQ11IfXkdJ+0l2X OQuQSVpuA1VWdIBPBY7pGNIxLAsp6A2qZ1eYz2bC6QsqbE4ZtCJTzDT4U8DxzCf2ClJEJ3qaW1+Gr CyZ6Mo5Q==; Received: from 089144193030.atnat0002.highway.a1.net ([89.144.193.30] helo=localhost) by casper.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux)) id 1lvyUP-00FDwU-5s; Wed, 23 Jun 2021 08:44:13 +0000 Date: Wed, 23 Jun 2021 10:41:54 +0200 From: Christoph Hellwig To: "Matthew Wilcox (Oracle)" Cc: akpm@linux-foundation.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 22/46] flex_proportions: Allow N events instead of 1 Message-ID: References: <20210622121551.3398730-1-willy@infradead.org> <20210622121551.3398730-23-willy@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210622121551.3398730-23-willy@infradead.org> X-SRS-Rewrite: SMTP reverse-path rewritten from by casper.infradead.org. See http://www.infradead.org/rpr.html Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b="S7/g0HTh"; dmarc=none; spf=none (imf24.hostedemail.com: domain of BATV@casper.srs.infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=BATV@casper.srs.infradead.org X-Stat-Signature: 4yzakotsbam95gbfis7tmqn43wr5kdka X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 6A1CFA000273 X-HE-Tag: 1624437905-131942 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Jun 22, 2021 at 01:15:27PM +0100, Matthew Wilcox (Oracle) wrote: > When batching events (such as writing back N pages in a single I/O), it > is better to do one flex_proportion operation instead of N. There is > only one caller of __fprop_inc_percpu_max(), and it's the one we're > going to change in the next patch, so rename it instead of adding a > compatibility wrapper. > > Signed-off-by: Matthew Wilcox (Oracle) Looks good, Reviewed-by: Christoph Hellwig