From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4CAB0C4743C for ; Wed, 23 Jun 2021 13:20:32 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id E184861075 for ; Wed, 23 Jun 2021 13:20:31 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E184861075 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id AFEEB6B0011; Wed, 23 Jun 2021 09:20:30 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id AAE756B0036; Wed, 23 Jun 2021 09:20:30 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 99D7C6B006C; Wed, 23 Jun 2021 09:20:30 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0018.hostedemail.com [216.40.44.18]) by kanga.kvack.org (Postfix) with ESMTP id 6AF7F6B0011 for ; Wed, 23 Jun 2021 09:20:30 -0400 (EDT) Received: from smtpin33.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 93F28180AD82F for ; Wed, 23 Jun 2021 13:20:30 +0000 (UTC) X-FDA: 78285047820.33.48A9321 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf24.hostedemail.com (Postfix) with ESMTP id 830E1A0021FC for ; Wed, 23 Jun 2021 13:20:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=PCiuVMRKNuvDVek4f2Qirj3VC8XGRRERUW2AchHc/MQ=; b=hcfWOuBJRoHFvIireuLopMJJIN 0mFj9pzL9E0v2HJFchjshkcfMrBODvjZXCYMcsfEIV79eOPVhChBwMqrB2gxf7Z6WyJmbW5BfKz7c NoeM6xCILm0Ju0EhokXO44NR4XYh58h76EzyxwJRuBEP+Rmgf8YwsWWXuBbNOw3yNyXC4rLjq41Us XoVdEBhsvMLjjrEfjI6iNwn8VzOM9NzwBwtQXxeH02gN8Uyv0GDKvUxmxRSrcRJjxCs7trNLRwZOW EcTPHIODyXkwpeN4uh2IH6+MVCUjCIlH3bIbdBLRwoa0nrgyjsIDuu8Dn/pGnCNuE/msZEb2paEcf zGJM0C3g==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1lw2n8-00FSzT-B9; Wed, 23 Jun 2021 13:19:48 +0000 Date: Wed, 23 Jun 2021 14:19:42 +0100 From: Matthew Wilcox To: Christoph Hellwig Cc: akpm@linux-foundation.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 35/46] mm/filemap: Add folio_mkwrite_check_truncate() Message-ID: References: <20210622121551.3398730-1-willy@infradead.org> <20210622121551.3398730-36-willy@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=hcfWOuBJ; spf=none (imf24.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none X-Stat-Signature: jaeqnxecms9g45s7em1u1xi8hp5rpbfr X-Rspamd-Queue-Id: 830E1A0021FC X-Rspamd-Server: rspam06 X-HE-Tag: 1624454429-624085 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Jun 23, 2021 at 11:47:58AM +0200, Christoph Hellwig wrote: > On Tue, Jun 22, 2021 at 01:15:40PM +0100, Matthew Wilcox (Oracle) wrote: > > This is the folio equivalent of page_mkwrite_check_truncate(). > > > > Signed-off-by: Matthew Wilcox (Oracle) > > Any reason that page_mkwrite_check_truncate isn't turned into a wrapper? It'd introduce an extra call to page_folio() for no actual benefit