From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D8066C4743C for ; Wed, 23 Jun 2021 09:59:13 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 8818D6112D for ; Wed, 23 Jun 2021 09:59:13 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8818D6112D Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 7D7526B0036; Wed, 23 Jun 2021 05:59:12 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 787B86B0071; Wed, 23 Jun 2021 05:59:12 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 64F766B0072; Wed, 23 Jun 2021 05:59:12 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0019.hostedemail.com [216.40.44.19]) by kanga.kvack.org (Postfix) with ESMTP id 2D5166B0036 for ; Wed, 23 Jun 2021 05:59:12 -0400 (EDT) Received: from smtpin10.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 6A93023E79 for ; Wed, 23 Jun 2021 09:59:12 +0000 (UTC) X-FDA: 78284540544.10.BDA76E5 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf27.hostedemail.com (Postfix) with ESMTP id 2D7578019373 for ; Wed, 23 Jun 2021 09:59:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=iH0tpXt8GJfX+4f0kNFBqSwnldGbSut7DrbyCImiM24=; b=rSen0Ki9x6jRV2vUrFJwY10Bs6 h+RK02kZENkhklTfkRVFqZ5scaMyoZQJePFTC754jWSNjScqBbNf6V7FTt9FTv3CoS+5N05j3GP9t 6MxuPaxWb0BGXqG49m1Sj/JrwFgRrVgTEnybs9MmZmMw90mxP+33Y+hhxjXgxG8Y9BwtSPK8r+XoV YlNPE3IMttoruC7jR+kCZQ648k8KJzBU+QqWxucyO0BosIojhfUyNSrYnO0MTNYSlqU+xz0Ol4FDC NHcKEKti0NMTxeOO/o6BE2Nl1Fk5HJIGrhvRB03oX5XFJ6RhUPUIIF+QDcTndJf2k2HbW9t2FwNto YipIJrDg==; Received: from [2001:4bb8:188:3e21:6594:49:139:2b3f] (helo=localhost) by casper.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux)) id 1lvzdz-00FI2U-Lv; Wed, 23 Jun 2021 09:58:20 +0000 Date: Wed, 23 Jun 2021 11:58:02 +0200 From: Christoph Hellwig To: "Matthew Wilcox (Oracle)" Cc: akpm@linux-foundation.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 41/46] mm/page_alloc: Add folio allocation functions Message-ID: References: <20210622121551.3398730-1-willy@infradead.org> <20210622121551.3398730-42-willy@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210622121551.3398730-42-willy@infradead.org> X-SRS-Rewrite: SMTP reverse-path rewritten from by casper.infradead.org. See http://www.infradead.org/rpr.html Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=rSen0Ki9; spf=none (imf27.hostedemail.com: domain of BATV@casper.srs.infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=BATV@casper.srs.infradead.org; dmarc=none X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: 2D7578019373 X-Stat-Signature: 4pkpbns7nwqwyichkfq83c3e45to415i X-HE-Tag: 1624442352-132484 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Jun 22, 2021 at 01:15:46PM +0100, Matthew Wilcox (Oracle) wrote: > +static inline > +struct folio *__alloc_folio_node(gfp_t gfp, unsigned int order, int nid) Weirdo prototype formatting. Otherwise looks good (assuming we grow callers): Reviewed-by: Christoph Hellwig