From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6A88BC4743C for ; Wed, 23 Jun 2021 11:33:36 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 36A876112D for ; Wed, 23 Jun 2021 11:33:36 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 36A876112D Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 332566B0011; Wed, 23 Jun 2021 07:33:35 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 309406B0036; Wed, 23 Jun 2021 07:33:35 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 183FD6B006C; Wed, 23 Jun 2021 07:33:35 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0141.hostedemail.com [216.40.44.141]) by kanga.kvack.org (Postfix) with ESMTP id D8F5B6B0011 for ; Wed, 23 Jun 2021 07:33:34 -0400 (EDT) Received: from smtpin01.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 0F66F23103 for ; Wed, 23 Jun 2021 11:33:35 +0000 (UTC) X-FDA: 78284778390.01.56885D4 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf18.hostedemail.com (Postfix) with ESMTP id 9640520015C5 for ; Wed, 23 Jun 2021 11:33:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=L0C38eSgFWGzhANcVbIDOYcAtDlPN8BpX4oY7srFPgs=; b=hxrKor8gJ4ne0kKz37Zge9aYGj wvlNxv8GznVqnfWkhKbYUXvRZBb56eEf78aCEUIMAuCF1ts6FQimLaQ1tcLj0ik0tFlCRpMc/+5zR 8DmPahMQTvDktrwxic7km2ZXeaE5lsO8rEPugXDtbznrSjbF38o4idJSdbWEYAhNLohKQ9/458G94 8uuKf7ifZYob0jWPlT0I90pImxfsORuAYoYi648yzfff3XsYHpe5RMrosOlYwEiGT6Lay6QnpbHCB kmB1xkxSL2/A+gJ003eAl9bsuDZFjVvTF2JStpSN4AxKdkJBB+aYDGMaUQXT6NDANF4sY94YA1M/y tw0HehZw==; Received: from [2001:4bb8:188:3e21:6594:49:139:2b3f] (helo=localhost) by casper.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux)) id 1lw17Y-00FMrc-IR; Wed, 23 Jun 2021 11:32:53 +0000 Date: Wed, 23 Jun 2021 13:32:39 +0200 From: Christoph Hellwig To: "Matthew Wilcox (Oracle)" Cc: akpm@linux-foundation.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 44/46] mm/filemap: Convert mapping_get_entry to return a folio Message-ID: References: <20210622121551.3398730-1-willy@infradead.org> <20210622121551.3398730-45-willy@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210622121551.3398730-45-willy@infradead.org> X-SRS-Rewrite: SMTP reverse-path rewritten from by casper.infradead.org. See http://www.infradead.org/rpr.html X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 9640520015C5 X-Stat-Signature: fozh5jdhrht4duwtp47u35931adkyuz7 Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=hxrKor8g; dmarc=none; spf=none (imf18.hostedemail.com: domain of BATV@casper.srs.infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=BATV@casper.srs.infradead.org X-HE-Tag: 1624448014-702814 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Jun 22, 2021 at 01:15:49PM +0100, Matthew Wilcox (Oracle) wrote: > - * Return: The head page or shadow entry, %NULL if nothing is found. > + * Return: The folio, swap or shadow entry, %NULL if nothing is found. This (old and new) reads a little weird, given that it returns a struct folio, even if that happens to be a magic entry. Otherwise looks good: Reviewed-by: Christoph Hellwig