From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BA8D1C4743C for ; Wed, 23 Jun 2021 11:40:44 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 84BC86102A for ; Wed, 23 Jun 2021 11:40:44 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 84BC86102A Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 6D14D6B0011; Wed, 23 Jun 2021 07:40:43 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 681926B0036; Wed, 23 Jun 2021 07:40:43 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4FC126B006C; Wed, 23 Jun 2021 07:40:43 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0198.hostedemail.com [216.40.44.198]) by kanga.kvack.org (Postfix) with ESMTP id 114236B0011 for ; Wed, 23 Jun 2021 07:40:43 -0400 (EDT) Received: from smtpin11.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id AA481181FA8DC for ; Wed, 23 Jun 2021 11:40:41 +0000 (UTC) X-FDA: 78284796282.11.F4C38EE Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf01.hostedemail.com (Postfix) with ESMTP id 02C9D5001533 for ; Wed, 23 Jun 2021 11:40:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=jGK9U4DdDhTnapEAkzMQa9BXuVanyBr75qSjp9gCCic=; b=fzHUSdynvSPD/EuKdmu1g+AnhF VxoW00t3XURKSmmS8da4p+dDSBE6jFkDpvbAiFmM1nQkxRa4wpQ31UuM/bFMBP1CJ6+7ypqS2DZWO Gq+yM0QMhQKfJkWktpiL1KfH0riBAgnTONY6KxOIPP5YniYEoasY2jf9FkmBM5pRRO8HIAUcB9XPo qLi0ryv1b0yuiSrXAWLPzBaMFzRTQIHD5iONYp3Zj536v06iQHVMnDPJ4HS75eAHu5O8jP9y5zI3Q xbYaF4ezJIdZVoILgUoSAWSEXNDnlI76b9vGfnjSs09vw1DqSJIP67fiJtNr7Dlhel//7VsWCeszj 4p9/DCGQ==; Received: from [2001:4bb8:188:3e21:6594:49:139:2b3f] (helo=localhost) by casper.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux)) id 1lw1EI-00FN9b-Ae; Wed, 23 Jun 2021 11:39:46 +0000 Date: Wed, 23 Jun 2021 13:39:37 +0200 From: Christoph Hellwig To: "Matthew Wilcox (Oracle)" Cc: akpm@linux-foundation.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 45/46] mm/filemap: Add filemap_get_folio Message-ID: References: <20210622121551.3398730-1-willy@infradead.org> <20210622121551.3398730-46-willy@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210622121551.3398730-46-willy@infradead.org> X-SRS-Rewrite: SMTP reverse-path rewritten from by casper.infradead.org. See http://www.infradead.org/rpr.html Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=fzHUSdyn; spf=none (imf01.hostedemail.com: domain of BATV@casper.srs.infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=BATV@casper.srs.infradead.org; dmarc=none X-Stat-Signature: mn9zpruppsmoypwwoyygc81y457wfs4e X-Rspamd-Queue-Id: 02C9D5001533 X-Rspamd-Server: rspam06 X-HE-Tag: 1624448440-763005 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: > /** > - * pagecache_get_page - Find and get a reference to a page. > + * __filemap_get_folio - Find and get a reference to a folio. Maybe filemap_get_folio_flags is a better name? Otherwise looks good: Reviewed-by: Christoph Hellwig