From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BC7F2C4743C for ; Wed, 23 Jun 2021 11:44:33 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 67C7661076 for ; Wed, 23 Jun 2021 11:44:33 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 67C7661076 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 609AD6B0036; Wed, 23 Jun 2021 07:44:32 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5E01B8D0003; Wed, 23 Jun 2021 07:44:32 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4CF1D8D0002; Wed, 23 Jun 2021 07:44:32 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0061.hostedemail.com [216.40.44.61]) by kanga.kvack.org (Postfix) with ESMTP id 0E5CD6B0036 for ; Wed, 23 Jun 2021 07:44:32 -0400 (EDT) Received: from smtpin01.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 47825181AF5E6 for ; Wed, 23 Jun 2021 11:44:32 +0000 (UTC) X-FDA: 78284805984.01.D5A8C42 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf25.hostedemail.com (Postfix) with ESMTP id C711F6000553 for ; Wed, 23 Jun 2021 11:44:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=QwteTGrc0JgAloV5P52YrryUR2KVU5hH5kPJQKfDHfk=; b=ag/lJ35ZaNavbqZxjrmgN1wCrX C/rEq5d/WBDZuCphrOpS64vxBbBY/XCqPFwRUEUlmBw1FIKz8qZ9/qX1XRYlj5y57hgLjeCHgKRmo Aoz/Yhc6FwaHTZVNgqH9D/8hJrJxPijS3GEBUZuLo3VuTFLPTtWaHuECSgHsbKo5I9OQQ4SBF2Lgk yH9KQZfa0Wwk2T0H8ZY+GokLy8Jzn5/dUD9xuCR/2J+T1A47MODpbvGYIqsqSh6f1wYyNEXe6LHw/ idSK1er37ymneA0yTanZJW+y3YLJE+Ni4gxIwVcRvdGxxSGjrtaUpVo6+2QL4c+Bn4m1FKtY3BqJq J35QLhlw==; Received: from [2001:4bb8:188:3e21:6594:49:139:2b3f] (helo=localhost) by casper.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux)) id 1lw1I3-00FNKb-Id; Wed, 23 Jun 2021 11:43:34 +0000 Date: Wed, 23 Jun 2021 13:43:30 +0200 From: Christoph Hellwig To: "Matthew Wilcox (Oracle)" Cc: akpm@linux-foundation.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 46/46] mm/filemap: Add FGP_STABLE Message-ID: References: <20210622121551.3398730-1-willy@infradead.org> <20210622121551.3398730-47-willy@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210622121551.3398730-47-willy@infradead.org> X-SRS-Rewrite: SMTP reverse-path rewritten from by casper.infradead.org. See http://www.infradead.org/rpr.html Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b="ag/lJ35Z"; spf=none (imf25.hostedemail.com: domain of BATV@casper.srs.infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=BATV@casper.srs.infradead.org; dmarc=none X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: C711F6000553 X-Stat-Signature: ccn4xcjpr83tj617fzjez4tbr44iiq98 X-HE-Tag: 1624448671-11585 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Jun 22, 2021 at 01:15:51PM +0100, Matthew Wilcox (Oracle) wrote: > Allow filemap_get_folio() to wait for writeback to complete (if the > filesystem wants that behaviour). This is the folio equivalent of > grab_cache_page_write_begin(), which is moved into the folio-compat > file as a reminder to migrate all the code using it. This paves the > way for getting rid of AOP_FLAG_NOFS once grab_cache_page_write_begin() > is removed. We actually should kill FGP_NOFS as well by switching everything over to memalloc_nofs_{save, restore} eventually, given how error prone all these manual flags settings are. > diff --git a/mm/folio-compat.c b/mm/folio-compat.c > index 78365eaee7d3..206bedd621d0 100644 > --- a/mm/folio-compat.c > +++ b/mm/folio-compat.c > @@ -115,6 +115,7 @@ void lru_cache_add(struct page *page) > } > EXPORT_SYMBOL(lru_cache_add); > > +noinline > struct page *pagecache_get_page(struct address_space *mapping, pgoff_t index, > int fgp_flags, gfp_t gfp) How did that sneak in here? Otherwise: Reviewed-by: Christoph Hellwig