From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7494DC49EA5 for ; Thu, 24 Jun 2021 16:20:23 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id E29C7613C3 for ; Thu, 24 Jun 2021 16:20:22 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E29C7613C3 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id AED306B0036; Thu, 24 Jun 2021 12:20:21 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A9D6A6B005D; Thu, 24 Jun 2021 12:20:21 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 916226B006C; Thu, 24 Jun 2021 12:20:21 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0246.hostedemail.com [216.40.44.246]) by kanga.kvack.org (Postfix) with ESMTP id 5E1F46B0036 for ; Thu, 24 Jun 2021 12:20:21 -0400 (EDT) Received: from smtpin04.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 749C8824556B for ; Thu, 24 Jun 2021 16:20:21 +0000 (UTC) X-FDA: 78289129842.04.F85FA41 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf13.hostedemail.com (Postfix) with ESMTP id 9DD7BE00025F for ; Thu, 24 Jun 2021 16:20:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=Uh3vgdb1Js3vfZajWdBPiGBpNjG65EW1C8MzQFof+dE=; b=Van2fFqSnECFap8RB8ZgiYbX+Q uuctjHg08u+iXh8IQ1nUK2WuqzaFljlIcQx+CpzzsGJ+/avEips/5xj2yJBLnzHggVDyaBK7UClw9 etcwNowymIVh3YfkGgvi9rwDeai2s5jF3eeSIywYkQBqEMaL6sdX+D+jqHzpfuqlBaamkVO3FR9c9 8vePVfTaFmVCz8fIBm6pQuAZjVilH3aMoQikqk8LHC4IlEpG4Vxxgbm2fjvDWskCj8ileSG/y0A5p UJ8dqfqpuNDy4Fzcn2IW5kfan49rAbR0OkmG6edAjIZuowt2I6nSKmu86Ld86d6qYKqeJ+5Cq4wsX U5pwjumw==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1lwS53-00GlUG-S9; Thu, 24 Jun 2021 16:19:56 +0000 Date: Thu, 24 Jun 2021 17:19:53 +0100 From: Matthew Wilcox To: Christoph Hellwig Cc: akpm@linux-foundation.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Johannes Weiner , Michal Hocko , Vladimir Davydov , cgroups@vger.kernel.org Subject: Re: [PATCH v2 12/46] mm/memcg: Use the node id in mem_cgroup_update_tree() Message-ID: References: <20210622121551.3398730-1-willy@infradead.org> <20210622121551.3398730-13-willy@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=Van2fFqS; dmarc=none; spf=none (imf13.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org X-Stat-Signature: gh6znb4qsg95m99m9hkxnsd96b79ttyh X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 9DD7BE00025F X-HE-Tag: 1624551620-102900 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Jun 23, 2021 at 10:12:40AM +0200, Christoph Hellwig wrote: > On Tue, Jun 22, 2021 at 01:15:17PM +0100, Matthew Wilcox (Oracle) wrote: > > static struct mem_cgroup_per_node * > > -mem_cgroup_page_nodeinfo(struct mem_cgroup *memcg, struct page *page) > > +mem_cgroup_nodeinfo(struct mem_cgroup *memcg, int nid) > > { > > - int nid = page_to_nid(page); > > - > > return memcg->nodeinfo[nid]; > > } > > I'd just kill this function entirely and open code it into the only > caller Done. > > - mctz = soft_limit_tree_from_page(page); > > + mctz = soft_limit_tree_node(nid); > > And while were at it, soft_limit_tree_node seems like a completely > pointless helper that does nothing but obsfucating the code. While > you touch this area it might be worth to spin another patch to just > remove it as well. I'm scared that if I touch this file too much, people will start to think I know something about memcgs. Happy to add it on; cc'ing maintainers.