From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 527EFC49EA6 for ; Thu, 24 Jun 2021 18:37:51 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id EEB92613CA for ; Thu, 24 Jun 2021 18:37:50 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org EEB92613CA Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id B93096B0036; Thu, 24 Jun 2021 14:37:49 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B696F6B005D; Thu, 24 Jun 2021 14:37:49 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A631A6B006C; Thu, 24 Jun 2021 14:37:49 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0028.hostedemail.com [216.40.44.28]) by kanga.kvack.org (Postfix) with ESMTP id 768516B0036 for ; Thu, 24 Jun 2021 14:37:49 -0400 (EDT) Received: from smtpin01.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 9BAF718F55 for ; Thu, 24 Jun 2021 18:37:49 +0000 (UTC) X-FDA: 78289476258.01.9320F98 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf16.hostedemail.com (Postfix) with ESMTP id 3607B8019378 for ; Thu, 24 Jun 2021 18:37:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=E+uLdTeJRbTTNHca4zI78GWb1XhxGHzRHR8t0yMnlDs=; b=sCqo0PLQqL9Uemwsd99lDLlnrO ppRBZb+YSjSy6ZehBdwNitdTNNRLyJZs3g9lkwyZ31Mne3wrcykwaRtEzxFCZr46QCCU2Ifwnhmc3 2fsfYU7mHUOPepEL1Bz9AX0xcqvAyFfuZQ646Ey3YdlzYqp/bB/ZEz1c08SDnIqbbBkmxLuZMC/CB +PMqu6RmbKL/fIMzXbQHZkw5CNYauqeMQxolFR0ILlQaOlrFTcQA9THOGi8ktWc4KQllzs6KaQes2 y64H2b9f2668qetRhHPwsp82Xl9oCj28v3JldJldk1ep/pGQM+o+JGbmBl7Oqq/GSAEsreqFXCP1h O/1ZoWLw==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1lwUEE-00GsyS-MO; Thu, 24 Jun 2021 18:37:33 +0000 Date: Thu, 24 Jun 2021 19:37:30 +0100 From: Matthew Wilcox To: Christoph Hellwig Cc: akpm@linux-foundation.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 27/46] mm/writeback: Add __folio_mark_dirty() Message-ID: References: <20210622121551.3398730-1-willy@infradead.org> <20210622121551.3398730-28-willy@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=sCqo0PLQ; dmarc=none; spf=none (imf16.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org X-Rspamd-Server: rspam02 X-Stat-Signature: d9caykre5iiqom1azkw9ta6w5x1agi4p X-Rspamd-Queue-Id: 3607B8019378 X-HE-Tag: 1624559869-191985 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Jun 23, 2021 at 11:27:12AM +0200, Christoph Hellwig wrote: > On Tue, Jun 22, 2021 at 01:15:32PM +0100, Matthew Wilcox (Oracle) wrote: > > Turn __set_page_dirty() into a wrapper around __folio_mark_dirty() (which > > can directly cast from page to folio because we know that set_page_dirty() > > calls filesystems with the head page). Convert account_page_dirtied() > > into folio_account_dirtied() and account the number of pages in the folio. > > Is it really worth micro-optimizing a transitional function like that? > I'd rather eat the overhead of the compound_page() call over adding hacky > casts like this. Fair enough. There's only three calls to it and one of them goes away this series.