From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 36AE0C49EA6 for ; Thu, 24 Jun 2021 18:34:02 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id B2A65613B1 for ; Thu, 24 Jun 2021 18:34:01 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B2A65613B1 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 7032B6B0036; Thu, 24 Jun 2021 14:34:00 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 68BF36B005D; Thu, 24 Jun 2021 14:34:00 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 52DD96B006C; Thu, 24 Jun 2021 14:34:00 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0060.hostedemail.com [216.40.44.60]) by kanga.kvack.org (Postfix) with ESMTP id 1BF8D6B0036 for ; Thu, 24 Jun 2021 14:34:00 -0400 (EDT) Received: from smtpin24.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 35985824C431 for ; Thu, 24 Jun 2021 18:34:00 +0000 (UTC) X-FDA: 78289466640.24.49BCF28 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf15.hostedemail.com (Postfix) with ESMTP id 64B61A000255 for ; Thu, 24 Jun 2021 18:33:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=27gdr9GSvfO5CF3yEwKFCm7q1VtJuFO06FodmKTbgyI=; b=B5skOgOzPkjY6bdrH6eVE/ThMW wb2P1xvxjFuadS+qxGqcZLTeSohMATb5xFoWLB6hWImSGJm0iTtUpo9TglE+a9db8XPmXafyFuMAj 4ZZeyYIKs1OlYOLOehy67kPaQq8s/1Ic7pyhs01bW960heZxbKudp2QhR7rDbnUZNQK2QyDRF46PM RXrV4e63262G9BAZfkn19Q53l6zpQrvVlOglbP4WayfmgBQBi+QWMrN9nSbTZVQpTi8T8Wm/AStFF Av+k203lhPZnDXTzGDZBywq+eSy0aXLMt6B6vmcVVkU7zqX3EIaOb+kSHkBWUHLmEZImvJDh2yJ0E vasxs2eQ==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1lwUAV-00GslE-B3; Thu, 24 Jun 2021 18:33:42 +0000 Date: Thu, 24 Jun 2021 19:33:39 +0100 From: Matthew Wilcox To: Christoph Hellwig Cc: akpm@linux-foundation.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 25/46] mm/writeback: Add folio_start_writeback() Message-ID: References: <20210622121551.3398730-1-willy@infradead.org> <20210622121551.3398730-26-willy@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=B5skOgOz; spf=none (imf15.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: 64B61A000255 X-Stat-Signature: mjhke4smatuzyq7y3ybf8yuh81fq1u46 X-HE-Tag: 1624559639-549066 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Jun 23, 2021 at 11:18:04AM +0200, Christoph Hellwig wrote: > > +static inline void set_page_writeback_keepwrite(struct page *page) > > { > > + folio_start_writeback_keepwrite(page_folio(page)); > > } > > > > +static inline bool test_set_page_writeback(struct page *page) > > { > > + return set_page_writeback(page); > > } > > Shouldn't these be in folio-compat.c as well? Thought about it. We only have one caller of set_page_writeback_keepwrite(), so it may as well get inlined there. And test_set_page_writeback() is just a renaming ... I'd rather replace the callers of test_set_page_writeback() with calls to the new set_page_writeback() than move it into folio-compat. > Otherwise looks good: > > Reviewed-by: Christoph Hellwig